Fix PHP warnings "preg_replace(): [...] invalid range in character class"
authorEdward Chernenko <edwardspec@gmail.com>
Mon, 18 Jun 2018 22:53:52 +0000 (01:53 +0300)
committerKunal Mehta <legoktm@member.fsf.org>
Tue, 16 Oct 2018 00:31:16 +0000 (17:31 -0700)
commitf80e50f318a350c4486d272b1bc1bb5c22715a7c
tree9ae0bb2441d287a698bc83c0ac9f8f637b5a9d81
parent18fcb2bf29eca1ad0c15aafaa3b4bf4b1c8a3355
Fix PHP warnings "preg_replace(): [...] invalid range in character class"

This was spotted when running tests on Travis (PHP 7.3 nighly, trusty).

Two expressions inside preg_replace() contained non-escaped "-" inside [],
where this "-" meant an actual "-" character.
The warning is because "-" has special meaning inside [] ("a-z" for range),
and things like [\w-.] are considered "invalid range".

Solution is to escape "-" like this: [\w\-.]

Change-Id: I41cc217081f00f54d957b6d8052ee209412f5ff6
(cherry picked from commit d88e924b6e5a7d529c471980e14f72430a94e546)
RELEASE-NOTES-1.31
includes/media/FormatMetadata.php
includes/upload/UploadStash.php