registration: Improve duplicate config setting exception
authorKunal Mehta <legoktm@member.fsf.org>
Tue, 15 May 2018 17:26:43 +0000 (10:26 -0700)
committerLegoktm <legoktm@member.fsf.org>
Tue, 15 May 2018 23:41:07 +0000 (23:41 +0000)
commit9e2aaa98c081b60b9c0c82cb0e9c564a40839ce2
tree6e803340b611cb38bb9b5c7dfd18f9b2baece837
parentb05a1697f3495d4cd8b47f3dd59e1f025c9f09ea
registration: Improve duplicate config setting exception

We don't keep track of what set a specific global, so at least mention
the name of the extension that is setting a duplicate for easier
debugging.

Also, fix the case where if the first extension to be loaded was setting
a core setting, it would not throw an exception since config was being
processed before the rest of extension.json. Now we process config after
all core settings, going only before attributes.

Bug: T194319
Change-Id: I4fd96e7d167cf0652ee3e8e66167c86f2b91b992
(cherry picked from commit 5490b1270a0a7447f28d2407736fc3c1deb41d44)
includes/registration/ExtensionProcessor.php