Replace call_user_func_array(), part 2
authorMax Semenik <maxsem.wiki@gmail.com>
Fri, 8 Jun 2018 02:58:35 +0000 (19:58 -0700)
committerMax Semenik <maxsem.wiki@gmail.com>
Fri, 8 Jun 2018 03:19:26 +0000 (20:19 -0700)
commit6e956d55aac4e4d7e6145ed51c44311ca0e9b0c7
treee4d7b0d367b0c6ba18f150ad3cf676c7532e34a9
parent7fb5c9580d7add238d7a7f5275b1081b3e8b250b
Replace call_user_func_array(), part 2

Uses new PHP 5.6 syntax like ...parameter unpacking and
calling anything looking like a callback to make the code more readable.
There are much more occurrences but this commit is intentionally limited
to an easily reviewable size.

In one occurrence, a simple conditional instead of trickery was much more readable.

This patch finishes all the easy stuf in the core, the remainder is either unobvious
or would result in smaller readability gains. It will be carefully dealt with in
further commits.

Change-Id: I79a16c48bfb98b75e5b99f2f6f4fa07b3ae02c5b
29 files changed:
includes/MergeHistory.php
includes/MovePage.php
includes/OutputPage.php
includes/Storage/RevisionRecord.php
includes/api/ApiQueryLinks.php
includes/api/ApiQueryTokens.php
includes/api/ApiQueryUserContribs.php
includes/auth/ButtonAuthenticationRequest.php
includes/exception/MWExceptionHandler.php
includes/htmlform/HTMLForm.php
includes/installer/WebInstaller.php
includes/libs/StatusValue.php
includes/libs/filebackend/FileBackend.php
includes/libs/lockmanager/MemcLockManager.php
includes/libs/lockmanager/RedisLockManager.php
includes/logging/LogEventsList.php
includes/media/BitmapHandler.php
includes/parser/Parser.php
includes/parser/ParserOutput.php
includes/resourceloader/ResourceLoaderContext.php
includes/skins/BaseTemplate.php
includes/specialpage/AuthManagerSpecialPage.php
includes/specialpage/ChangesListSpecialPage.php
includes/specialpage/SpecialPage.php
includes/specials/SpecialBlock.php
includes/upload/UploadBase.php
includes/upload/UploadFromChunks.php
maintenance/backup.inc
maintenance/storage/recompressTracked.php