rdbms: assorted LBFactoryMulti/LBFactorySimple cleanups
authorAaron Schulz <aschulz@wikimedia.org>
Tue, 23 Jul 2019 00:07:11 +0000 (17:07 -0700)
committerKrinkle <krinklemail@gmail.com>
Wed, 4 Sep 2019 20:18:44 +0000 (20:18 +0000)
commit3e1b29824bd7f2e79a59d4990fc7461d9941f68c
tree258aeea263fc54ba6262db0d616481f7a77a8574
parent0feaa32b515db29def29eaf5992e21987571232a
rdbms: assorted LBFactoryMulti/LBFactorySimple cleanups

Ignore "groupLoads" in "serverTemplate" for consistency with "load".
These server config map values should come from "groupLoadsBySection"
and "sectionLoads" only.

Simplify LBFactoryMulti::makeServerArray() to not bother setting values
that LoadBalancer already sets ('flags', 'master', 'replica').

Move down private methods and clean up a various code comments.

Change-Id: I0fe7f913a37236380127bef8d02768a9d1209596
includes/libs/rdbms/lbfactory/ILBFactory.php
includes/libs/rdbms/lbfactory/LBFactoryMulti.php
includes/libs/rdbms/lbfactory/LBFactorySimple.php