mail: Always quote uncoded names in MailAddress
authorAlexia E. Smith <washuu@gmail.com>
Tue, 10 Apr 2018 22:10:33 +0000 (17:10 -0500)
committerLegoktm <legoktm@member.fsf.org>
Thu, 26 Apr 2018 05:12:06 +0000 (05:12 +0000)
commit2ed1d8cd6149aa2ea904bed82163ac3727fa8e08
treedfe97b0e3809cd5891dedfe5efa454dacbfe3121
parent1bd573752fcdc21f26780258029ed38b90093ed7
mail: Always quote uncoded names in MailAddress

Otherwise, names that contain whitespace (but no special characters
that need Q-encoding) will be sent as-is in an email header. While
that's valid by RFC 1036, RFC 5322 and others, some mail programs
fail to correctly process spaces. Avoid these problems by simply
quoting the name always - except for cases which are Q-encoded,
which must remain unquoted to be valid (and also cannot contain
spaces, thus unaffected).

Before:
> From: Foo Bar <fb@example.org>

After:
> From "Foo Bar" <fb@example.org>

Update test to work with the new criteria.

Bug: T191931
Change-Id: I4b2a0a80e8b43ecc943939fc5ebaa356a4f840e0
(cherry picked from commit 2b28a56d8ac9a2393924a0b201cc39bd86fc4d15)
includes/mail/MailAddress.php
tests/phpunit/includes/mail/MailAddressTest.php