Don't reset name tables between test runs.
authordaniel <daniel.kinzler@wikimedia.de>
Wed, 22 Aug 2018 16:02:49 +0000 (18:02 +0200)
committerdaniel <daniel.kinzler@wikimedia.de>
Thu, 23 Aug 2018 17:15:33 +0000 (19:15 +0200)
commit2c7e4adcea9e8f77acbfb86b822e1cea6134528b
tree12e0d138096a7a598b44ae28a7a5802384a5d3de
parent73380233aab4e2009acdbaa8d6ac928c499408af
Don't reset name tables between test runs.

Resetting the content_model and slot_role tables between test runs
requires the corresponding NameTabelStore instances to be reset
as well. We may however have many of them, buried in various services.
There is no easy way to reset them consistently.

Letting information in these tables persist between tests seems
harmless. Tests that need these tables reset can simply add them
to the tablesUsed array.

This is needed for unit tests to work with the new MCR schema.

Bug: T198561
Change-Id: I63e61e1ab74e00c20930a83d3a3f5df53092a197
includes/Storage/NameTableStore.php
tests/phpunit/MediaWikiTestCase.php
tests/phpunit/includes/Storage/NameTableStoreTest.php
tests/phpunit/includes/Storage/PageUpdaterTest.php
tests/phpunit/includes/api/ApiBlockTest.php