From d2fd3109a34f1e619e901f8494eb1e2c25d57a0e Mon Sep 17 00:00:00 2001 From: Kunal Mehta Date: Tue, 20 Sep 2016 23:00:54 -0700 Subject: [PATCH] Avoid Wikimedia\Assert in HashBagOStuff This is the only usage of wikimedia/assert in the planned objectcache library, so it doesn't make much sense to have a dependency upon the entire library just for one usage that is trivially replaced. Change-Id: I8f967fb2b861852c7fc74f7d42e2cbab1df05bc4 --- includes/libs/objectcache/HashBagOStuff.php | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/includes/libs/objectcache/HashBagOStuff.php b/includes/libs/objectcache/HashBagOStuff.php index e03cec6a2f..baa3c32c6a 100644 --- a/includes/libs/objectcache/HashBagOStuff.php +++ b/includes/libs/objectcache/HashBagOStuff.php @@ -20,7 +20,6 @@ * @file * @ingroup Cache */ -use Wikimedia\Assert\Assert; /** * Simple store for keeping values in an associative array for the current process. @@ -46,7 +45,9 @@ class HashBagOStuff extends BagOStuff { parent::__construct( $params ); $this->maxCacheKeys = isset( $params['maxKeys'] ) ? $params['maxKeys'] : INF; - Assert::parameter( $this->maxCacheKeys > 0, 'maxKeys', 'must be above zero' ); + if ( $this->maxCacheKeys <= 0 ) { + throw new InvalidArgumentException( '$maxKeys parameter must be above zero' ); + } } protected function expire( $key ) { -- 2.20.1