From c9ada5c5597858522b8b9f94863da4edc2da95af Mon Sep 17 00:00:00 2001 From: Derk-Jan Hartman Date: Tue, 15 Jun 2010 15:06:11 +0000 Subject: [PATCH] Add the titles of interlanguage links to the tooltip of those pages (title attribute) --- RELEASE-NOTES | 1 + includes/Skin.php | 3 ++- includes/SkinTemplate.php | 1 + skins/MonoBook.php | 3 ++- skins/Vector.php | 2 +- 5 files changed, 7 insertions(+), 3 deletions(-) diff --git a/RELEASE-NOTES b/RELEASE-NOTES index 8224914609..b91295580c 100644 --- a/RELEASE-NOTES +++ b/RELEASE-NOTES @@ -82,6 +82,7 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN experimental feature. * Show validity period of the login cookie in Special:UserLogin and Special:Preferences +* Interlanguage links display the page title in their tooltip. === Bug fixes in 1.17 === * (bug 17560) Half-broken deletion moved image files to deletion archive diff --git a/includes/Skin.php b/includes/Skin.php index c28e60420a..c21bbc9f88 100644 --- a/includes/Skin.php +++ b/includes/Skin.php @@ -1894,12 +1894,13 @@ CSS; $nt = Title::newFromText( $l ); $url = $nt->escapeFullURL(); $text = $wgContLang->getLanguageName( $nt->getInterwiki() ); + $title = htmlspecialchars( $nt->getText() ); if ( $text == '' ) { $text = $l; } $style = $this->getExternalLinkAttributes(); - $s .= "{$text}"; + $s .= "{$text}"; } if( $wgContLang->isRTL() ) { $s .= ''; diff --git a/includes/SkinTemplate.php b/includes/SkinTemplate.php index 1a531fef8f..e795291932 100644 --- a/includes/SkinTemplate.php +++ b/includes/SkinTemplate.php @@ -433,6 +433,7 @@ class SkinTemplate extends Skin { 'href' => $nt->getFullURL(), 'text' => ( $wgContLang->getLanguageName( $nt->getInterwiki() ) != '' ? $wgContLang->getLanguageName( $nt->getInterwiki() ) : $l ), + 'title' => $nt->getText(), 'class' => $class ); } diff --git a/skins/MonoBook.php b/skins/MonoBook.php index bfe9b41337..82c1b550da 100644 --- a/skins/MonoBook.php +++ b/skins/MonoBook.php @@ -310,7 +310,8 @@ if($this->data['copyrightico']) { ?> diff --git a/skins/Vector.php b/skins/Vector.php index 2217de8dbc..279c795dab 100644 --- a/skins/Vector.php +++ b/skins/Vector.php @@ -639,7 +639,7 @@ class VectorTemplate extends QuickTemplate {
-- 2.20.1