From b7b2917a8b5a461d9f52caa64e435a847957a787 Mon Sep 17 00:00:00 2001 From: Brian Wolff Date: Fri, 11 Jul 2014 19:02:20 -0300 Subject: [PATCH] Use htmlspecialchars not htmlentities to escape tags on Version. htmlentities assumes that the text is iso 8859-1 prior to php 5.4 Also we use htmlspecialchars almost everywhere else. Bug: 67840 Change-Id: I73364ac34ef7a24c48c09ec1f87102a6cbee8d8f --- includes/specials/SpecialVersion.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/specials/SpecialVersion.php b/includes/specials/SpecialVersion.php index 576b625792..a857da4af2 100644 --- a/includes/specials/SpecialVersion.php +++ b/includes/specials/SpecialVersion.php @@ -513,7 +513,7 @@ class SpecialVersion extends SpecialPage { ); array_walk( $tags, function ( &$value ) { - $value = '<' . htmlentities( $value ) . '>'; + $value = '<' . htmlspecialchars( $value ) . '>'; } ); $out .= $this->listToText( $tags ); } else { -- 2.20.1