From 73be70fca1a8cd71f52ec6df245a8621d724817f Mon Sep 17 00:00:00 2001 From: Timo Tijhof Date: Fri, 25 Jan 2019 18:33:15 -0800 Subject: [PATCH] docs: Remove 'code-coverage' placeholder directory In 8 years, this is the first time I see this directory exists and that there is a Makefile that would write to it. I don't know if anyone uses that, but PHPUnit auto-creates this directory as needed. Hence, it need not exist ahead of time. It seems most contributors generate code coverage by invoking PHPUnit directory, which requires a path to be specified. Per https://mediawiki.org/wiki/Manual:PHP_unit_testing/Code_coverage, this tends to be docs/coverage, not docs/code-coverage. Change the Makefile to write there as well, as better example, and also add it to gitignore. Change-Id: I0a4cf716ea9b7fae89c282945b160b0dc7b2d02f --- .gitignore | 1 + docs/code-coverage/README | 2 -- tests/phpunit/Makefile | 2 +- 3 files changed, 2 insertions(+), 3 deletions(-) delete mode 100644 docs/code-coverage/README diff --git a/.gitignore b/.gitignore index 2f17bc6d5f..d25d52544d 100644 --- a/.gitignore +++ b/.gitignore @@ -25,6 +25,7 @@ sftp-config.json # MediaWiki install & usage /cache +/docs/coverage /docs/js /images/[0-9a-f] /images/archive diff --git a/docs/code-coverage/README b/docs/code-coverage/README deleted file mode 100644 index 76ce9bdc33..0000000000 --- a/docs/code-coverage/README +++ /dev/null @@ -1,2 +0,0 @@ -This directory is for the auto-generated phpunit code coverage. -Run 'make coverage' in the tests/phpunit subdirectory to build. diff --git a/tests/phpunit/Makefile b/tests/phpunit/Makefile index d34e1836b2..26d52179ec 100644 --- a/tests/phpunit/Makefile +++ b/tests/phpunit/Makefile @@ -39,7 +39,7 @@ tap: ${PU} --tap coverage: - ${PU} --coverage-html ../../docs/code-coverage + ${PU} --coverage-html ../../docs/coverage parser: ${PU} --group Parser -- 2.20.1