From 6f9da771513cc2e0bf7e059fed30b636596ca6d5 Mon Sep 17 00:00:00 2001 From: Kunal Mehta Date: Fri, 23 Jun 2017 12:23:55 -0700 Subject: [PATCH] API: Fix capitalization of SpecialRecentChanges* classes And use the magic ::class instead of plain strings. Noticed by logging added for T166759. Change-Id: I7694c272c255b5b1f7455e55e70ecc240a4ba61c --- includes/api/ApiFeedRecentChanges.php | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/includes/api/ApiFeedRecentChanges.php b/includes/api/ApiFeedRecentChanges.php index 0b04c8cc92..2a80dd5354 100644 --- a/includes/api/ApiFeedRecentChanges.php +++ b/includes/api/ApiFeedRecentChanges.php @@ -63,8 +63,8 @@ class ApiFeedRecentChanges extends ApiBase { $feedFormat = $this->params['feedformat']; $specialClass = $this->params['target'] !== null - ? 'SpecialRecentchangeslinked' - : 'SpecialRecentchanges'; + ? SpecialRecentChangesLinked::class + : SpecialRecentChanges::class; $formatter = $this->getFeedObject( $feedFormat, $specialClass ); @@ -90,12 +90,12 @@ class ApiFeedRecentChanges extends ApiBase { * Return a ChannelFeed object. * * @param string $feedFormat Feed's format (either 'rss' or 'atom') - * @param string $specialClass Relevant special page name (either 'SpecialRecentchanges' or - * 'SpecialRecentchangeslinked') + * @param string $specialClass Relevant special page name (either 'SpecialRecentChanges' or + * 'SpecialRecentChangesLinked') * @return ChannelFeed */ public function getFeedObject( $feedFormat, $specialClass ) { - if ( $specialClass === 'SpecialRecentchangeslinked' ) { + if ( $specialClass === SpecialRecentChangesLinked::class ) { $title = Title::newFromText( $this->params['target'] ); if ( !$title ) { $this->dieWithError( [ 'apierror-invalidtitle', wfEscapeWikiText( $this->params['target'] ) ] ); -- 2.20.1