From 300d97b7af8946c584dc79391ca819cf7c37c297 Mon Sep 17 00:00:00 2001 From: Roan Kattouw Date: Fri, 7 Jul 2017 15:36:13 -0700 Subject: [PATCH] RCFilters: Only build tag list when experimental views are enabled Follows-up 7725c755867ac1. It's a waste otherwise, and buildChangeTagList() has perf issues. Change-Id: Ifd7f81792fd7b5ee6e41ada756abbf0248f3eb36 --- includes/specials/SpecialRecentchanges.php | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/includes/specials/SpecialRecentchanges.php b/includes/specials/SpecialRecentchanges.php index 4f21586418..2fe56f989a 100644 --- a/includes/specials/SpecialRecentchanges.php +++ b/includes/specials/SpecialRecentchanges.php @@ -177,6 +177,9 @@ class SpecialRecentChanges extends ChangesListSpecialPage { ) ); + $experimentalStructuredChangeFilters = + $this->getConfig()->get( 'StructuredChangeFiltersEnableExperimentalViews' ); + $out->addJsConfigVars( 'wgStructuredChangeFilters', $jsData['groups'] ); $out->addJsConfigVars( 'wgStructuredChangeFiltersEnableSaving', @@ -184,16 +187,18 @@ class SpecialRecentChanges extends ChangesListSpecialPage { ); $out->addJsConfigVars( 'wgStructuredChangeFiltersEnableExperimentalViews', - $this->getConfig()->get( 'StructuredChangeFiltersEnableExperimentalViews' ) + $experimentalStructuredChangeFilters ); $out->addJsConfigVars( 'wgStructuredChangeFiltersEnableLiveUpdate', $this->getConfig()->get( 'StructuredChangeFiltersEnableLiveUpdate' ) ); - $out->addJsConfigVars( - 'wgRCFiltersChangeTags', - $this->buildChangeTagList() - ); + if ( $experimentalStructuredChangeFilters ) { + $out->addJsConfigVars( + 'wgRCFiltersChangeTags', + $this->buildChangeTagList() + ); + } } } -- 2.20.1