From 17221b41cb4b6b18082d6c6751483036a6975dfe Mon Sep 17 00:00:00 2001
From: Derk-Jan Hartman <hartman.wiki@gmail.com>
Date: Tue, 24 May 2016 20:16:07 +0200
Subject: [PATCH] Remove explicit tabindex from diff links

These were added to Special:RecentChanges in 2004, but it doesn't
match what we do in any of the other lists. For accessibility
purposes, in flow indexing is preferred these days, or alternatively
a JS controlled roving tabindex, but this was neither.

Bug: T116127
Change-Id: Id455fafe4bdea40fb5988bdec14eed672844c8e3
---
 includes/changes/ChangesList.php                      | 2 +-
 includes/changes/RCCacheEntryFactory.php              | 6 +++---
 tests/phpunit/includes/changes/OldChangesListTest.php | 1 -
 3 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/includes/changes/ChangesList.php b/includes/changes/ChangesList.php
index cf97afbb1e..b938ff0b35 100644
--- a/includes/changes/ChangesList.php
+++ b/includes/changes/ChangesList.php
@@ -366,7 +366,7 @@ class ChangesList extends ContextSource {
 			$diffLink = Linker::linkKnown(
 				$rc->getTitle(),
 				$this->message['diff'],
-				[ 'tabindex' => $rc->counter ],
+				[],
 				$query
 			);
 		}
diff --git a/includes/changes/RCCacheEntryFactory.php b/includes/changes/RCCacheEntryFactory.php
index 4c003d32dc..549bc3730e 100644
--- a/includes/changes/RCCacheEntryFactory.php
+++ b/includes/changes/RCCacheEntryFactory.php
@@ -174,7 +174,7 @@ class RCCacheEntryFactory {
 			$curLink = $curMessage;
 		} else {
 			$curUrl = htmlspecialchars( $cacheEntry->getTitle()->getLinkURL( $queryParams ) );
-			$curLink = "<a href=\"$curUrl\" tabindex=\"$counter\">$curMessage</a>";
+			$curLink = "<a href=\"$curUrl\">$curMessage</a>";
 		}
 
 		return $curLink;
@@ -217,10 +217,10 @@ class RCCacheEntryFactory {
 				return $diffMessage;
 			}
 			$diffUrl = htmlspecialchars( $pageTitle->getLinkURL( $queryParams ) );
-			$diffLink = "<a href=\"$diffUrl\" tabindex=\"$counter\">$diffMessage</a>";
+			$diffLink = "<a href=\"$diffUrl\">$diffMessage</a>";
 		} else {
 			$diffUrl = htmlspecialchars( $cacheEntry->getTitle()->getLinkURL( $queryParams ) );
-			$diffLink = "<a href=\"$diffUrl\" tabindex=\"$counter\">$diffMessage</a>";
+			$diffLink = "<a href=\"$diffUrl\">$diffMessage</a>";
 		}
 
 		return $diffLink;
diff --git a/tests/phpunit/includes/changes/OldChangesListTest.php b/tests/phpunit/includes/changes/OldChangesListTest.php
index 5746a61dc4..bc70a133e1 100644
--- a/tests/phpunit/includes/changes/OldChangesListTest.php
+++ b/tests/phpunit/includes/changes/OldChangesListTest.php
@@ -93,7 +93,6 @@ class OldChangesListTest extends MediaWikiLangTestCase {
 			'assert diff link'
 		);
 
-		$this->assertRegExp( '/tabindex="0"/', $line, 'assert tab index' );
 		$this->assertRegExp(
 			'/title=Cat&amp;curid=20131103212153&amp;action=history"/',
 			$line,
-- 
2.20.1