lhc/web/wiklou.git
10 years agoMerge "Cleaned up database reconnection logic"
jenkins-bot [Tue, 27 May 2014 18:17:02 +0000 (18:17 +0000)]
Merge "Cleaned up database reconnection logic"

10 years agoMerge "Installer: output css correctly when session errors occur"
jenkins-bot [Tue, 27 May 2014 18:15:37 +0000 (18:15 +0000)]
Merge "Installer: output css correctly when session errors occur"

10 years agoMerge "Use language from context in Skin::subPageSubtitle"
jenkins-bot [Tue, 27 May 2014 17:39:08 +0000 (17:39 +0000)]
Merge "Use language from context in Skin::subPageSubtitle"

10 years agoMerge "Add ar_text to the list from Revision::selectArchiveFields(). It is checked...
jenkins-bot [Tue, 27 May 2014 16:00:14 +0000 (16:00 +0000)]
Merge "Add ar_text to the list from Revision::selectArchiveFields(). It is checked later."

10 years agoMerge "Fix docs on File::getImageSize() they were very misleading"
jenkins-bot [Tue, 27 May 2014 14:53:08 +0000 (14:53 +0000)]
Merge "Fix docs on File::getImageSize() they were very misleading"

10 years agoMerge "Revert more visibility changes in HistoryBlob.php"
jenkins-bot [Tue, 27 May 2014 14:50:51 +0000 (14:50 +0000)]
Merge "Revert more visibility changes in HistoryBlob.php"

10 years agoMerge "Don't use isset() to check for null"
jenkins-bot [Tue, 27 May 2014 14:50:29 +0000 (14:50 +0000)]
Merge "Don't use isset() to check for null"

10 years agoAdd ar_text to the list from Revision::selectArchiveFields(). It is checked later.
Joerg [Tue, 27 May 2014 13:37:09 +0000 (09:37 -0400)]
Add ar_text to the list from Revision::selectArchiveFields(). It is checked later.

See Revision::newFromArchiveRow().  This is called from
populateRevisionLength.php's upgradeRow() which ultimately populates
$row from the fields returned by Revision::selectArchiveFields().

Revision::newFromArchiveRow() has the following condition:

if ( isset( $row->ar_text ) && !$row->ar_text_id ) {

And from the bug report:

> for old archived revisions, the rows in the archive table do _not_
> contain a pointer to the text in the text table, but that the text
> is stored in the archive table directly. Obviously the above code
> cannot handle this situation properly.

Credit goes to Joerg who found this and figured out the problem.

Bug: 65765
Change-Id: Iadcaae5e531d439780f5b6095286df78926ccaa7

10 years agoMerge "Change one Linker::formatSize call to Message::sizeParams"
jenkins-bot [Tue, 27 May 2014 10:55:04 +0000 (10:55 +0000)]
Merge "Change one Linker::formatSize call to Message::sizeParams"

10 years agoMerge "DBConnectionError: Expand {{SITENAME}} in pagetitle with Message::text()"
jenkins-bot [Tue, 27 May 2014 10:46:18 +0000 (10:46 +0000)]
Merge "DBConnectionError: Expand {{SITENAME}} in pagetitle with Message::text()"

10 years agoMerge "Restructure Media related tests to avoid duplicated code"
jenkins-bot [Tue, 27 May 2014 09:12:15 +0000 (09:12 +0000)]
Merge "Restructure Media related tests to avoid duplicated code"

10 years agoRestructure Media related tests to avoid duplicated code
Brian Wolff [Mon, 26 May 2014 20:16:07 +0000 (17:16 -0300)]
Restructure Media related tests to avoid duplicated code

Change-Id: I4428d38e0199b12255f3746e79f8093259a03da1

10 years agoMerge "Fix doc comments on get[General](Short|Long)Desc"
jenkins-bot [Tue, 27 May 2014 08:43:55 +0000 (08:43 +0000)]
Merge "Fix doc comments on get[General](Short|Long)Desc"

10 years agoMerge "SpecialRevisiondelete: Simplify if/elseif logic"
jenkins-bot [Tue, 27 May 2014 05:10:29 +0000 (05:10 +0000)]
Merge "SpecialRevisiondelete: Simplify if/elseif logic"

10 years agoSpecialRevisiondelete: Simplify if/elseif logic
umherirrender [Mon, 26 May 2014 18:21:10 +0000 (20:21 +0200)]
SpecialRevisiondelete: Simplify if/elseif logic

This avoids checking $comment twice
by Krinkle on I3b21f66f84d68777a18e66e4e5f59886e55d7936

Change-Id: I39df27d3edb097024d136455145505429ccdbe39

10 years agoMerge "DerivativeContext::setConfig should take a Config object"
jenkins-bot [Tue, 27 May 2014 04:23:35 +0000 (04:23 +0000)]
Merge "DerivativeContext::setConfig should take a Config object"

10 years agoMerge "Allow more flexibility in RC feeds"
jenkins-bot [Tue, 27 May 2014 02:43:24 +0000 (02:43 +0000)]
Merge "Allow more flexibility in RC feeds"

10 years agoDerivativeContext::setConfig should take a Config object
Kunal Mehta [Tue, 27 May 2014 02:36:59 +0000 (19:36 -0700)]
DerivativeContext::setConfig should take a Config object

Change-Id: Icc16a9c206c57fac2d26547cb874e02ef09c0485
Follows-Up: I13baec0b6d4ea7badf20b9c5f9b40846348838e4

10 years agoAllow more flexibility in RC feeds
Kunal Mehta [Tue, 27 May 2014 00:50:11 +0000 (17:50 -0700)]
Allow more flexibility in RC feeds

The user can now specify which feeds to send to in
RecentChange::notifyFeeds if they don't want to use
$wgRCFeeds.

Additionally, the 'formatter' in $wgRCFeeds can now be an object
rather than just a class name.

Change-Id: Ibfdffc17a934e35223887c123331795563102752

10 years agoMerge "Make abstract Config class truly implementation-agnostic"
jenkins-bot [Tue, 27 May 2014 01:43:39 +0000 (01:43 +0000)]
Merge "Make abstract Config class truly implementation-agnostic"

10 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Mon, 26 May 2014 19:58:28 +0000 (19:58 +0000)]
Localisation updates from https://translatewiki.net.

Change-Id: Idab23e6c2f532b1aae67dc15e9138f6602c15a0f

10 years agoUse language from context in Skin::subPageSubtitle
umherirrender [Mon, 26 May 2014 19:09:25 +0000 (21:09 +0200)]
Use language from context in Skin::subPageSubtitle

Change-Id: Ia6cff8aa9e0b12215839f8b9c5a64a09150d4002

10 years agoChange one Linker::formatSize call to Message::sizeParams
umherirrender [Mon, 26 May 2014 19:00:02 +0000 (21:00 +0200)]
Change one Linker::formatSize call to Message::sizeParams

Change-Id: I2a91f0ef1cf82360da2d17c7dc42633ae3e79100

10 years agoDBConnectionError: Expand {{SITENAME}} in pagetitle with Message::text()
Kevin Israel [Mon, 26 May 2014 17:40:34 +0000 (13:40 -0400)]
DBConnectionError: Expand {{SITENAME}} in pagetitle with Message::text()

Follows-up 485ff9ead94b by making the same change in DBConnectionError,
which overrides MWException::msg() to not use database messages.

Bug: 58447
Change-Id: Iafa9dd741f1f099a4a6cfb8cf655b7d5f504011a

10 years agoMake abstract Config class truly implementation-agnostic
Kunal Mehta [Sat, 10 May 2014 08:19:00 +0000 (01:19 -0700)]
Make abstract Config class truly implementation-agnostic

Follow up to I13baec0b6 ("Config: Add Config and GlobalConfig classes"):

Config:
* Rather than returning Status objects, Config::set will now throw an exception
  if an error is encountered
* Config::factory was moved into it's own ConfigFactory class.
* Since there are no more functions in it, Config was turned into an interface.

GlobalConfig:
* Remove $prefix args from Config::set and ::get. The idea of having an
  abstract Config class is to abstract some notion of configuration data from
  the particular way in which it is currently implemented (global variables).
  So the abstract base class has no business dealing with variable name
  prefixes.
** Instead GlobalVarConfig's implementations of get and set call getWithPrefix
   and setWithPrefix internally, which are now protected
* Rename GlobalConfig to GlobalVarConfig, which makes it clearer that it isn't
  referring to the scope of the configuration value, but to the scope of the
  variable name which provides it.

ConfigFactory:
* ConfigFactory is where Config objects are registered, and later constructed.
* Config objects are registered with a given name, and a callback factory function.
  This allows for implementations to construct the object with the parameters they want,
  and avoids the overhead of needing an entire class.
** The name 'main' is the default object returned by RequestContext::getConfig(),
   and is intended to be used by core.
* This is a singleton class, the main instance can be obtained with:
  ConfigFactory::getDefaultInstance()

In addition to the above:
* $wgConfigClass was removed, and $wgConfigRegistry was introduced, which
  stores a name => callback. The name is to be what the Config instance is
  registered with, and the callback should return an implementation of Config.
* Tests were written for the new ConfigFactory, and GlobalVarConfig's tests
  were improved.

Co-Authored-By: Ori Livneh <ori@wikimedia.org>
Co-Authored-By: Chad Horohoe <chadh@wikimedia.org>
Co-Authored-By: Mattflaschen <mflaschen@wikimedia.org>
Co-Authored-By: Parent5446 <tylerromeo@gmail.com>
Co-Authored-By: Reedy <reedy@wikimedia.org>
Co-Authored-By: Daniel Kinzler <daniel.kinzler@wikimedia.de>
Change-Id: I5a5857fcfa07598ba4ce9ae5bbb4ce54a567d31e

10 years agoMerge "Return value directly when using getter"
jenkins-bot [Mon, 26 May 2014 08:57:48 +0000 (08:57 +0000)]
Merge "Return value directly when using getter"

10 years agoMerge "Revert "Pass phpcs-strict on includes/revisiondelete/""
jenkins-bot [Sun, 25 May 2014 23:36:31 +0000 (23:36 +0000)]
Merge "Revert "Pass phpcs-strict on includes/revisiondelete/""

10 years agoRevert more visibility changes in HistoryBlob.php
Kevin Israel [Sun, 25 May 2014 13:12:00 +0000 (09:12 -0400)]
Revert more visibility changes in HistoryBlob.php

This follows-up bebcf2c58381, which only fixed DiffHistoryBlob.

MediaWiki will fail to load some revisions if the following properties
do not unserialize correctly:

* HistoryBlobStub::$mOldId
* HistoryBlobStub::$mHash
* HistoryBlobCurStub::$mCurId

Visibility of HistoryBlobStub::$mRef is also restored; though the
property's value does not appear to be used after unserialization,
the property is nevertheless a serialized property.

Bug: 65665
Change-Id: I2724d15f9206d66d615d020117e60bb772048c19

10 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sun, 25 May 2014 19:24:39 +0000 (19:24 +0000)]
Localisation updates from https://translatewiki.net.

Change-Id: I5fcddad181c862b8f825611aa2aa3a17864e1b28

10 years agoHTMLForm: fix double escaping of checkbox labels in vform
Pcoombe [Tue, 15 Apr 2014 14:58:51 +0000 (15:58 +0100)]
HTMLForm: fix double escaping of checkbox labels in vform

mLabel has already been escaped if required. It isn't run through htmlspecialchars()
in other display formats, so doesn't need to be done in vform.

Change-Id: I0b0feec408687cdadf01da5f2078980015538bb7

10 years agoMerge "Fix broken @return documentation"
jenkins-bot [Sun, 25 May 2014 07:45:03 +0000 (07:45 +0000)]
Merge "Fix broken @return documentation"

10 years agoMerge "Removed double hook explanation AfterFinalPageOutput"
jenkins-bot [Sun, 25 May 2014 06:28:53 +0000 (06:28 +0000)]
Merge "Removed double hook explanation AfterFinalPageOutput"

10 years agoRemoved double hook explanation AfterFinalPageOutput
florianschmidtwelzow [Sun, 25 May 2014 06:23:02 +0000 (08:23 +0200)]
Removed double hook explanation AfterFinalPageOutput

Bug: 65690
Change-Id: I0990568875db854579974f611e7378bca0b0eaed

10 years agoRevert "Pass phpcs-strict on includes/revisiondelete/"
Brian Wolff [Sun, 25 May 2014 01:38:41 +0000 (01:38 +0000)]
Revert "Pass phpcs-strict on includes/revisiondelete/"

Causes fatal when using revdeleting an old image

This reverts commit 2e8ec52154ad33680f92c3bf49d3b35ed5a33153.

Bug: 65733
Change-Id: I948cbf0f9a60929020d8cd92f4264bee7a11104e

10 years agoMerge "jquery.makeCollapsible: Use .prop() for value attribute of list item"
jenkins-bot [Sat, 24 May 2014 21:28:02 +0000 (21:28 +0000)]
Merge "jquery.makeCollapsible: Use .prop() for value attribute of list item"

10 years agojquery.makeCollapsible: Use .prop() for value attribute of list item
Timo Tijhof [Sat, 24 May 2014 01:27:25 +0000 (03:27 +0200)]
jquery.makeCollapsible: Use .prop() for value attribute of list item

The issue with "value" attributes is popularised through form
fields (e.g. change <input> value with prop, because it doesn't work
with attribute, attributes only change the DOM, not the live rendering).
However the attribute/property issue isn't limited to form fields and the
typical value/selected/disabled properties . It applies to all properties
and for any element that affects active state (if it changes the display,
one should use a property, not an attribute).

As far as I know, unlike for form fields, browsers do actually synchronise
attributes in the many of those cases (including list items), so there is
no immediate danger. But since it's caught by jQuery Migrate and a good
practice regardless, change it to use prop() as well.

To test:
 https://test.wikipedia.org/?oldid=199994#head-collapsible-ol

Change-Id: I246c26bd2958209feed73fc2ef31cf678b12fa3b

10 years agoFix broken @return documentation
Thiemo Mättig [Sat, 24 May 2014 20:06:01 +0000 (22:06 +0200)]
Fix broken @return documentation

I found one of these in Wikibase and run a global search.

Change-Id: I76c1519a47d7222f136272c59ea454b650808a86

10 years agoFix doc comments on get[General](Short|Long)Desc
Brian Wolff [Sat, 24 May 2014 19:10:46 +0000 (16:10 -0300)]
Fix doc comments on get[General](Short|Long)Desc

Follow up f3cc3980bc78afdb where somehow I managed to do this.

Change-Id: I25e5a01ddbecd1a991f6d121a7ac3f3598004b25

10 years agoFix docs on File::getImageSize() they were very misleading
Brian Wolff [Sat, 24 May 2014 17:27:36 +0000 (14:27 -0300)]
Fix docs on File::getImageSize() they were very misleading

Change-Id: I2a3e1e8c10da7ade4ea713a561e05fd4ab9203c8

10 years agoMerge "Localisation updates from https://translatewiki.net."
Translation updater bot [Sat, 24 May 2014 15:26:57 +0000 (15:26 +0000)]
Merge "Localisation updates from https://translatewiki.net."

10 years agoMerge "Revert "Restore search box tabindex""
jenkins-bot [Sat, 24 May 2014 15:06:02 +0000 (15:06 +0000)]
Merge "Revert "Restore search box tabindex""

10 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sat, 24 May 2014 15:03:00 +0000 (15:03 +0000)]
Localisation updates from https://translatewiki.net.

Change-Id: I978097374e44627aeb91f6fe740899be0ae29e97

10 years agoRevert "Restore search box tabindex"
Mattflaschen [Sat, 24 May 2014 14:54:42 +0000 (14:54 +0000)]
Revert "Restore search box tabindex"

This does not restore the same behavior as collapsibleNav.js had.  That
used $( document ).lastTabIndex() + 1 in JavaScript.  This means it
would dynamically put the search box's tabindex after other elements.

This commit specified an explicit value of 1.  This is normally used
for forms.  For example, 1 is the username field on Special:UserLogin.
Thus, this made tabbing from the username field take you to the search
input.  It also caused issues with at least MassMessage.

Another solution is necessary, whether it's dynamically adding it with
JavaScript as before, using a different PHP-generated tabindex, both
(PHP-generated tabindex overridden by JavaScript), or something else.

In the meantime, this reverts to avoid the mentioned regressions.

This reverts commit be76751e8c7a8c33b8a9f41faba78592a22ded09.

Bug: 29199
Bug: 65704
Change-Id: Iaea60834aa8f1564aca50c21ee62ae01f958cc65

10 years agoDon't use isset() to check for null
Alexandre Emsenhuber [Sat, 24 May 2014 05:45:33 +0000 (07:45 +0200)]
Don't use isset() to check for null

Fixes in includes/specials

Change-Id: I6c382aeaa92372bc11220694c479006e3c658362

10 years agoRemove not-working scripts in maintenance/language
Alexandre Emsenhuber [Sat, 24 May 2014 05:32:16 +0000 (07:32 +0200)]
Remove not-working scripts in maintenance/language

Change-Id: Idd6b1d5dc93a5bd71f0ad7445ce2f6ddc4beeb33

10 years agoCorrect a comment about updateRevisionOn
Adam Roses Wight [Wed, 21 May 2014 08:01:36 +0000 (01:01 -0700)]
Correct a comment about updateRevisionOn

to reflect its compare-and-swap semantics.

Change-Id: I6a68e673195e0b6688f6fbc9199a8355b20c0da0

10 years agoCheck category-move-redirect-override in content language
Jackmcbarn [Sat, 24 May 2014 04:18:53 +0000 (00:18 -0400)]
Check category-move-redirect-override in content language

When testing whether category-redirect-move-override is disabled, do it in
the content language rather than the user language.

Change-Id: Id1f03240c203f32a12953f49a075cfd5c25f0f31

10 years agoMerge "mediawiki.test.js: Suppress false postives for deprecated mw.* properties"
jenkins-bot [Sat, 24 May 2014 04:01:22 +0000 (04:01 +0000)]
Merge "mediawiki.test.js: Suppress false postives for deprecated mw.* properties"

10 years agoFollowup dd1c7f7fd7: fix LESSification errors in Parsoid styles
Roan Kattouw [Sat, 24 May 2014 03:02:16 +0000 (20:02 -0700)]
Followup dd1c7f7fd7: fix LESSification errors in Parsoid styles

.mw-halign-right should probably have float: right;, not float: left;

Also, use & because .mw-halign-* are applied to <figure>, not its descendants.

Bug: 65596
Change-Id: I7cd00f0049523f064703d7355b80457a4ab5d0d0

10 years agomediawiki.test.js: Suppress false postives for deprecated mw.* properties
Timo Tijhof [Sat, 24 May 2014 01:33:55 +0000 (03:33 +0200)]
mediawiki.test.js: Suppress false postives for deprecated mw.* properties

[qunit]
  mediawiki.jscompat...OK
  mediawiki - Initial check...
   Use of "anonymous" is deprecated. Use mw.user.isAnon instead.
   Use of "name" is deprecated. Use mw.user.getName instead.
   Use of "jsMessage" is deprecated. Use mw.notify instead.
   Use of "wikiGetlink" is deprecated. Use mw.util.getUrl instead.
  OK
  mediawiki - mw.Map...OK
  mediawiki - mw.config...OK
  mediawiki - mw.msg...OK
  mediawiki - mw.loader...OK

Change-Id: I4a79bc64cc26c1237fefe1503504cde9d40a5087

10 years agojquery.autoEllipsis.test: Swap $.browser for $.client for compatibility
James D. Forrester [Sat, 24 May 2014 00:28:10 +0000 (17:28 -0700)]
jquery.autoEllipsis.test: Swap $.browser for $.client for compatibility

Change-Id: I50d57371edebe7f93f01c83284c0a94fc2e7dbac

10 years agoMerge "Store page_id in logging table for deletions and make queryable"
jenkins-bot [Fri, 23 May 2014 23:15:55 +0000 (23:15 +0000)]
Merge "Store page_id in logging table for deletions and make queryable"

10 years agoMerge "Make HTTPS port configurable"
jenkins-bot [Fri, 23 May 2014 22:47:03 +0000 (22:47 +0000)]
Merge "Make HTTPS port configurable"

10 years agoMerge "MagicWord: Fix an indent"
jenkins-bot [Fri, 23 May 2014 21:39:37 +0000 (21:39 +0000)]
Merge "MagicWord: Fix an indent"

10 years agoMagicWord: Fix an indent
Bartosz Dziewoński [Fri, 23 May 2014 21:24:13 +0000 (23:24 +0200)]
MagicWord: Fix an indent

Change-Id: I3640fb7a783a68c43a1249b87ef04e587dd0cfd5

10 years agoMerge "Make sure DjVu files do not attempt metadata extraction repeatedly"
jenkins-bot [Fri, 23 May 2014 20:41:47 +0000 (20:41 +0000)]
Merge "Make sure DjVu files do not attempt metadata extraction repeatedly"

10 years agoMerge "Do not include user column on Special:MyUploads"
jenkins-bot [Fri, 23 May 2014 20:27:19 +0000 (20:27 +0000)]
Merge "Do not include user column on Special:MyUploads"

10 years agoMerge "Document ArticleUndelete change"
jenkins-bot [Fri, 23 May 2014 20:24:32 +0000 (20:24 +0000)]
Merge "Document ArticleUndelete change"

10 years agoMerge "Prevent deleteBatch.php deleting files from redirects"
jenkins-bot [Fri, 23 May 2014 20:19:19 +0000 (20:19 +0000)]
Merge "Prevent deleteBatch.php deleting files from redirects"

10 years agoMerge "Revert visibility change on DiffHistoryBlob::$mCompressed"
jenkins-bot [Fri, 23 May 2014 18:59:55 +0000 (18:59 +0000)]
Merge "Revert visibility change on DiffHistoryBlob::$mCompressed"

10 years agoMerge "Made getName() in ArchivedFile work when loaded via sha1"
jenkins-bot [Fri, 23 May 2014 18:52:59 +0000 (18:52 +0000)]
Merge "Made getName() in ArchivedFile work when loaded via sha1"

10 years agoPrevent deleteBatch.php deleting files from redirects
withoutaname [Fri, 9 May 2014 07:34:19 +0000 (00:34 -0700)]
Prevent deleteBatch.php deleting files from redirects

Previous behavior had the maintenance script deleteBatch.php
delete both the redirect in the file namespace and the file
from the target page the redirect is pointing to. This is
no longer the case, but it will still delete the redirect
page if it is still on the listfile.

Bug: 52587
Change-Id: I83374ddb98131f9f8f766bb2b444ab3e7cda7735

10 years agoRevert visibility change on DiffHistoryBlob::$mCompressed
Brad Jorsch [Fri, 23 May 2014 15:06:06 +0000 (11:06 -0400)]
Revert visibility change on DiffHistoryBlob::$mCompressed

Changing the visibility from public to protected causes unserialization
to fail.

Bug: 65665
Change-Id: Id7ee2068749ff421fab4d1c9067763adf4b89563

10 years agoReturn value directly when using getter
Stephan Muggli [Fri, 23 May 2014 14:00:23 +0000 (16:00 +0200)]
Return value directly when using getter

It is not necessary to save the value in a variable

Change-Id: Ia58c94bb19e22476821451bddc2f66e556b773f6

10 years agoImproved FileBackend failure logging a bit
Aaron Schulz [Fri, 23 May 2014 00:37:33 +0000 (17:37 -0700)]
Improved FileBackend failure logging a bit

* This partly follows up on 2cfce9f

Change-Id: I9d15f44d8000f52fd7b307d358c895452ee96a8d

10 years agoMake sure DjVu files do not attempt metadata extraction repeatedly
Brian Wolff [Fri, 23 May 2014 00:00:21 +0000 (21:00 -0300)]
Make sure DjVu files do not attempt metadata extraction repeatedly

If a file is broken, we don't want to spend time trying to find
its metadata over and over again.

Bug: 41090
Change-Id: Iad63b8942af99e1ec44530599a43ec1d6b2b8a62

10 years agoMediaWiki::performAction, return 404 on nosuchaction error
Sergio Santoro [Thu, 22 May 2014 22:17:23 +0000 (00:17 +0200)]
MediaWiki::performAction, return 404 on nosuchaction error

Nosuchaction error page was sending 200 as the HTTP status code,
which was misleading. Instead return 404.

Change-Id: I9b432c9e53caf0a13e9a0c798f78a7bd8a78443b

10 years agoMade getName() in ArchivedFile work when loaded via sha1
Aaron Schulz [Thu, 22 May 2014 20:46:13 +0000 (13:46 -0700)]
Made getName() in ArchivedFile work when loaded via sha1

Change-Id: I44e9c129f6c5841f8cbc9792aa9ff0f353bce6c0

10 years agoMerge "API: Enforce section=new constraint when using 'redirect' mode"
jenkins-bot [Thu, 22 May 2014 20:16:38 +0000 (20:16 +0000)]
Merge "API: Enforce section=new constraint when using 'redirect' mode"

10 years agoMerge "format the tests/phpunit/TODO document for readability"
jenkins-bot [Thu, 22 May 2014 20:15:32 +0000 (20:15 +0000)]
Merge "format the tests/phpunit/TODO document for readability"

10 years agoAPI: Enforce section=new constraint when using 'redirect' mode
Adam Roses Wight [Sun, 18 May 2014 07:04:36 +0000 (00:04 -0700)]
API: Enforce section=new constraint when using 'redirect' mode

Finish implementation of the 'redirect' edit API parameter.  This flag
should only be used as a convenience when adding a new section, appending,
or prepending.  Any other usage must be done using the long-cut (fetch page,
determine if it is a redirect, follow redirects and edit the target page's
content).

This patch takes apart the "EditConflict_redirect" test, because it no
longer makes sense--unless you dear reader can figure out how to force an
edit conflict when only adding a section?

Bug: 24330
Change-Id: Ie3f7273c18e156da1e50e1a36aac2e5341710982

10 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Thu, 22 May 2014 19:45:27 +0000 (19:45 +0000)]
Localisation updates from https://translatewiki.net.

Change-Id: I589dbdf292abaf998d18fe553b7afb4880cb40de

10 years agoDo not include user column on Special:MyUploads
Brian Wolff [Thu, 22 May 2014 19:28:16 +0000 (16:28 -0300)]
Do not include user column on Special:MyUploads

If Special:ListFiles is being filtered to show only a specific
user, then there's not much point showing which user uploaded
the image, as they are all uploaded by the same user.

Bug: 30627
Change-Id: Ibe1be82cb8f3354889051ef00f3c0b9f9ea5180e

10 years agoMerge "wfDebugMem: Fix binary prefix and improve usability"
jenkins-bot [Thu, 22 May 2014 19:25:08 +0000 (19:25 +0000)]
Merge "wfDebugMem: Fix binary prefix and improve usability"

10 years agoMerge "Cached misses in getMulti should be omitted"
jenkins-bot [Thu, 22 May 2014 19:14:59 +0000 (19:14 +0000)]
Merge "Cached misses in getMulti should be omitted"

10 years agoCached misses in getMulti should be omitted
Matthias Mullie [Thu, 22 May 2014 13:48:20 +0000 (15:48 +0200)]
Cached misses in getMulti should be omitted

SqlBagOStuff::getMulti currently returns an array with false values for missed
cache keys.
Default BagOStuff::getMulti (and other specific implementations like memcached),
however, just omit missed values.

e.g.:

    $cache->getMulti( array( 'goodkey' 'badkey' ) );

should return

    array( 'goodkey' => 'value' );

instead of

    array( 'goodkey' => 'value', 'badkey' => false );

Bug: 65637
Change-Id: Ib2de06a0f76421094707f7ad4218346087f4dc55

10 years agoMerge "Apply correct line-height to diffs"
jenkins-bot [Thu, 22 May 2014 15:04:34 +0000 (15:04 +0000)]
Merge "Apply correct line-height to diffs"

10 years agoApply correct line-height to diffs
Erwin Dokter [Sun, 18 May 2014 15:22:06 +0000 (15:22 +0000)]
Apply correct line-height to diffs

The typography refresh exposes a small shortcoming in the CSS used
for diff display; there is no line-height applied, causing inconsistent
display between skin (ie. too high in Vector). Adding line-height to the
diffs corrects this.

Bug: 64653
Change-Id: I59dfe3e887c68a7034ef78f6873127ffe88b0cc1

10 years agowfDebugMem: Fix binary prefix and improve usability
Sergio Santoro [Thu, 22 May 2014 14:22:12 +0000 (16:22 +0200)]
wfDebugMem: Fix binary prefix and improve usability

* Fix: wfDebugMem no longer reports kibibytes as kilobytes
* Usability: wfDebugMem now uses unit symbols (e.g. KiB)

Change-Id: I1ab8aa3ccdb0fdea307913ada4ed42964d7fe960

10 years agop-lang-list was removed
Federico Leva [Thu, 22 May 2014 13:12:46 +0000 (15:12 +0200)]
p-lang-list was removed

Contrite followup to I220057c799bef7e8c4d964f47d56f61ec120d8c2

Change-Id: I028880cfa9946e628832a303779d6b3ffcf16620

10 years agoRestore search box tabindex
Alex Monk [Wed, 21 May 2014 15:16:44 +0000 (16:16 +0100)]
Restore search box tabindex

This was set by JS in collapsibleNav (wtf?) until I220057c7 nuked that module entirely.

A user needed this for accessibility reasons (details in OTRS#2014051610008141)

Bug: 29199
Change-Id: I74725c01a2058be1151927661c22ce42a1463f91

10 years agoMerge "Removed begin/commit calls that result in error spam"
jenkins-bot [Thu, 22 May 2014 08:45:10 +0000 (08:45 +0000)]
Merge "Removed begin/commit calls that result in error spam"

10 years agoMerge "Fixed possible race condition in LocalFileMoveBatch"
jenkins-bot [Thu, 22 May 2014 04:56:48 +0000 (04:56 +0000)]
Merge "Fixed possible race condition in LocalFileMoveBatch"

10 years agoMerge "whitespace fixup"
jenkins-bot [Wed, 21 May 2014 23:29:11 +0000 (23:29 +0000)]
Merge "whitespace fixup"

10 years agoRemoved begin/commit calls that result in error spam
Aaron Schulz [Wed, 21 May 2014 22:50:15 +0000 (15:50 -0700)]
Removed begin/commit calls that result in error spam

* The delete calls already try to start transactions. Also CLI scripts
  run in autocommit mode anyway.

Change-Id: I433691b3e4e578983e4e15334248f029e0b0d277

10 years agoUse square bounding boxes for default-sized thumbnails
C. Scott Ananian [Tue, 25 Mar 2014 16:48:55 +0000 (12:48 -0400)]
Use square bounding boxes for default-sized thumbnails

Thumbnails for portrait-orientation images have always been "too big",
especially when displayed in a gallery.  The 'upright' option did not
completely fix the issue.  Using a square bounding box for thumbnails
(and 'framed' images) without an explicit size specifiction provides
a better default appearance.

This also provides a clean syntax for content authored using
Parsoid/Visual Editor, which prefers square bounding boxes.

See:
https://www.mediawiki.org/wiki/Requests_for_comment/Square_bounding_boxes

Bug: 63903
Change-Id: I665d8945843d3b5437a74e376b63c44965590116

10 years agoMerge "Localisation updates from https://translatewiki.net."
Translation updater bot [Wed, 21 May 2014 20:28:18 +0000 (20:28 +0000)]
Merge "Localisation updates from https://translatewiki.net."

10 years agoUpdate OOjs UI to v0.1.0-pre (0436296667)
James D. Forrester [Wed, 21 May 2014 20:17:16 +0000 (13:17 -0700)]
Update OOjs UI to v0.1.0-pre (0436296667)

New changes:
a5086f2 test: Drop 'OO.ui' file prefix in test suites
03ed3e9 Support strings in FlaggableElement#setFlags
be7b458 ConfirmationDialog: Clean up setup() documentation
b9ae654 build: Enable jscs "requireSpacesInsideArrayBrackets" rule
0436296 Localisation updates from https://translatewiki.net.

Change-Id: Id55715d0b2b0869349b3514b783700df26704445

10 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Wed, 21 May 2014 20:13:51 +0000 (20:13 +0000)]
Localisation updates from https://translatewiki.net.

Change-Id: I18db039de1ae9525f340d661eefff9e05f9206c5

10 years agoMerge "Create a version of mediawiki.skinning.content for Parsoid HTML"
jenkins-bot [Wed, 21 May 2014 18:36:17 +0000 (18:36 +0000)]
Merge "Create a version of mediawiki.skinning.content for Parsoid HTML"

10 years agoMerge "Fix: numFields wrong for sqlite"
jenkins-bot [Wed, 21 May 2014 17:49:27 +0000 (17:49 +0000)]
Merge "Fix: numFields wrong for sqlite"

10 years agomediawiki.user: Add message to deprecation of name() and anonymous()
Timo Tijhof [Wed, 21 May 2014 17:26:22 +0000 (19:26 +0200)]
mediawiki.user: Add message to deprecation of name() and anonymous()

Follows-up de5e135. Forgot to add the message that says what to
use instead (like we do in mw.util and mw.toolbar already).

Change-Id: Ib6b6aece70b2e681ca291e376ddfc884c8a11033

10 years agoMove release notes for "Move redirect rendering into WikitextContent" to 1.24
Timo Tijhof [Wed, 21 May 2014 15:41:19 +0000 (17:41 +0200)]
Move release notes for "Move redirect rendering into WikitextContent" to 1.24

Follows-up Id44d566a7ca3, the commit was merged before the
branch cut and then reverted in REL_23 (I7431eb83a092).
The notes were never fixed in master.

Change-Id: I9ef5263ac8f7b8050bb1c6e7933cde6020389c90

10 years agoSync 1.23 release notes for bug 13250 from REL1_23
Timo Tijhof [Wed, 21 May 2014 15:30:54 +0000 (17:30 +0200)]
Sync 1.23 release notes for bug 13250 from REL1_23

Change I17dde71858fa655 was merged after the branch cut, and did
not have release notes. Then whoever backported it to REL1_23 decided
it really should have release notes and wrote them directly in
REL1_23...

Change-Id: Iceeb6c039059e11c1854e32ee086ec9f53f29a03

10 years agoSync 1.23 release notes for bug 64289 from REL1_23
Timo Tijhof [Wed, 21 May 2014 15:27:54 +0000 (17:27 +0200)]
Sync 1.23 release notes for bug 64289 from REL1_23

Change Ib97f47ef1 was merged after the branch cut, but did not
have release notes. Then whoever backported it to REL1_23 decided
it really should have release notes and wrote them directly in
REL1_23...

Change-Id: I5d36dc86f10e757cac286bcb9b63c9e711a921b9

10 years agoMove release notes for "Introducing pp_sortkey" to 1.24
Timo Tijhof [Wed, 21 May 2014 15:22:57 +0000 (17:22 +0200)]
Move release notes for "Introducing pp_sortkey" to 1.24

Follows-up I217c42656 and Iaa78a8254, the commit was merged
before the branch cut and then reverted in REL1_23. The notes
were never fixed in master.

Change-Id: I5355ac405aef4d2b0d660205bc1231c6eb35c02d

10 years agoFixup typography changes release notes between 1.23 and 1.14
Timo Tijhof [Wed, 21 May 2014 15:04:28 +0000 (17:04 +0200)]
Fixup typography changes release notes between 1.23 and 1.14

Hotfix I595feec9a to REL1_23 changes release notes directly
in REL1_23 without applying to master first. The files are now
out of sync.

* Sync the line in RELEASE-NOTES-1.23 with what is in REL1_23
  (basically cherry-picking hotfix I595feec9a from REL1_23 to
  master here).

* Move the remainder to RELEASE-NOTES-1.24.

Change-Id: Ic3dc2655101086521403cfc9929887a97bbed811

10 years agoMove release notes for "Introducing pp_sortkey" to 1.24
Timo Tijhof [Wed, 21 May 2014 14:54:54 +0000 (16:54 +0200)]
Move release notes for "Introducing pp_sortkey" to 1.24

Follows-up I217c42656fb877f, the commit was merged after the
branch cut and was not backported.

Change-Id: Iaa78a8254b3114600052005ce28d752b5f472354

10 years agoAdd method to determine EnhancedChangesList cache grouping key
aude [Fri, 11 Apr 2014 10:35:42 +0000 (12:35 +0200)]
Add method to determine EnhancedChangesList cache grouping key

Change-Id: Iaf3734baa53b71affca77d5243a579cc70bb522b

10 years agoMerge "mediawiki.searchSuggest: Code clean up"
jenkins-bot [Wed, 21 May 2014 13:21:20 +0000 (13:21 +0000)]
Merge "mediawiki.searchSuggest: Code clean up"