lhc/web/wiklou.git
11 years agofix replaceSection for models that don't support sections
daniel [Mon, 23 Jul 2012 11:19:22 +0000 (13:19 +0200)]
fix replaceSection for models that don't support sections

Change-Id: Ib60c616f572bf143e3ea63f269f7a0b0701f144c

11 years agoAdded assertArrayEquals method to MediaWikiTestCase to avoid duplicating asort and...
jeroendedauw [Mon, 2 Jul 2012 14:24:10 +0000 (16:24 +0200)]
Added assertArrayEquals method to MediaWikiTestCase to avoid duplicating asort and array_values all over the place

Change-Id: I8e8e7257b74268dff8c0d105a399257dfdc01b40

11 years agoCLI install exited with 0 status code
Antoine Musso [Sat, 7 Jul 2012 18:09:45 +0000 (20:09 +0200)]
CLI install exited with 0 status code

The CliInstaller used the '0' exit code whenever the status was not OK.
That makes third party script assuming the install actually ran fine
since a 0 exit code is mostly considered as a success. By sending an
error code > 0 (here 1), our automatic installers will be able to catch
the failure and stop proceeding.

I had that issue with a Jenkins job which ran the CLI installer and kept
continuing although there was an error about LocalSettings.php already
existing.

Change-Id: I4f4727df85c09c0a04e4630df91c6213dfce6e9a

11 years agoRevisionTest might need database access
Antoine Musso [Fri, 6 Jul 2012 15:35:21 +0000 (17:35 +0200)]
RevisionTest might need database access

By adding '@group Database', we make sure those tests are not going to
be run before a database is actually setup.

Change-Id: I6ef256e4c247ceb0a344a963dd3cb67b018e586f

11 years agoWe need this 'AfterFinalPageOutput' hook for the STTLanguage extension.
Daniel Werner [Wed, 4 Jul 2012 21:23:56 +0000 (23:23 +0200)]
We need this 'AfterFinalPageOutput' hook for the STTLanguage extension.

Change-Id: I1f131e87324cb7a62355dc296f0b4d411a9a0800

11 years agoImprove names of factory methods in ORMTable. Now its clear that they create rows...
jeroendedauw [Fri, 29 Jun 2012 18:56:44 +0000 (20:56 +0200)]
Improve names of factory methods in ORMTable. Now its clear that they create rows and not tables

Change-Id: Ia83c7c81f4ddd6d3304273094553c31c67fe85c8

11 years agoMerge branch 'Wikidata' of ssh://review/mediawiki/core into Wikidata
jeroendedauw [Wed, 27 Jun 2012 14:18:18 +0000 (16:18 +0200)]
Merge branch 'Wikidata' of ssh://review/mediawiki/core into Wikidata

11 years agoAdd missing entry in autoloader for abstract test base class
jeroendedauw [Wed, 27 Jun 2012 12:26:05 +0000 (14:26 +0200)]
Add missing entry in autoloader for abstract test base class

Change-Id: I5a151496f2e81c029c48882125d3fe9493eb62ea

11 years agoCall new Content::prepareSave from WikiPage::doEditContent.
daniel [Wed, 27 Jun 2012 07:42:49 +0000 (09:42 +0200)]
Call new Content::prepareSave from WikiPage::doEditContent.

Content::prepareSave() is called  by WikiPage::doEditContent() inside the
transaction bracket for saving the new content, but before anything is actually
saved. This allows the content to first be normalized and checked against the
current database content; it also allows for some data to be written to the
database up front.

Change-Id: I78946ea5ec34dce08068692e2d77a8a0b7c11777

12 years agoremove test for obsolete getModelName function
daniel [Tue, 26 Jun 2012 14:38:13 +0000 (16:38 +0200)]
remove test for obsolete getModelName function

Change-Id: Ie69e28b9e0b7f40f5814818b91e2660ed0fea423

12 years agodetermine getPageLanguage via ContentHandler
daniel [Tue, 26 Jun 2012 14:37:42 +0000 (16:37 +0200)]
determine getPageLanguage via ContentHandler

Change-Id: I73760d4b4412aef416ee3b55d85e9fa257703063

12 years ago[bug 37746] string ids for content model and format.
daniel [Mon, 25 Jun 2012 21:30:51 +0000 (23:30 +0200)]
[bug 37746] string ids for content model and format.

The content model is stored as a varbinary(32), the format
as varbinary(64).

If the standard model resp. format is used, null is written
to the database instead of the actual id, saving space.

Change-Id: I32659b49a9ad3cb8ecae9019562cff7de42b65f9

12 years agomake ApiEditPage aware of content model and format.
daniel [Mon, 25 Jun 2012 14:09:08 +0000 (16:09 +0200)]
make ApiEditPage aware of content model and format.

Change-Id: I2ec9a8b38b10eecf47a51855ae8010a91c8acc90

12 years agoallow getParserOutput to be overwritten in DifferenceEngine
daniel [Mon, 25 Jun 2012 11:44:32 +0000 (13:44 +0200)]
allow getParserOutput to be overwritten in DifferenceEngine

Change-Id: I66fbd42c2ada05d5891f2738139b80c0090ecb1b

12 years agomerged master
daniel [Mon, 25 Jun 2012 11:43:00 +0000 (13:43 +0200)]
merged master

Change-Id: I0323bdbc035962a6ac8f9473df8a6b72acf82b4c

12 years agomerged master
daniel [Mon, 25 Jun 2012 11:39:29 +0000 (13:39 +0200)]
merged master

Change-Id: I0028e0ae01c7d025e60691cb4ad9d04869b9778c

12 years agoMerge "Bug 26911 - cli install doesn't ask for a password"
Demon [Mon, 25 Jun 2012 11:03:27 +0000 (11:03 +0000)]
Merge "Bug 26911 - cli install doesn't ask for a password"

12 years agoLocalisation updates from http://translatewiki.net.
Translation updater bot [Sun, 24 Jun 2012 20:02:37 +0000 (20:02 +0000)]
Localisation updates from translatewiki.net.

Change-Id: I28724db80d166e3b814e695eff7dfe141985dc30

12 years agoLocalisation updates from http://translatewiki.net.
Translation updater bot [Sat, 23 Jun 2012 20:09:38 +0000 (20:09 +0000)]
Localisation updates from translatewiki.net.

Change-Id: I433613595aeda3fbb50b62563fa6265515544b8c

12 years agoMerge "Remove adittional type hinting stuff because PHP will die if its there >_>"
Aaron Schulz [Sat, 23 Jun 2012 19:39:23 +0000 (19:39 +0000)]
Merge "Remove adittional type hinting stuff because PHP will die if its there >_>"

12 years agoMerge "Use canonical parser option for linkupdate in api purge"
Aaron Schulz [Sat, 23 Jun 2012 19:32:03 +0000 (19:32 +0000)]
Merge "Use canonical parser option for linkupdate in api purge"

12 years agoMerge "Add missing __METHOD__ to select in LocalRepo"
Aaron Schulz [Sat, 23 Jun 2012 19:25:32 +0000 (19:25 +0000)]
Merge "Add missing __METHOD__ to select in LocalRepo"

12 years agoMerge "(follow-up) Fix "file not found" error in mediawiki.language."
Nikerabbit [Sat, 23 Jun 2012 18:45:39 +0000 (18:45 +0000)]
Merge "(follow-up) Fix "file not found" error in mediawiki.language."

12 years agoWikiPage::preSaveTransform() was deprecated in r103228 (018d885f)
Platonides [Sat, 23 Jun 2012 18:28:51 +0000 (20:28 +0200)]
WikiPage::preSaveTransform() was deprecated in r103228 (018d885f)

Hide the warning on the tests and add tests for the Parser method.

Change-Id: I939bf59206da1dd45e33db2251e92d9792a0a767

12 years agoBack out unreviewed commit 17d23282dd6d8b1bf6b1b80f97cf02265cbec59d
Krinkle [Sat, 23 Jun 2012 08:56:31 +0000 (08:56 +0000)]
Back out unreviewed commit 17d23282dd6d8b1bf6b1b80f97cf02265cbec59d

Change-Id: I8911140f7fe14105b6debb14686d87613b84a1ce

12 years ago(bug 37708) mw.Uri.clone() should make a deep copy.
Trevor Parscal [Fri, 22 Jun 2012 18:39:10 +0000 (11:39 -0700)]
(bug 37708) mw.Uri.clone() should make a deep copy.

Copies query properties (or any other object or array property) over with a deep copy by value.

Change-Id: I1c5644409c089e0a864292b8bd5a757ac31daa89

12 years agoBug 26911 - cli install doesn't ask for a password
Mark A. Hershberger [Fri, 22 Jun 2012 22:05:24 +0000 (18:05 -0400)]
Bug 26911 - cli install doesn't ask for a password

Make the password parameter mandatory and change the help message.

Change-Id: Ibea29858be70a5188d167b9c1267b2db2564a96b

12 years agoAdd missing __METHOD__ to select in LocalRepo
umherirrender [Fri, 22 Jun 2012 22:40:20 +0000 (00:40 +0200)]
Add missing __METHOD__ to select in LocalRepo

Change-Id: Ice6d05227ab0149daa29a00f9441f5628618330c

12 years agoUse canonical parser option for linkupdate in api purge
umherirrender [Fri, 22 Jun 2012 22:25:33 +0000 (00:25 +0200)]
Use canonical parser option for linkupdate in api purge

This patch makes sure, that the links table updated against the
content language. This also enabled the limit report, which than
is also stored in the parser cache along with the html.

Change-Id: I2a0b09d7250813809f1b2a8cba3e4f53a6686002

12 years agoMerge "Moved JobQueue.php file to Job.php"
Brion VIBBER [Fri, 22 Jun 2012 22:20:07 +0000 (22:20 +0000)]
Merge "Moved JobQueue.php file to Job.php"

12 years agoMoved JobQueue.php file to Job.php
Aaron [Fri, 22 Jun 2012 22:15:21 +0000 (15:15 -0700)]
Moved JobQueue.php file to Job.php

Change-Id: I0c2fd3e4095a61db96b7165d1f9bf79fff51ea72

12 years agoMerge "API: Reset token cache on login, so API tests work"
Catrope [Fri, 22 Jun 2012 21:39:47 +0000 (21:39 +0000)]
Merge "API: Reset token cache on login, so API tests work"

12 years agoMerge "Make session persist between calls to doApiRequest"
Catrope [Fri, 22 Jun 2012 21:39:40 +0000 (21:39 +0000)]
Merge "Make session persist between calls to doApiRequest"

12 years agoMerge "Fix session handling in API test cases."
Catrope [Fri, 22 Jun 2012 21:35:48 +0000 (21:35 +0000)]
Merge "Fix session handling in API test cases."

12 years agoAPI: Reset token cache on login, so API tests work
daniel [Fri, 22 Jun 2012 20:37:26 +0000 (22:37 +0200)]
API: Reset token cache on login, so API tests work

Previously, logging in several times during a phpunit run would change the
session token, but keep the edit token, leasing to "bad token" failures for
all but the first login.

Change-Id: Iad49c990c5661d55cd907b8441addb74eb0ef694

12 years agoMake session persist between calls to doApiRequest
daniel [Fri, 22 Jun 2012 20:42:42 +0000 (22:42 +0200)]
Make session persist between calls to doApiRequest

Make sure the global session data in $wgRequest is used for doApiRequest
per default, and return it's content among with the request's results.

Previously, an empty session was used per default, and the local context's
session data would get out of sync with $wgRequest.

This change allows for the following assumptions to hold in test cases:

* within the same function, changes to the session made by one api call
  will be visible to subsequent api calls.

* the session data returned by doApiRequest is the actual status of the
  session as manipulated by the api call. This session data can be passed
  to subsequent api calls.

Note that the session data is still reset for every call to a test
function.

Change-Id: Ia20cf0ccfcdca736dd5da3444b14fbdd1c5def46

12 years ago(follow-up) Fix "file not found" error in mediawiki.language.
Timo Tijhof [Fri, 22 Jun 2012 20:23:10 +0000 (22:23 +0200)]
(follow-up) Fix "file not found" error in mediawiki.language.

* Follows-up f47dfe9939f7929f1e3fd1c501539cbd0d12373f, which forgot
  to remove the deleted files from the module definition as well.

exception 'MWException' with message 'ResourceLoaderFileModule::readScriptFiles: script file not found: "~/Development/mediawiki/core/resources/mediawiki.language/languages/nl.js"' in ~/Development/mediawiki/core/includes/resourceloader/ResourceLoaderFileModule.php:564
Stack trace:

Change-Id: Ib40d09071ba315da6b17fc94cca5746ed4c26342

12 years agoMerge "Switching to clearer pref label for Enhanced ChangesList"
Siebrand [Fri, 22 Jun 2012 19:39:25 +0000 (19:39 +0000)]
Merge "Switching to clearer pref label for Enhanced ChangesList"

12 years agoLocalisation updates from http://translatewiki.net.
Translation updater bot [Fri, 22 Jun 2012 18:04:53 +0000 (18:04 +0000)]
Localisation updates from translatewiki.net.

Change-Id: Ie53670c8253402108ac8daaef939d4a1bd7fe5f0

12 years agoSwitching to clearer pref label for Enhanced ChangesList
Kaldari [Wed, 6 Jun 2012 07:11:01 +0000 (00:11 -0700)]
Switching to clearer pref label for Enhanced ChangesList

It's more significant that this pref affects watchlists than
the recent changes page, but right now it doesn't even mention that
it affects the watchlist at all.

Change-Id: I2fb05f74683ac3c88689a445d8b511c9358b3cf3

12 years agoMerge "(bug 36819) Lowercase be,csb,cu,dsb,hsb,rue,sgs,szl"
MaxSem [Fri, 22 Jun 2012 15:35:48 +0000 (15:35 +0000)]
Merge "(bug 36819) Lowercase be,csb,cu,dsb,hsb,rue,sgs,szl"

12 years agoMerge "Add passing ''italic'''s case to 'Unclosed and unmatched quotes' test"
Nikerabbit [Fri, 22 Jun 2012 12:58:57 +0000 (12:58 +0000)]
Merge "Add passing ''italic'''s case to 'Unclosed and unmatched quotes' test"

12 years agoMerge "Prefer console.error over console.log for exception logging"
Nikerabbit [Fri, 22 Jun 2012 12:41:06 +0000 (12:41 +0000)]
Merge "Prefer console.error over console.log for exception logging"

12 years agoMerge "Fix INSERT options for PostgreSQL for INSERT+SELECT"
Hashar [Fri, 22 Jun 2012 12:00:34 +0000 (12:00 +0000)]
Merge "Fix INSERT options for PostgreSQL for INSERT+SELECT"

12 years agoMerge "CSSMin: Clean up $remote trailing slash fix"
Hashar [Fri, 22 Jun 2012 11:58:30 +0000 (11:58 +0000)]
Merge "CSSMin: Clean up $remote trailing slash fix"

12 years ago(bug 23427) PAGEID magic word
Waldir Pimenta [Sat, 2 Jun 2012 16:58:31 +0000 (18:58 +0200)]
(bug 23427) PAGEID magic word

Please note on preview of a new page, this magic word will return 0 so
we have to set the vary-revision flag.

Change-Id: I11d42ca773ad84b73cc84f2c7dd2d09f1982d97a

12 years agoMerge "(bug 260) Handle <pre> overflow automatically with a scroll bar"
Timo Tijhof [Fri, 22 Jun 2012 03:40:51 +0000 (03:40 +0000)]
Merge "(bug 260) Handle <pre> overflow automatically with a scroll bar"

12 years ago(bug 260) Handle <pre> overflow automatically with a scroll bar
Timo Tijhof [Fri, 22 Jun 2012 03:33:49 +0000 (05:33 +0200)]
(bug 260) Handle <pre> overflow automatically with a scroll bar

And it took only 8 years!

* Ref:
 - bug 260
 - bug 414
 - bug 22060

Change-Id: I2e0494603af9e3a8351a8c61e9b814f0093e422b

12 years ago(bug 36819) Lowercase be,csb,cu,dsb,hsb,rue,sgs,szl
saper [Thu, 21 Jun 2012 22:42:47 +0000 (00:42 +0200)]
(bug 36819) Lowercase be,csb,cu,dsb,hsb,rue,sgs,szl

Follow up to gerrit change 7306:

https://gerrit.wikimedia.org/r/#/c/7306/

Lowercase some Central and Eastern European language
names (mostly Slavic and Samogitian, using lithuanian
rule).

'be-tarask' => "беларуская (тарашкевіца)", # Belarusian in Taraskievica orthography
  (as well as be-x-old)
'csb' => 'kaszëbsczi', # Cassubian
'cu' => 'словѣ́ньскъ / ⰔⰎⰑⰂⰡⰐⰠⰔⰍⰟ', # Old Church Slavonic (ancient language)
'dsb' => 'dolnoserbski', # Lower Sorbian
'hsb' => 'hornjoserbsce', # Upper Sorbian
'rue' => 'русиньскый', # Rusyn
'sgs' => 'žemaitėška', # Samogitian
'szl' => 'ślůnski', # Silesian

Change-Id: Ic0420299c9010f62d2a8fbfd6cb1d65c6b4b8413

12 years agoFix undefined property domain in AuthPlugin
Reedy [Thu, 21 Jun 2012 21:56:12 +0000 (22:56 +0100)]
Fix undefined property domain in AuthPlugin

[21-Jun-2012 20:35:17] PHP Notice:  Undefined property: AuthPlugin::$domain in /www/w/includes/AuthPlugin.php on line 92

Change-Id: I0c470b41881e0fd12d9615f7ac258feeff1a52e4

12 years agoFix session handling in API test cases.
daniel [Thu, 21 Jun 2012 20:25:37 +0000 (22:25 +0200)]
Fix session handling in API test cases.

* Use the API module's own context to check edit tokens.
* Use the global session if none is provided to doApiRequest.
* Fix ApiFlockTest to not pass an empty session, so the tokens from
  the global request can be used.

Change-Id: I2bff2390f43beb984b1b451bcf4e41271b2f054f

12 years agoLocalisation updates from http://translatewiki.net.
Translation updater bot [Thu, 21 Jun 2012 20:22:17 +0000 (20:22 +0000)]
Localisation updates from translatewiki.net.

Change-Id: If2ab7747d22cfc38a065c16697eaf5ace09ad400

12 years ago[LockManager] Added a memcached lock manager class.
Aaron [Wed, 20 Jun 2012 21:09:22 +0000 (14:09 -0700)]
[LockManager] Added a memcached lock manager class.

Change-Id: Ie99a7f1335bb5cceb0cb1c33a40094b3a22101ea

12 years agoAlias mw.action.watch.ajax to mw.page.watch.ajax
Catrope [Thu, 21 Jun 2012 18:23:50 +0000 (11:23 -0700)]
Alias mw.action.watch.ajax to mw.page.watch.ajax

This module was recently renamed, and we'll need the alias for caching
reasons

Change-Id: Ic0df459dfc1cca58f4e01325375c20c46091c89b

12 years agoFollowup to 2e089a4e5: rename watch to watchpage
Catrope [Thu, 21 Jun 2012 17:45:15 +0000 (10:45 -0700)]
Followup to 2e089a4e5: rename watch to watchpage

There is a jQuery bug causing events named 'watch' to break in Firefox

Change-Id: Ie44066bcb6fd84ee77551efa1ca40f5543126d2c

12 years agoimproved failure message for timing-dependant test case
daniel [Thu, 21 Jun 2012 17:11:39 +0000 (19:11 +0200)]
improved failure message for timing-dependant test case

Change-Id: If3bcc4fb55aea6713e9082e249ddbae4ccd26ffc

12 years agocheck for </revision> only once. fix parameter list.
daniel [Thu, 21 Jun 2012 17:11:08 +0000 (19:11 +0200)]
check for </revision> only once. fix parameter list.

Change-Id: Ib88d094efa63baf289c1856ca3cd97a20de9ceb9

12 years agoremember to bump schema version and update xsd
daniel [Thu, 21 Jun 2012 17:10:13 +0000 (19:10 +0200)]
remember to bump schema version and update xsd

Change-Id: I91666d78a8efae0186b0a181811dff1fa899070e

12 years agoSimplifying domain getting/setting
Ryan Lane [Thu, 21 Jun 2012 12:59:01 +0000 (14:59 +0200)]
Simplifying domain getting/setting

Adding a function to AuthPlugin for getting the user's domain. This allows the extension to determine how the user's domain is get and set, rather than core.

Change-Id: Ib2414bd55dfde67f7caf6439680fa88d9266e991

12 years agoMerge "Bug 37705 - ucfirst for sidebar interlanguage links"
Siebrand [Thu, 21 Jun 2012 12:22:20 +0000 (12:22 +0000)]
Merge "Bug 37705 - ucfirst for sidebar interlanguage links"

12 years agoBug 37705 - ucfirst for sidebar interlanguage links
robin [Mon, 18 Jun 2012 21:23:59 +0000 (23:23 +0200)]
Bug 37705 - ucfirst for sidebar interlanguage links

Change-Id: I623cf070fdc62c9394a06d4830dc4faccfebcfbe

12 years agoPrefer console.error over console.log for exception logging
Timo Tijhof [Wed, 6 Jun 2012 18:04:03 +0000 (20:04 +0200)]
Prefer console.error over console.log for exception logging

Follows-up:
* r112453: 268e016f08c5de6a68c25abf182d0115a6f131d5
* r88392 : bdac16978c6827bb5d8709071ee8afb99707ec3e

This way it works in both the Chrome Dev Tools and Firebug in Firefox.

Change-Id: If8b3c2747882c1e21e413f062e4c89c34144c64b

12 years agoMerge "[LockManager] Factored QuorumLockManager class out of LSLockManager."
Hashar [Wed, 20 Jun 2012 20:38:37 +0000 (20:38 +0000)]
Merge "[LockManager] Factored QuorumLockManager class out of LSLockManager."

12 years agoMerge "qLocalisation updates from http://translatewiki.net."
Translation updater bot [Wed, 20 Jun 2012 20:18:38 +0000 (20:18 +0000)]
Merge "qLocalisation updates from translatewiki.net."

12 years agoqLocalisation updates from http://translatewiki.net.
Translation updater bot [Wed, 20 Jun 2012 20:16:43 +0000 (20:16 +0000)]
qLocalisation updates from translatewiki.net.

Change-Id: Icffbf1ead617dee16b8a720427c8f0cd65168ab3

12 years agoMerge "Move action.watch to a more suitable place and expose updateWatchLink method...
Trevor Parscal [Wed, 20 Jun 2012 20:06:12 +0000 (20:06 +0000)]
Merge "Move action.watch to a more suitable place and expose updateWatchLink method in mw.page.watch.  Update method to toggle watch, unwatch list item id attribute. Patchset 2- Expose method with less code duplication, restore comments, cleanup whitespace. Patchset 3-5 Whitespace cleanup Patchset 6 - Trigger a watch event on the updated li Patchset 7 - Only trigger watch event if not updating state, announce opposite of icon action, to properly indicate action taken. Patchset 8 - Cleanup spacing and comments issues, change event namespace. Patchset 9 - actually add the change Change-Id: I591f9f847db391c5d1477dc2ed41de54ec266261"

12 years agoMove action.watch to a more suitable place and expose updateWatchLink
Rob Moen [Tue, 19 Jun 2012 23:00:57 +0000 (16:00 -0700)]
Move action.watch to a more suitable place and expose updateWatchLink
method in mw.page.watch.  Update method to toggle watch, unwatch
list item id attribute.
Patchset 2- Expose method with less code duplication, restore
comments, cleanup whitespace.
Patchset 3-5 Whitespace cleanup
Patchset 6 - Trigger a watch event on the updated li
Patchset 7 - Only trigger watch event if not updating
state, announce opposite of icon action, to properly
indicate action taken.
Patchset 8 - Cleanup spacing and comments issues,
change event namespace.
Patchset 9 - actually add the change
Change-Id: I591f9f847db391c5d1477dc2ed41de54ec266261

12 years agoMerge "Removed half-assed $wgDBtransactions global."
Hashar [Wed, 20 Jun 2012 18:12:13 +0000 (18:12 +0000)]
Merge "Removed half-assed $wgDBtransactions global."

12 years agoRemoved half-assed $wgDBtransactions global.
Aaron [Tue, 19 Jun 2012 22:01:38 +0000 (15:01 -0700)]
Removed half-assed $wgDBtransactions global.

Change-Id: I5211ec50622b0a40bf4756b7fe735dc669f928e7

12 years agofix typo in error message
daniel [Wed, 20 Jun 2012 17:14:08 +0000 (19:14 +0200)]
fix typo in error message

Change-Id: Idb2e799e383a51dbad1a5b57f37b6bf24d142b4d

12 years agofix php error
daniel [Wed, 20 Jun 2012 17:13:48 +0000 (19:13 +0200)]
fix php error

Change-Id: I3137875c21d7ccff73c4cad2e7eb2e11b714de0b

12 years agomerged master
daniel [Wed, 20 Jun 2012 17:13:16 +0000 (19:13 +0200)]
merged master

Change-Id: I6cf08c09c7d9b38ecce0b2bbed61431939edd7d4

12 years agoRemove adittional type hinting stuff because PHP will die if its there >_>
jeroendedauw [Wed, 20 Jun 2012 16:12:43 +0000 (18:12 +0200)]
Remove adittional type hinting stuff because PHP will die if its there >_>

I CAN HAZ GENERICS PLZ!

Change-Id: I28e8f024feb346cce1107af3035fc97b870ef6af

12 years agoCSSMin: Clean up $remote trailing slash fix
Timo Tijhof [Wed, 20 Jun 2012 11:05:03 +0000 (13:05 +0200)]
CSSMin: Clean up $remote trailing slash fix

* No need to strip them from everywhere all over. This bug is only
  caused by the presence of a trailing slash on $remote.

* To make sure everything still works before and after I added
  unit tests for CSSMin in Ic9195614acfd, making this dependent
  on that change.

Change-Id: Ia82048a328a056117afe0d653fe22f5429b21f5a

12 years agoMerge "PHP test suite for CSSMin"
Hashar [Wed, 20 Jun 2012 12:28:59 +0000 (12:28 +0000)]
Merge "PHP test suite for CSSMin"

12 years agoPHP test suite for CSSMin
Timo Tijhof [Wed, 20 Jun 2012 03:13:52 +0000 (05:13 +0200)]
PHP test suite for CSSMin

Change-Id: Ic9195614acfd616ccdff57cfc666aa4dfa71fb96

12 years agoMerge "(bug 37458) permission errors running BaseDumpTest on Windows"
Hashar [Wed, 20 Jun 2012 09:16:16 +0000 (09:16 +0000)]
Merge "(bug 37458) permission errors running BaseDumpTest on Windows"

12 years ago(bug 37458) permission errors running BaseDumpTest on Windows
Tobias Gritschacher [Mon, 18 Jun 2012 13:11:04 +0000 (15:11 +0200)]
(bug 37458) permission errors running BaseDumpTest on Windows

Change-Id: I58264c5f516f8dcb124d753b43a80b0875b0e974

12 years agoMerge "(bug 35727) mw.Api ajax() should put token parameter last."
Krinkle [Tue, 19 Jun 2012 22:47:53 +0000 (22:47 +0000)]
Merge "(bug 35727) mw.Api ajax() should put token parameter last."

12 years agoMerge "(bug 37301) add sizediff to list=usercontribs"
Aaron Schulz [Tue, 19 Jun 2012 21:31:19 +0000 (21:31 +0000)]
Merge "(bug 37301) add sizediff to list=usercontribs"

12 years agoMerge "Can't use return value of void functions"
Aaron Schulz [Tue, 19 Jun 2012 21:10:12 +0000 (21:10 +0000)]
Merge "Can't use return value of void functions"

12 years agoMerge "Bump release notes to say jQuery UI 1.8.21 (seems I forgot to do this in the...
Aaron Schulz [Tue, 19 Jun 2012 21:09:04 +0000 (21:09 +0000)]
Merge "Bump release notes to say jQuery UI 1.8.21 (seems I forgot to do this in the commits...)"

12 years agoMerge "Kill RELEASE-NOTES-1.19 from core. Not needed anymore"
Aaron Schulz [Tue, 19 Jun 2012 21:06:27 +0000 (21:06 +0000)]
Merge "Kill RELEASE-NOTES-1.19 from core. Not needed anymore"

12 years ago(bug 35727) mw.Api ajax() should put token parameter last.
Brad Jorsch [Sun, 17 Jun 2012 04:11:32 +0000 (00:11 -0400)]
(bug 35727) mw.Api ajax() should put token parameter last.

Patch from Russell Blau.

As recommended in [[mw:API:Edit#Token]], the "token" parameter in
a request should always be passed at the end of the query string.
This is a safety measure in case transmission of the HTML request to
the server is interrupted; then the server will not process the
incomplete request because there will be no (complete) token.
(Conversely, if the "text=" parameter were last, the server would have
no way of knowing whether the complete text had been received.)
Presumably the same thing is necessary for action=email, since the
request may include text of arbitrary length.

Change-Id: Id267dd628eb93eb06191c55eb386b1893f499554

12 years ago[LockManager] Factored QuorumLockManager class out of LSLockManager.
Aaron [Tue, 19 Jun 2012 18:39:53 +0000 (11:39 -0700)]
[LockManager] Factored QuorumLockManager class out of LSLockManager.

Change-Id: I4031085faef4a1a7ce49dbeeb0b3ddf94d41132c

12 years agoMerge "Localisation updates from http://translatewiki.net."
Translation updater bot [Tue, 19 Jun 2012 19:38:03 +0000 (19:38 +0000)]
Merge "Localisation updates from translatewiki.net."

12 years agoMerge "Put skin classes in the Autoloader"
Aaron Schulz [Tue, 19 Jun 2012 19:33:53 +0000 (19:33 +0000)]
Merge "Put skin classes in the Autoloader"

12 years agoLocalisation updates from http://translatewiki.net.
Translation updater bot [Tue, 19 Jun 2012 19:05:12 +0000 (19:05 +0000)]
Localisation updates from translatewiki.net.

Change-Id: Ic387b6f35cf3fb1931bb3d8c52efee17b91cf1be

12 years agosupport symbolic name for content models
daniel [Tue, 19 Jun 2012 12:45:25 +0000 (14:45 +0200)]
support symbolic name for content models

Change-Id: I4eaed3db7fb10069f73d84514abd2f6957019153

12 years agoMerge "undo misguided changes to phpunit" into Wikidata
daniel [Tue, 19 Jun 2012 12:32:10 +0000 (12:32 +0000)]
Merge "undo misguided changes to phpunit" into Wikidata

12 years agoundo misguided changes to phpunit
daniel [Tue, 19 Jun 2012 12:29:25 +0000 (14:29 +0200)]
undo misguided changes to phpunit

Change-Id: I14f72e3ea6885cd5e0fbdfe6aca42d39076274ec

12 years agoFix indenting errors introduced in Wikidata branch
Tim Starling [Tue, 19 Jun 2012 01:28:05 +0000 (11:28 +1000)]
Fix indenting errors introduced in Wikidata branch

Change-Id: I487a0966a26359d4a6769331a6e2ee356eeb41db

12 years agoFix comments added in change 10088
Liangent [Tue, 5 Jun 2012 23:30:49 +0000 (07:30 +0800)]
Fix comments added in change 10088

I found my comments in change 10088 is inadequate because we don't
have any known squid URLs in Title::getSquidURLs() and we may never
want to have... There's no hook there so extensions are unable to
add any squid URLs for them (maybe we want one someday? but new
extensions shouldn't be using the UnknownAction hook).

Change-Id: I44ba376f92776ec6bb32f91beb06f11ebd086fb4

12 years agoMerge "For consistency of the interface, don't do expensive checks on page view."
Aaron Schulz [Tue, 19 Jun 2012 06:53:07 +0000 (06:53 +0000)]
Merge "For consistency of the interface, don't do expensive checks on page view."

12 years agoSkinTemplate: Minor clean up
Timo Tijhof [Mon, 18 Jun 2012 23:26:40 +0000 (01:26 +0200)]
SkinTemplate: Minor clean up

* Better variable names ($wgContLang is object, $userLang was a string
  and $lang the object. Made $userLang the object and $userLangCode
  the string.

* Removed trailing whitespace.

* Spacing (not all just where it fit better in the context, some
  isset($) to isset( $ ). and a few `if()` to `if ()` since most
  in this file are like that.

* Some redundant magic quote usage to single quotes.

* Weird structure in getPersonalTools():
  Instead of accessing the same deep array property over and over
  again to add something to the newly create array (e.g.
  $foo[] = array(); and then $foo[0] = $bar;) simply creating it
  as a literal at once.

Change-Id: I861ae1d558f324f61c79089dcd3bff52dd27e0aa

12 years agoLocalisation updates from http://translatewiki.net.
Translation updater bot [Mon, 18 Jun 2012 19:06:51 +0000 (19:06 +0000)]
Localisation updates from translatewiki.net.

Change-Id: Ica921689fbb2051272010d77198e5932421fa9e9

12 years agoFix INSERT options for PostgreSQL for INSERT+SELECT
saper [Mon, 18 Jun 2012 18:39:08 +0000 (20:39 +0200)]
Fix INSERT options for PostgreSQL for INSERT+SELECT

Fix handling of $insertOptions in
DatabasePostgres::insertSelect

Looks like this change:

https://gerrit.wikimedia.org/r/#/c/3962/
(or 646a9490f74f3841803299a4e4d2d5677c5f1bba)

mishandled badly INSERT IGNORE (instead of
silently broken support for it it introduced
PHP error).

Looks like we have no unit test to cover
the use of Database::insertSelect in the code.

Change-Id: I4f7d8c9bd9e413d8ffa23c1d0c0628a25c28d45c

12 years agoMerge "ensure unique revision id in backupTextPassTest"
Aaron Schulz [Mon, 18 Jun 2012 17:05:21 +0000 (17:05 +0000)]
Merge "ensure unique revision id in backupTextPassTest"

12 years agoMerge "fixed bug 37458: permission errors running BaseDumpTest on Windows" into Wikidata
MaxSem [Mon, 18 Jun 2012 16:26:30 +0000 (16:26 +0000)]
Merge "fixed bug 37458: permission errors running BaseDumpTest on Windows" into Wikidata

12 years agofixed bug 37458: permission errors running BaseDumpTest on Windows
Tobias Gritschacher [Mon, 18 Jun 2012 13:11:04 +0000 (15:11 +0200)]
fixed bug 37458: permission errors running BaseDumpTest on Windows

patch set 2: removed trailing whitespace;

Change-Id: I58264c5f516f8dcb124d753b43a80b0875b0e974