lhc/web/wiklou.git
13 years agoRemove a dead patch of Skin code that was migrated completely into SkinLegacy and...
Daniel Friesen [Mon, 4 Apr 2011 00:42:52 +0000 (00:42 +0000)]
Remove a dead patch of Skin code that was migrated completely into SkinLegacy and SkinTemplate already.

13 years agoInstead of creating an OutputPage and then setting a context start initializing Outpu...
Daniel Friesen [Mon, 4 Apr 2011 00:37:42 +0000 (00:37 +0000)]
Instead of creating an OutputPage and then setting a context start initializing OutputPages 'with' a context and send depreciated calls to extensions directly creating OutputPage instances.
Now that we've taken care of the mess of mTitle inside OutputPage and Skin and made RequestContext track Skin instead of $wgUser we don't need the hack in SpecialPage anymore.

13 years agoUpdate index.php and Wiki.php to make better use of the context.
Daniel Friesen [Mon, 4 Apr 2011 00:18:33 +0000 (00:18 +0000)]
Update index.php and Wiki.php to make better use of the context.

13 years agoFollowup r85278, remove duplication of userlang code.
Daniel Friesen [Sun, 3 Apr 2011 23:56:15 +0000 (23:56 +0000)]
Followup r85278, remove duplication of userlang code.

13 years agoRemove $this->context->output->setTitle( $this->context->title ); calls from Wiki...
Daniel Friesen [Sun, 3 Apr 2011 23:47:50 +0000 (23:47 +0000)]
Remove $this->context->output->setTitle( $this->context->title ); calls from Wiki.php, this are unnecessary, OutputPage no longer keeps track of it's own desynchronized mTitle.

13 years agoFix use of mUser noted by c15657 on r85250.
Daniel Friesen [Sun, 3 Apr 2011 23:38:44 +0000 (23:38 +0000)]
Fix use of mUser noted by c15657 on r85250.

13 years agoAdd a getSkin that returns a dummy linker for BC with extensions still abusing it...
Daniel Friesen [Sun, 3 Apr 2011 23:32:52 +0000 (23:32 +0000)]
Add a getSkin that returns a dummy linker for BC with extensions still abusing it to access the linker.

13 years agoClean out some globals from SpecialPage.php
Happy-melon [Sun, 3 Apr 2011 23:08:16 +0000 (23:08 +0000)]
Clean out some globals from SpecialPage.php

13 years agoImplement magic accessors for RequestContext variables: you can now just call $contex...
Happy-melon [Sun, 3 Apr 2011 22:09:35 +0000 (22:09 +0000)]
Implement magic accessors for RequestContext variables: you can now just call $context->request->stuff(), and that is internally mapped to the get accessor.  Rename the private variables to the old $mName syntax: I know that that's "discouraged in new code", but in this case it stops over-clever IDEs highlighting the magic accesses as potential visibility errors and sticking big error tags on them.

13 years agoFollow-up r85278, r85240:
Happy-melon [Sun, 3 Apr 2011 21:32:50 +0000 (21:32 +0000)]
Follow-up r85278, r85240:

* Internalise $title in MediaWiki base class
* Fix access fatal in SpecialPage by getting the context from the MediaWiki base class rather than the OutputPage
* Fix a couple of typos in RequestContext which would have thrown errors/fatals if anyone had ever called them.

13 years agoExpand wfShowMaxLagError() into index.php. It was only being called from here and...
Happy-melon [Sun, 3 Apr 2011 20:43:50 +0000 (20:43 +0000)]
Expand wfShowMaxLagError() into index.php.  It was only being called from here and it's pretty non-portable.  Doing so reveals that it's safe to move the declaration of $mediaWiki below the maxlag test, which will fractionally improve performance in that instance (partly compensating for having to parse OutputPage as introduced in r85278).

13 years agoFollow-up to r85240:
Happy-melon [Sun, 3 Apr 2011 20:40:27 +0000 (20:40 +0000)]
Follow-up to r85240:

* Don't stub RequestContext.  The chances of us getting away without needing to access *any* of the six major globals is nil, and in the meantime it's screwing up strong function typing and throwing catchable fatals everywhere.

* Stop stubbing $wgOut.  The only path where we can avoid unstubbing it is if we immediately die due to maxlag overflow, and that's a) a pretty uncommon code path, and b) a DB issue which won't be affected by a tiny bit of extra apache load.  That allows us to do strong typing on function parameters with it, which is a Good Thing (TM).

Also make OutputPage::getContext() private; I'm not convinced that a context belongs here (it's *part of* the context, not a consumer of it), let's work through it a it more before we advertise its existence.

13 years agoRemoved useless definition of $wgOut
Alexandre Emsenhuber [Sun, 3 Apr 2011 19:49:50 +0000 (19:49 +0000)]
Removed useless definition of $wgOut

13 years agoStore the WebRequest and OutputPage in the MediaWiki class, don't pass the global...
Happy-melon [Sun, 3 Apr 2011 19:39:39 +0000 (19:39 +0000)]
Store the WebRequest and OutputPage in the MediaWiki class, don't pass the global variables in to each function separately.

13 years agoCleanup in Wiki.php and index.php:
Happy-melon [Sun, 3 Apr 2011 15:56:29 +0000 (15:56 +0000)]
Cleanup in Wiki.php and index.php:
* Add visibility to MediaWiki::*() methods.
* Refactor out MediaWiki::preliminaryChecks(), was actually just one preliminary check :D
* maxlag is a property of the database, not the wiki, so MediaWiki::checkMaxLag() doesn't belong.  Since it was only called in index.php I just expanded it there, it's only a trivial wrapper anyway.
* Run stylize.php over code.

13 years agoAutoLoader entry for r85247.
Happy-melon [Sun, 3 Apr 2011 14:59:58 +0000 (14:59 +0000)]
AutoLoader entry for r85247.

13 years agoFollowup r85250; Revert a static method back to use of $wgRequest... :/ damnit resour...
Daniel Friesen [Sun, 3 Apr 2011 12:55:48 +0000 (12:55 +0000)]
Followup r85250; Revert a static method back to use of $wgRequest... :/ damnit resourceloader...

13 years agoContinue with r85240; Move getSkin from User to RequestContext, do it without globals...
Daniel Friesen [Sun, 3 Apr 2011 12:46:36 +0000 (12:46 +0000)]
Continue with r85240; Move getSkin from User to RequestContext, do it without globals, strip out the non-functional $title related stuff, and update Skin to use a RequestContext.

13 years agoFollowup r85244; Fix a small issue with the case of a variable name.
Daniel Friesen [Sun, 3 Apr 2011 12:37:07 +0000 (12:37 +0000)]
Followup r85244; Fix a small issue with the case of a variable name.

13 years agoFollowup r85244; Define all methods as static, implement a DummyLinker to forward...
Daniel Friesen [Sun, 3 Apr 2011 12:04:04 +0000 (12:04 +0000)]
Followup r85244; Define all methods as static, implement a DummyLinker to forward calls for passing to hooks and finish off anything in the way.

13 years agoDrop connetion between Skin and Linker and turn Linker into a staticly usable class.
Daniel Friesen [Sun, 3 Apr 2011 11:44:11 +0000 (11:44 +0000)]
Drop connetion between Skin and Linker and turn Linker into a staticly usable class.

13 years agoFollowup r85229; Drop this unnecessary reference on the user from ChangesList::newFro...
Daniel Friesen [Sun, 3 Apr 2011 11:33:10 +0000 (11:33 +0000)]
Followup r85229; Drop this unnecessary reference on the user from ChangesList::newFromUser.

13 years agoFollowup r85240; Commit the additional file that was part of that change. ;) this...
Daniel Friesen [Sun, 3 Apr 2011 11:09:49 +0000 (11:09 +0000)]
Followup r85240; Commit the additional file that was part of that change. ;) this wouldn't have happened if we were using git... seriously!

13 years agoUpdate profiling.
Siebrand Mazeland [Sun, 3 Apr 2011 10:52:54 +0000 (10:52 +0000)]
Update profiling.

13 years agoImplement the RequestContext class. Some credit to IAlex, ;) other credit for me...
Daniel Friesen [Sun, 3 Apr 2011 10:41:14 +0000 (10:41 +0000)]
Implement the RequestContext class. Some credit to IAlex, ;) other credit for me and that plethora of bugs and hicoughs I had to deal with in impelenting it.
http://www.mediawiki.org/wiki/Requests_for_comment/Context_object (it's little different though)

13 years ago* Drop 5.1 compat code
Alexandre Emsenhuber [Sun, 3 Apr 2011 09:44:50 +0000 (09:44 +0000)]
* Drop 5.1 compat code
* Fix one more PHP version requirement

13 years agoFollowup r85228; Small fix for ()> syntax error that should have been ()->
Daniel Friesen [Sun, 3 Apr 2011 08:49:16 +0000 (08:49 +0000)]
Followup r85228; Small fix for ()> syntax error that should have been ()->

13 years agoFollow-up r85226, r85227: add @since annotations
Niklas Laxström [Sun, 3 Apr 2011 08:33:53 +0000 (08:33 +0000)]
Follow-up r85226, r85227: add @since annotations

13 years agoFollowup r85227; Back out changes related to avoiding calls to OutputPage from includ...
Daniel Friesen [Sun, 3 Apr 2011 06:26:58 +0000 (06:26 +0000)]
Followup r85227; Back out changes related to avoiding calls to OutputPage from includable special pages. After some re-examination we replace the OutputPage and OutputPage is coded in a way to avoid poluting global things with things like the use of header(); in set* calls, so setting things on OutputPage while in an includable special page just gets discarded.

13 years ago* Removed isset() checks - redundant given Parser::version
Aaron Schulz [Sun, 3 Apr 2011 05:53:07 +0000 (05:53 +0000)]
* Removed isset() checks - redundant given Parser::version
* For sanity in insertOn(), if the template/file version arrays are null, don't hit the DB - just assume they are empty
* Refactored mFlags handling in FlaggedRevision
* Use accessors for ParserOutput template/file versions
* Added OutputPage accessors for template/file versions
* Changed instance of NS_IMAGE -> NS_FILE

13 years agoFollowup r85227. Convert all IncludableSpecialPages to use context properly (they...
Daniel Friesen [Sun, 3 Apr 2011 05:46:42 +0000 (05:46 +0000)]
Followup r85227. Convert all IncludableSpecialPages to use context properly (they are the worse offenders), and fix some bugs related to inculudable special pages and their context.

13 years agoFollowup r85227, update 4 special pages to properly use the context.
Daniel Friesen [Sun, 3 Apr 2011 04:37:13 +0000 (04:37 +0000)]
Followup r85227, update 4 special pages to properly use the context.

13 years agoStart managing output and input context from special pages themselves instead of...
Daniel Friesen [Sun, 3 Apr 2011 04:36:02 +0000 (04:36 +0000)]
Start managing output and input context from special pages themselves instead of using globals. We already had a setContext, Special page implementations should be properly utalizing that data.

13 years agoStart better utalizing OutputPage as the focal point for things related to the output...
Daniel Friesen [Sun, 3 Apr 2011 03:59:47 +0000 (03:59 +0000)]
Start better utalizing OutputPage as the focal point for things related to the output of the page. Like getTitle use $out->get{User,Skin} instead of $wgUser and $wgUser->getSkin() for things where the user or skin is being used for output generation back to $out instead of using globals with bad structure.

13 years agoLocalization update for he.
Rotem Liss [Sat, 2 Apr 2011 20:52:28 +0000 (20:52 +0000)]
Localization update for he.

13 years agoMade index.php's profiling cosistent with other entry scripts
Alexandre Emsenhuber [Sat, 2 Apr 2011 18:59:47 +0000 (18:59 +0000)]
Made index.php's profiling cosistent with other entry scripts

13 years ago* Moved all <link> definitions in OutputPage::getHeadLinks() instead of having them...
Alexandre Emsenhuber [Sat, 2 Apr 2011 18:38:42 +0000 (18:38 +0000)]
* Moved all <link> definitions in OutputPage::getHeadLinks() instead of having them in a *lot* of different functions
* Also moved there generic <meta> and removed OutputPage::addDefaultMeta() with its $called static local variable which was breaking the output when generating multiple pages on the same request (rebuildFileCache.php, dumpHTML.php) since that function could only be executed completely once for all instances, and not once per instance
* Moved default module from OutputPage::output() to its own function and don't call it when executing a body only request, since it's useless in that case
* Call Skin::setMembers() from Skin::initPage() instead of Skin::outputPage()

13 years ago(bug 28348) Don't call wfTimestamp() twice really fast in recordUpload2() and expect...
Aaron Schulz [Sat, 2 Apr 2011 16:49:47 +0000 (16:49 +0000)]
(bug 28348) Don't call wfTimestamp() twice really fast in recordUpload2() and expect the values to be the same. Previously the file prop cache value for the upload timestamp could fall out of sync for a while due to this (like being off by one second).

13 years agofollow-up to r85193: missed one file
Jack Phoenix [Sat, 2 Apr 2011 14:53:02 +0000 (14:53 +0000)]
follow-up to r85193: missed one file

13 years agoImagePage.php: add missing braces + other code style tweaks
Jack Phoenix [Sat, 2 Apr 2011 14:50:31 +0000 (14:50 +0000)]
ImagePage.php: add missing braces + other code style tweaks

13 years agoGet the thumbmime from the handler instead of guessing it with UnregisteredLocalFile.
Bryan Tong Minh [Sat, 2 Apr 2011 14:49:12 +0000 (14:49 +0000)]
Get the thumbmime from the handler instead of guessing it with UnregisteredLocalFile.

13 years agomark some public functions as such
Jack Phoenix [Sat, 2 Apr 2011 14:48:22 +0000 (14:48 +0000)]
mark some public functions as such

13 years agoRespect $wgScriptExtension in SearchEngine::getOpenSearchTemplate() and SearchEngine...
Alexandre Emsenhuber [Sat, 2 Apr 2011 09:50:20 +0000 (09:50 +0000)]
Respect $wgScriptExtension in SearchEngine::getOpenSearchTemplate() and SearchEngine::getMWSuggestTemplate()

13 years agoRemoved deprecated Image class per documentation; no use in core or extensions
Alexandre Emsenhuber [Sat, 2 Apr 2011 09:34:22 +0000 (09:34 +0000)]
Removed deprecated Image class per documentation; no use in core or extensions

13 years agoRemoved archive(), deprecated and not used
Max Semenik [Sat, 2 Apr 2011 08:41:48 +0000 (08:41 +0000)]
Removed archive(), deprecated and not used

13 years agoFollowup r80398: fix overspecific css rules which broke
Niklas Laxström [Sat, 2 Apr 2011 08:22:52 +0000 (08:22 +0000)]
Followup r80398: fix overspecific css rules which broke

13 years agoCleaned up the mess of message text being passed instead of keys to wfMsg() and frien...
Max Semenik [Sat, 2 Apr 2011 07:34:07 +0000 (07:34 +0000)]
Cleaned up the mess of message text being passed instead of keys to wfMsg() and friends by CLI installer. No surprise we had to remove angle brackets from the resulting output

13 years agoFix Bug#24308 where, on some platforms the date_create() function fails when the...
Mark A. Hershberger [Sat, 2 Apr 2011 04:49:29 +0000 (04:49 +0000)]
Fix Bug#24308 where, on some platforms the date_create() function fails when the timezone isn't specified.

13 years agoRemove unused global, fix double defined global
Sam Reed [Sat, 2 Apr 2011 00:27:03 +0000 (00:27 +0000)]
Remove unused global, fix double defined global

13 years agoFix casing of SpecialListUsers
Sam Reed [Sat, 2 Apr 2011 00:26:40 +0000 (00:26 +0000)]
Fix casing of SpecialListUsers

13 years agoFollow-up r85025: fix the you're-trying-to-block-yourself-you-twit warning, and make...
Happy-melon [Fri, 1 Apr 2011 23:13:15 +0000 (23:13 +0000)]
Follow-up r85025: fix the you're-trying-to-block-yourself-you-twit warning, and make it an actual checkbox confirmation.  Also use said confirmation for reblocks, and HideUser (bug 18678).  Mark a static function from HTMLForm which is called from SpecialBlock as explicitly public.

13 years agoMemory stress test for UtfNormal issue re bug 28146
Brion Vibber [Fri, 1 Apr 2011 21:14:52 +0000 (21:14 +0000)]
Memory stress test for UtfNormal issue re bug 28146

This pulls the source texts used for the UtfNormalBench.php benchmarks, repeats them into much larger strings, and attempts to reproduce an out-of-memory error in the middle of UtfNormal::cleanUp():

$ php
Testing testdata/washington.txt (English text)...
     quickIsNFCVerify 1078.3ms   14,969,652 bytes/s (changed)
              cleanUp  992.1ms   16,270,594 bytes/s (no change)
Testing testdata/berlin.txt (German text)...
PHP Fatal error:  Allowed memory size of 136314880 bytes exhausted (tried to allocate 71 bytes) in /var/www/trunk/includes/normal/UtfNormal.php on line 285

Exact failure point may require adjustment depending on platform, etc.

13 years agoLocalisation updates for core and extension messages from translatewiki.net (2011...
Raimond Spekking [Fri, 1 Apr 2011 20:53:41 +0000 (20:53 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-04-01 20:38:00 UTC)

13 years agoAdded charset property to HTTP Content-Type fields when serving CSS and JavaScript...
Trevor Parscal [Fri, 1 Apr 2011 20:48:50 +0000 (20:48 +0000)]
Added charset property to HTTP Content-Type fields when serving CSS and JavaScript via ResourceLoader - resolves bug #28208.

13 years agoReword this message per IRC cabbage
Niklas Laxström [Fri, 1 Apr 2011 19:30:08 +0000 (19:30 +0000)]
Reword this message per IRC cabbage

13 years agoWe developers are so elitist, running shiny machines with all PHP extensions in the...
Max Semenik [Fri, 1 Apr 2011 18:24:37 +0000 (18:24 +0000)]
We developers are so elitist, running shiny machines with all PHP extensions in the world installed, that we couldn't notice that "no scaler found" message didn't work from the beginning! :P

13 years agoFixed issue where reference error can be thrown - response to comments on r84985
Trevor Parscal [Fri, 1 Apr 2011 18:05:15 +0000 (18:05 +0000)]
Fixed issue where reference error can be thrown - response to comments on r84985

13 years agoFollowup r84825
Sam Reed [Fri, 1 Apr 2011 17:29:15 +0000 (17:29 +0000)]
Followup r84825

Allow obtaining of an import token if users have the importupload right

13 years agoRevert r64853 (add $wgLogAutocreatedAccounts to enable/disable account autocreation...
Chad Horohoe [Fri, 1 Apr 2011 15:57:20 +0000 (15:57 +0000)]
Revert r64853 (add $wgLogAutocreatedAccounts to enable/disable account autocreation logging, bug 19161). Per the *extremely lengthy* discussion that is still ongoing, this fails to solve the underlying problem and has undesired side-effects.

I don't know what the proper solution is (other than introducing user preferences, like bug 28369 suggests, is not the answer)...but the status quo of what we had is better than this half-assed solution that *nobody* likes.

13 years agoDocument what settings are disabled by $wgHtml5
Aryeh Gregor [Fri, 1 Apr 2011 14:50:29 +0000 (14:50 +0000)]
Document what settings are disabled by $wgHtml5

Bug 28350.

13 years agoFix for r85114, see code reviev
Purodha B Blissenbach [Fri, 1 Apr 2011 11:28:18 +0000 (11:28 +0000)]
Fix for r85114, see code reviev
at http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85114

13 years agoFix r85110, see code review
Purodha B Blissenbach [Fri, 1 Apr 2011 10:46:56 +0000 (10:46 +0000)]
Fix r85110, see code review
at http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85110

13 years agoDrop 5.1 compatibility calls to session_set_cookie_params() and setcookie() since...
Alexandre Emsenhuber [Fri, 1 Apr 2011 09:50:09 +0000 (09:50 +0000)]
Drop 5.1 compatibility calls to session_set_cookie_params() and setcookie() since we require 5.2.3+ now

13 years agoAdd optional PLURAL parameter to messages 'userrights-changeable-col' and 'userrights...
Purodha B Blissenbach [Fri, 1 Apr 2011 09:35:44 +0000 (09:35 +0000)]
Add optional PLURAL parameter to messages 'userrights-changeable-col' and 'userrights-unchangeable-col'

13 years agoMoved constant initialisation to class definition instead of constructor
Alexandre Emsenhuber [Fri, 1 Apr 2011 09:35:39 +0000 (09:35 +0000)]
Moved constant initialisation to class definition instead of constructor

13 years ago* (bug 27893) Edit-on-doubleclick now applies only on view and purge actions;
Brion Vibber [Thu, 31 Mar 2011 23:40:51 +0000 (23:40 +0000)]
* (bug 27893) Edit-on-doubleclick now applies only on view and purge actions;
  no longer triggers unexpectedly on delete, history etc.

13 years agoFix omission of r85007,
Purodha B Blissenbach [Thu, 31 Mar 2011 23:23:11 +0000 (23:23 +0000)]
Fix omission of r85007,
see code review at http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85007

13 years agoFix for r85005: the getUserPermissionsErrors() calls were each returning a badaccess...
Happy-melon [Thu, 31 Mar 2011 23:09:02 +0000 (23:09 +0000)]
Fix for r85005: the getUserPermissionsErrors() calls were each returning a badaccess error when the user didn't have their particular permission, even if they had the other one, exclude these errors since they're already covered by the $user->isAllowedAny() check above.  Also fix processForm() to check isAllowed('import') for transwiki; this wasn't being done which meant users with importupload but not import (an unlikely combination to be fair) could still spoof the form.

13 years agoTweak doc comment per bug 28340
Brion Vibber [Thu, 31 Mar 2011 23:02:38 +0000 (23:02 +0000)]
Tweak doc comment per bug 28340

13 years agoThis script didn't actually work, and was a live hack. This is a followup to the...
Ryan Lane [Thu, 31 Mar 2011 21:16:22 +0000 (21:16 +0000)]
This script didn't actually work, and was a live hack. This is a followup to the fixme in r79021.

13 years agoLocalisation updates for core and extension messages from translatewiki.net (2011...
Raimond Spekking [Thu, 31 Mar 2011 19:42:16 +0000 (19:42 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-03-31 19:24:00 UTC)

13 years agoFollow-up r85021: fix comment
Max Semenik [Thu, 31 Mar 2011 14:11:42 +0000 (14:11 +0000)]
Follow-up r85021: fix comment

13 years agoDocument blocklist-target message, per TWN request http://translatewiki.net/wiki...
Happy-melon [Thu, 31 Mar 2011 10:29:10 +0000 (10:29 +0000)]
Document blocklist-target message, per TWN request translatewiki.net/wiki/Thread:Support/Please_document_MediaWiki:Blocklist-target

13 years agoDon't differentiate between user accounts and IPs in special page names.
Niklas Laxström [Thu, 31 Mar 2011 10:21:30 +0000 (10:21 +0000)]
Don't differentiate between user accounts and IPs in special page names.

BTW: Special:Block says "Block user" in page title followed immediately "Block user" as legend for fieldset.

13 years agoFix grammar for singular. Spotted by McDutchie.
Siebrand Mazeland [Thu, 31 Mar 2011 07:12:16 +0000 (07:12 +0000)]
Fix grammar for singular. Spotted by McDutchie.

13 years agoFollowup to r85021, fix caller in updater maintenance script
OverlordQ [Wed, 30 Mar 2011 20:56:03 +0000 (20:56 +0000)]
Followup to r85021, fix caller in updater maintenance script

13 years agoFollow-up r85025 - use strict comparison
Happy-melon [Wed, 30 Mar 2011 20:05:17 +0000 (20:05 +0000)]
Follow-up r85025 - use strict comparison

13 years agoLocalisation updates for core and extension messages from translatewiki.net (2011...
Raimond Spekking [Wed, 30 Mar 2011 20:03:22 +0000 (20:03 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-03-30 19:35:00 UTC)

13 years agoFixup a couple more undefined variables
Sam Reed [Wed, 30 Mar 2011 19:44:39 +0000 (19:44 +0000)]
Fixup a couple more undefined variables

13 years agoFixup undefined $stores in if like renamewiki does it
Sam Reed [Wed, 30 Mar 2011 19:39:59 +0000 (19:39 +0000)]
Fixup undefined $stores in if like renamewiki does it

13 years agoFixup/add documentation
Sam Reed [Wed, 30 Mar 2011 19:00:11 +0000 (19:00 +0000)]
Fixup/add documentation

Remove some unused variables

13 years agoSwap = to == in conditional
Sam Reed [Wed, 30 Mar 2011 18:56:31 +0000 (18:56 +0000)]
Swap = to == in conditional

13 years agoFixed fatal in r84971
Max Semenik [Wed, 30 Mar 2011 18:45:13 +0000 (18:45 +0000)]
Fixed fatal in r84971

13 years agoMove duplicated Site class into own class in Maintenance.php, include in 2 users
Sam Reed [Wed, 30 Mar 2011 18:40:36 +0000 (18:40 +0000)]
Move duplicated Site class into own class in Maintenance.php, include in 2 users

13 years agoFix class name
Sam Reed [Wed, 30 Mar 2011 18:37:25 +0000 (18:37 +0000)]
Fix class name

13 years agoFix missing parameter to cacheUpdate
Sam Reed [Wed, 30 Mar 2011 18:34:38 +0000 (18:34 +0000)]
Fix missing parameter to cacheUpdate

13 years agoFollow-up r85020 per CR - use strict comparison
Happy-melon [Wed, 30 Mar 2011 18:06:05 +0000 (18:06 +0000)]
Follow-up r85020 per CR - use strict comparison

13 years ago(bug 23408) give admins a warning before letting them block themselves. Also tweak...
Happy-melon [Wed, 30 Mar 2011 18:00:11 +0000 (18:00 +0000)]
(bug 23408) give admins a warning before letting them block themselves.  Also tweak the logic so that loading the interface for one already-blocked user, then actually submitting a block on a different user, shows the confirmation again if the second user is already blocked.

13 years agoAdd a couple of brace test cases.
Platonides [Wed, 30 Mar 2011 17:41:58 +0000 (17:41 +0000)]
Add a couple of brace test cases.

13 years ago(bug 19942) remove deprecated HTML attributes (cellpadding, align, valign) from Table...
Happy-melon [Wed, 30 Mar 2011 17:37:25 +0000 (17:37 +0000)]
(bug 19942) remove deprecated HTML attributes (cellpadding, align, valign) from TablePager.

13 years ago(bug 28237) Installer doesn't create extension tables
Max Semenik [Wed, 30 Mar 2011 17:32:20 +0000 (17:32 +0000)]
(bug 28237) Installer doesn't create extension tables

13 years ago(bug 18937) avoid broken wikimarkup (four apostrophes together) in MediaWiki:Confirmr...
Happy-melon [Wed, 30 Mar 2011 17:04:03 +0000 (17:04 +0000)]
(bug 18937) avoid broken wikimarkup (four apostrophes together) in MediaWiki:Confirmrecreate when there is no deletion reason, by using a separate message.

13 years ago(bug 17009) remove hiddenStructure. Wasn't even applied across all skins anyway...
Happy-melon [Wed, 30 Mar 2011 16:44:13 +0000 (16:44 +0000)]
(bug 17009) remove hiddenStructure.  Wasn't even applied across all skins anyway, would have been broken in cologneblue, standard, etc.

13 years agoMerge some deployment changes to trunk: r82738 (as HISTORY), r81962
Chad Horohoe [Wed, 30 Mar 2011 14:33:37 +0000 (14:33 +0000)]
Merge some deployment changes to trunk: r82738 (as HISTORY), r81962

13 years agoAdd optional parameter $1 for PLURAL use to messages userrights-groupsmember and...
Purodha B Blissenbach [Wed, 30 Mar 2011 13:52:32 +0000 (13:52 +0000)]
Add optional parameter $1 for PLURAL use to messages userrights-groupsmember and userrights-groupsmember-auto

13 years agoAdditional release notes for r85005, which I meant to commit as two separate revision...
Happy-melon [Wed, 30 Mar 2011 12:58:09 +0000 (12:58 +0000)]
Additional release notes for r85005, which I meant to commit as two separate revisions as one needs to be backported (grr...)

13 years ago(bug 15641) tweak Title::checkUserBlock() so that Title::getUserPermissionsErrors...
Happy-melon [Wed, 30 Mar 2011 12:53:13 +0000 (12:53 +0000)]
(bug 15641) tweak Title::checkUserBlock() so that Title::getUserPermissionsErrors() more comprehensively prevents blocked users from performing various actions; particularly prevents blocked admins from protecting or deleting their own talk page.

13 years agoFixup some ambiguously defined variables
Sam Reed [Wed, 30 Mar 2011 12:04:54 +0000 (12:04 +0000)]
Fixup some ambiguously defined variables

Cast a substr back to int

13 years agoUse unused $fallback_languages
Sam Reed [Wed, 30 Mar 2011 12:04:25 +0000 (12:04 +0000)]
Use unused $fallback_languages

13 years agoFix new typos introduced in r84799.
Purodha B Blissenbach [Wed, 30 Mar 2011 06:35:32 +0000 (06:35 +0000)]
Fix new typos introduced in r84799.