lhc/web/wiklou.git
14 years ago(bug 20372) Improve rollback-revisiondelete handling
Aaron Schulz [Wed, 2 Sep 2009 22:16:24 +0000 (22:16 +0000)]
(bug 20372) Improve rollback-revisiondelete handling

14 years agoclarify msg
Aaron Schulz [Wed, 2 Sep 2009 22:00:50 +0000 (22:00 +0000)]
clarify msg

14 years ago* Fix for r55741 - selecting no revisions made PHP notices
Aaron Schulz [Wed, 2 Sep 2009 21:46:21 +0000 (21:46 +0000)]
* Fix for r55741 - selecting no revisions made PHP notices
* Some unrelated cleanups to old code

14 years ago* (bug 20464) Force manual recaching to false in LocalisationCache::disableBackend...
Alexandre Emsenhuber [Wed, 2 Sep 2009 20:16:26 +0000 (20:16 +0000)]
* (bug 20464) Force manual recaching to false in LocalisationCache::disableBackend() since otherwise an Exception with the message "No localisation cache found for English. Please run maintenance/rebuildLocalisationCache.php." is thrown each time update.php is executed.

14 years ago* (bug 20446) When changing user rights with User@remotewiki and remotewiki is the...
Alexandre Emsenhuber [Wed, 2 Sep 2009 15:58:49 +0000 (15:58 +0000)]
* (bug 20446) When changing user rights with User@remotewiki and remotewiki is the local wiki, the user is now treated as the local user

14 years agoFix for r53194: according to the XSLT 1.0 spec, the MIME type should be text/xml...
Tim Starling [Wed, 2 Sep 2009 08:05:47 +0000 (08:05 +0000)]
Fix for r53194: according to the XSLT 1.0 spec, the MIME type should be text/xml or application/xml. In XSLT 2.0, it is application/xslt+xml. Either way, text/xsl is wrong.

14 years agoUse transparent instead of inherit, for compatibility with IE, as suggested by Simetr...
Tim Starling [Wed, 2 Sep 2009 07:47:54 +0000 (07:47 +0000)]
Use transparent instead of inherit, for compatibility with IE, as suggested by Simetrical on CR r52669.

14 years agoFixes for r51204: removed useless $wgVariant and StubUserVariant. In Skin::makeGlobal...
Tim Starling [Wed, 2 Sep 2009 07:19:35 +0000 (07:19 +0000)]
Fixes for r51204: removed useless $wgVariant and StubUserVariant. In Skin::makeGlobalVariablesScript(), use $wgContLang->getPreferredVariant() instead, which is the variant used in the relevant server-side code.

14 years agoRevert r52158 per CR: was attempting to convert text to UTF-8 that was already UTF...
Tim Starling [Wed, 2 Sep 2009 06:34:07 +0000 (06:34 +0000)]
Revert r52158 per CR: was attempting to convert text to UTF-8 that was already UTF-8, this would have resulted in mojibake.

14 years agoRemove completely useless change to the include_path that doesn't work for 99% of...
Chad Horohoe [Wed, 2 Sep 2009 02:51:18 +0000 (02:51 +0000)]
Remove completely useless change to the include_path that doesn't work for 99% of the people using this. Incidentally, that amounts to about 0 people.

14 years ago* Fixed CR r48837. Although using ids[]=x in the query string is wrong and broken...
Tim Starling [Wed, 2 Sep 2009 01:59:36 +0000 (01:59 +0000)]
* Fixed CR r48837. Although using ids[]=x in the query string is wrong and broken, ids[x]=1 works just fine and is a convenient interface.
* Fixed CR r49408: removed JS dependency for multiple revision delete/undelete. Using <button type=submit> we can submit the parameter "action=revisiondelete". The custom action is then distributed to Special:Revisiondelete, which can understand this kind of entry point with only minor changes.
* Also used <button type=submit> to avoid submitting the htmldiff button caption back to the server
* Show the same buttons at the top and bottom of the history page, refactored duplicated code

14 years agoDon't need that anymore
Chad Horohoe [Tue, 1 Sep 2009 23:38:46 +0000 (23:38 +0000)]
Don't need that anymore

14 years agoAdd new maintenance script for mass-rollbacking edits by a given user or IP address...
Chad Horohoe [Tue, 1 Sep 2009 23:08:54 +0000 (23:08 +0000)]
Add new maintenance script for mass-rollbacking edits by a given user or IP address. Also can pass a list of titles in case you want to limit it to some pages but not others \o/

14 years agoMay as well use the master for start/end points
Aaron Schulz [Tue, 1 Sep 2009 22:37:37 +0000 (22:37 +0000)]
May as well use the master for start/end points

14 years agoAdded a script to move users from one group to another
Aaron Schulz [Tue, 1 Sep 2009 20:53:55 +0000 (20:53 +0000)]
Added a script to move users from one group to another

14 years ago* (bug 20466) Hidden categories are no more displayed when printing
Alexandre Emsenhuber [Tue, 1 Sep 2009 20:22:00 +0000 (20:22 +0000)]
* (bug 20466) Hidden categories are no more displayed when printing

14 years ago* fixed scaling issue on edit action.
Michael Dale [Tue, 1 Sep 2009 18:57:28 +0000 (18:57 +0000)]
* fixed scaling issue on edit action.

14 years agoLocalisation updates for core messages from translatewiki.net (2009-09-01 17:21 UTC)
Siebrand Mazeland [Tue, 1 Sep 2009 18:00:02 +0000 (18:00 +0000)]
Localisation updates for core messages from translatewiki.net (2009-09-01 17:21 UTC)

14 years ago* r55034#c3604 re-factored presently used curl options to back-end agnostic options.
Michael Dale [Tue, 1 Sep 2009 16:01:51 +0000 (16:01 +0000)]
* r55034#c3604 re-factored presently used curl options to back-end agnostic options.
* broke out curl and php based requests into separate classes ( more general cleanup is of course possible :)
* @@todo these tokens need to be mapped to php fopen stream "context" along with a more general mapping of the rest of the curl options.

14 years agoFollow-up to r55700 - patch up a path through which Article::mParserOutput could...
Happy-melon [Tue, 1 Sep 2009 14:11:29 +0000 (14:11 +0000)]
Follow-up to r55700 - patch up a path through which Article::mParserOutput could be called without being set, and armour the call in Article::getRobotPolicy against other unforeseen paths.

14 years ago(bug 20463) Replace is_a() with instanceof. Installer already bails on PHP4 before...
Chad Horohoe [Tue, 1 Sep 2009 14:09:33 +0000 (14:09 +0000)]
(bug 20463) Replace is_a() with instanceof. Installer already bails on PHP4 before we get here, so it's ok. Still one usage of is_a() in t/Test.php, but nothing calls it and I don't care.

14 years agoMinor spacing tweaks, etc to make it even more like Monobook. Further proving that...
Chad Horohoe [Tue, 1 Sep 2009 01:11:56 +0000 (01:11 +0000)]
Minor spacing tweaks, etc to make it even more like Monobook. Further proving that there is Entirely Too Much Duplication Here!

14 years agoLocalisation updates for core messages from translatewiki.net (2009-08-31 19:30 UTC)
Raimond Spekking [Mon, 31 Aug 2009 20:16:22 +0000 (20:16 +0000)]
Localisation updates for core messages from translatewiki.net (2009-08-31 19:30 UTC)

14 years ago(bug14900) Make __INDEX__ and __NOINDEX__ not override $wgArticleRobotPolicies where...
Happy-melon [Mon, 31 Aug 2009 19:19:12 +0000 (19:19 +0000)]
(bug14900) Make __INDEX__ and __NOINDEX__ not override $wgArticleRobotPolicies where the two conflict.

14 years agoBetter documentation for $wgPagePropLinkInvalidations.
Happy-melon [Mon, 31 Aug 2009 18:43:14 +0000 (18:43 +0000)]
Better documentation for $wgPagePropLinkInvalidations.

14 years agoLocalization update.
Rotem Liss [Mon, 31 Aug 2009 14:44:43 +0000 (14:44 +0000)]
Localization update.

14 years agoskip math-related tests if $wgUseTeX is set to false in LocalSettings: this probably...
Ilmari Karonen [Mon, 31 Aug 2009 14:29:11 +0000 (14:29 +0000)]
skip math-related tests if $wgUseTeX is set to false in LocalSettings: this probably means we don't have a working texvc program available

14 years agofollowup to r55694: forgot to mark the new functions private
Ilmari Karonen [Mon, 31 Aug 2009 14:01:04 +0000 (14:01 +0000)]
followup to r55694: forgot to mark the new functions private

14 years agoredo r45388 (hopefully) more cleanly (see also bug 16916: Unnecessary title disambigu...
Ilmari Karonen [Mon, 31 Aug 2009 13:58:28 +0000 (13:58 +0000)]
redo r45388 (hopefully) more cleanly (see also bug 16916: Unnecessary title disambiguation by cleanupImages.php)

14 years ago(bug 18880) Make LogEventsList::showLogExtract() more versatile by allowing it to...
Happy-melon [Mon, 31 Aug 2009 11:54:53 +0000 (11:54 +0000)]
(bug 18880) Make LogEventsList::showLogExtract() more versatile by allowing it to take a string-by-reference instead of OutputPage; hence allowing it to be used for buffered content.

14 years agoReimplement r55685, r55686, r55687, with correct parsing of the associative array...
Happy-melon [Mon, 31 Aug 2009 11:30:50 +0000 (11:30 +0000)]
Reimplement r55685, r55686, r55687, with correct parsing of the associative array.  Also add message description to MessagesQqq as requested at r55685.

14 years agoRevert r55685, r55686 and r55687 for now. Limits not working.
Niklas Laxström [Mon, 31 Aug 2009 06:54:52 +0000 (06:54 +0000)]
Revert r55685, r55686 and r55687 for now. Limits not working.

14 years agoLocalisation updates Cantonese, Chinese and Literary Chinese
Shinjiman [Mon, 31 Aug 2009 01:24:31 +0000 (01:24 +0000)]
Localisation updates Cantonese, Chinese and Literary Chinese

14 years agoFollow-up to r55685 - update messages.inc, and fix wierd positioning of comment in...
Happy-melon [Sun, 30 Aug 2009 22:06:05 +0000 (22:06 +0000)]
Follow-up to r55685 - update messages.inc, and fix wierd positioning of comment in RELEASE-NOTES

14 years ago* Allow IndexPager->mLimitsShown to be an associative array of limit => text-to-displ...
Happy-melon [Sun, 30 Aug 2009 21:50:10 +0000 (21:50 +0000)]
* Allow IndexPager->mLimitsShown to be an associative array of limit => text-to-display-in-limit-form pairs.
* Use this to add an "all" value to the limit form in Special:AllMessages.  In reality, "all" is only 5000, but this is plenty more than most wikis should have.

14 years agoUse $wgScript rather than $this->getTitle()->getLocalURL() for the action parameter...
Alexandre Emsenhuber [Sun, 30 Aug 2009 19:41:18 +0000 (19:41 +0000)]
Use $wgScript rather than $this->getTitle()->getLocalURL() for the action parameter, since the title parameter is already present in the hidden fields and it doesn't work with ugly URLS
Reported by MaxSem on IRC.

14 years ago(bug 2257) Add a $frame parameter to recursiveTagParse so tag extensions can expand...
Nephele [Sun, 30 Aug 2009 06:37:10 +0000 (06:37 +0000)]
(bug 2257) Add a $frame parameter to recursiveTagParse so tag extensions can expand template parameters

14 years agoFixed EditFilterMerged hook to use hookError param
Nephele [Sun, 30 Aug 2009 05:55:47 +0000 (05:55 +0000)]
Fixed EditFilterMerged hook to use hookError param

14 years agoAdded font size for simple search label - this broke cause of the other font sizing...
Trevor Parscal [Sat, 29 Aug 2009 23:34:19 +0000 (23:34 +0000)]
Added font size for simple search label - this broke cause of the other font sizing changes that have been made recently (r55333).

14 years ago(bug 20260) SQLite: don't always autocreate DB and its directory. If the file isn...
Chad Horohoe [Sat, 29 Aug 2009 12:35:40 +0000 (12:35 +0000)]
(bug 20260) SQLite: don't always autocreate DB and its directory. If the file isn't readable at execution time, we now throw an exception

14 years agoLocalisation updates Cantonese, Chinese and Literary Chinese
Shinjiman [Sat, 29 Aug 2009 12:17:19 +0000 (12:17 +0000)]
Localisation updates Cantonese, Chinese and Literary Chinese

14 years agoLocalization update.
Rotem Liss [Sat, 29 Aug 2009 09:18:52 +0000 (09:18 +0000)]
Localization update.

14 years agoAdd set_time_limit( 0 ) to the installer; this should cut down on cases during instal...
Benjamin Lees [Sat, 29 Aug 2009 07:40:18 +0000 (07:40 +0000)]
Add set_time_limit( 0 ) to the installer; this should cut down on cases during installation where no user gets created, and during upgrades where people don't know that they might have to run the script several times.

14 years agoMediawiki:tags-tag amended accordig to request of User:Lloffiwr at http://translatewi...
Purodha B Blissenbach [Sat, 29 Aug 2009 03:02:53 +0000 (03:02 +0000)]
Mediawiki:tags-tag amended accordig to request of User:Lloffiwr at translatewiki.net/wiki/Support#tags-tag

14 years ago(bug 20223) Move .comment and .changedby to shared.css and out of Monobook/Modern.
Chad Horohoe [Fri, 28 Aug 2009 23:34:55 +0000 (23:34 +0000)]
(bug 20223) Move .comment and .changedby to shared.css and out of Monobook/Modern.

14 years ago* Add buffering to ApiFormatBase, which allows buffering the result without needing...
Bryan Tong Minh [Fri, 28 Aug 2009 21:18:39 +0000 (21:18 +0000)]
* Add buffering to ApiFormatBase, which allows buffering the result without needing ob_* functions. This is for async downloads, but I couldn't get it to work yet so this commit does not contain the files that actually use the buffering.
* Hide internalhttpsession parameter from web requests

14 years agoAdd MakeSysop and MakeBot as aliases for UserRights so that links to them won't total...
Alex Z [Fri, 28 Aug 2009 20:41:36 +0000 (20:41 +0000)]
Add MakeSysop and MakeBot as aliases for UserRights so that links to them won't totally break when the extensions are disabled (bugs 14156/20291).
Adding to core since I wasn't able to find a clean way to do it with WikimediaMessages.

14 years agoFix wfShellBackgroundExec for windows. Works in maintenance/eval.php mode, have not...
Bryan Tong Minh [Fri, 28 Aug 2009 19:32:07 +0000 (19:32 +0000)]
Fix wfShellBackgroundExec for windows. Works in maintenance/eval.php mode, have not tested when running php as webserver module.

14 years agoFix typo reported at twn
Niklas Laxström [Fri, 28 Aug 2009 18:09:57 +0000 (18:09 +0000)]
Fix typo reported at twn

14 years ago* (bug 19055) maintenance/rebuildrecentchanges.php now purges Special:Recentchanges...
Alexandre Emsenhuber [Fri, 28 Aug 2009 18:04:40 +0000 (18:04 +0000)]
* (bug 19055) maintenance/rebuildrecentchanges.php now purges Special:Recentchanges's RSS and Atom feed cache
Purging cache timestamps should be sufficient since it won't allow cached versions to be used.
Also fix some errors in docs/memcached.txt.
Based on a patch by Jidanni - http://bug-attachment.wikimedia.org/attachment.cgi?id=6187

14 years agoReverted breakage of non-ASCII message keys, Domas says that's not allowed. Optimised...
Tim Starling [Fri, 28 Aug 2009 17:58:54 +0000 (17:58 +0000)]
Reverted breakage of non-ASCII message keys, Domas says that's not allowed. Optimised Language::lcfirst and Language::ucfirst() instead.
Timings in microseconds for ASCII no-change, ASCII change, non-ASCII no-change, non-ASCII change:
lcfirst: 1.8, 3.6, 21.2, 22.1
ucfirst: 1.5, 2.3, 21.1, 21.7

14 years agoAdd a patch file for the index change in r47488
Roan Kattouw [Fri, 28 Aug 2009 17:54:35 +0000 (17:54 +0000)]
Add a patch file for the index change in r47488

14 years agosweet spot for compression, per:
Domas Mituzas [Fri, 28 Aug 2009 17:46:19 +0000 (17:46 +0000)]
sweet spot for compression, per:
* http://spreadsheets.google.com/pub?key=t-EjyzEfh0t39hoQbf-a5fw

14 years agoLocalisation updates for core JavaScript messages from translatewiki.net
Siebrand Mazeland [Fri, 28 Aug 2009 17:07:32 +0000 (17:07 +0000)]
Localisation updates for core JavaScript messages from translatewiki.net

14 years agoAPI: BREAKING CHANGE: (bug 20426) Instead of throwing an error when a limit is set...
Roan Kattouw [Fri, 28 Aug 2009 16:37:48 +0000 (16:37 +0000)]
API: BREAKING CHANGE: (bug 20426) Instead of throwing an error when a limit is set too high/low, throw a warning and continue with the limit set to the maximum/minimum

14 years agoRemove a few language codes that were 'supported' without any localisation. Have...
Siebrand Mazeland [Fri, 28 Aug 2009 15:15:37 +0000 (15:15 +0000)]
Remove a few language codes that were 'supported' without any localisation. Have no known projects that use localisation for them. Language support could be re-added if a sufficient localisation level would be reached in translatewiki.net. Were added in r28537 or r28572.
* Easter Yiddish (ydd)
* Palembang (plm)
* Tamazight (tzm)
* Iriga Bicolano (bto)

14 years agoLocalisation updates for core messages from translatewiki.net (2009-08-26 12:55 UTC)
Raimond Spekking [Fri, 28 Aug 2009 13:06:15 +0000 (13:06 +0000)]
Localisation updates for core messages from translatewiki.net (2009-08-26 12:55 UTC)

14 years ago* improved inline AMW upload
Michael Dale [Fri, 28 Aug 2009 03:53:17 +0000 (03:53 +0000)]
* improved inline AMW upload

14 years agoRevert r53534 (bug 15745, Make the edit summary link parser detect links more like...
Chad Horohoe [Thu, 27 Aug 2009 22:27:42 +0000 (22:27 +0000)]
Revert r53534 (bug 15745, Make the edit summary link parser detect links more like the real parser). Causes preg_replace_callback bug in 5.2.8 and below, crashes lots of things. See bug 19845 and bugs.php.net/bug.php?id=48501

14 years agoAPI: Add user-agent and method (GET/POST) to request logging, and only log the action...
Roan Kattouw [Thu, 27 Aug 2009 22:09:28 +0000 (22:09 +0000)]
API: Add user-agent and method (GET/POST) to request logging, and only log the action= parameter for mustBePosted modules

14 years agoAPI: Refactor the XML formatter a bit so that ApiFormatXml::recXmlPrint() is now...
Roan Kattouw [Thu, 27 Aug 2009 21:15:20 +0000 (21:15 +0000)]
API: Refactor the XML formatter a bit so that ApiFormatXml::recXmlPrint() is now actually usable as a generic XML formatter

14 years ago* some js2 cleanup and refactoring for upload support
Michael Dale [Thu, 27 Aug 2009 18:26:51 +0000 (18:26 +0000)]
* some js2 cleanup and refactoring for upload support
* some minor work needed to finish cleaning up inline add media wizard upload across all upload modes (firefogg / normal http post)

14 years agoAPI: Cache API help in memcached, inital use of the API log added earlier seems to...
Roan Kattouw [Thu, 27 Aug 2009 18:25:51 +0000 (18:25 +0000)]
API: Cache API help in memcached, inital use of the API log added earlier seems to indicate that the help is expensive. Cache doesn't seem to help for me locally, so we probably need to test this on a real server and see if it really works.

14 years agoRevert r52983 for now, could cause unexpected syntax interactions, we want to investi...
Andrew Garrett [Thu, 27 Aug 2009 17:16:15 +0000 (17:16 +0000)]
Revert r52983 for now, could cause unexpected syntax interactions, we want to investigate this before deploying it

14 years agocorrect notes line for 20404 -- not a tooltip
Brion Vibber [Thu, 27 Aug 2009 17:15:12 +0000 (17:15 +0000)]
correct notes line for 20404 -- not a tooltip

14 years agoAPI: Add optional API request logging to a file or UDP; intending to use this on...
Roan Kattouw [Thu, 27 Aug 2009 17:07:23 +0000 (17:07 +0000)]
API: Add optional API request logging to a file or UDP; intending to use this on the cluster to get some data about API usage and things like which queries are expensive

14 years agofixed : spaces to only look outside of "quotes"
Michael Dale [Thu, 27 Aug 2009 16:56:54 +0000 (16:56 +0000)]
fixed : spaces to only look outside of "quotes"

14 years agoI LOVE OO PEOPLE <3 <3 <3
Domas Mituzas [Thu, 27 Aug 2009 16:28:48 +0000 (16:28 +0000)]
I LOVE OO PEOPLE <3 <3 <3

14 years agoRm useless thumbs.db files.
Chad Horohoe [Thu, 27 Aug 2009 15:30:16 +0000 (15:30 +0000)]
Rm useless thumbs.db files.

14 years agoFixed bug with MW 1.4 style archive rows, with ar_text set: ar_flags can be gzip...
Tim Starling [Thu, 27 Aug 2009 15:02:00 +0000 (15:02 +0000)]
Fixed bug with MW 1.4 style archive rows, with ar_text set: ar_flags can be gzip. Reported by email.

14 years agoAPI: Do a STRAIGHT_JOIN in ApiQueryBacklinks's first query to counter a MySQL 4 bug...
Roan Kattouw [Thu, 27 Aug 2009 14:58:19 +0000 (14:58 +0000)]
API: Do a STRAIGHT_JOIN in ApiQueryBacklinks's first query to counter a MySQL 4 bug where the optmizer chooses to do a table scan on page instead.

14 years agoenabled async download via configuration var: wgEnableAsyncDownload (pending windows...
Michael Dale [Thu, 27 Aug 2009 14:47:52 +0000 (14:47 +0000)]
enabled async download via configuration var: wgEnableAsyncDownload (pending windows fix)
 (should have been part of the last commit)

14 years agoenabled async downloaded via configuration var: wgEnableAsyncDownload (pending window...
Michael Dale [Thu, 27 Aug 2009 14:46:54 +0000 (14:46 +0000)]
enabled async downloaded via configuration var: wgEnableAsyncDownload (pending windows fix)

14 years agoquick fix for r55604 broken chunk upload class abstraction
Michael Dale [Thu, 27 Aug 2009 14:30:14 +0000 (14:30 +0000)]
quick fix for r55604 broken chunk upload class abstraction

14 years ago* Output warnings as filenames rather than an array representation of a File object.
Bryan Tong Minh [Thu, 27 Aug 2009 14:21:53 +0000 (14:21 +0000)]
* Output warnings as filenames rather than an array representation of a File object.
* Renamed variable in UploadBase::checkWarnings to better indicate its meaning

14 years ago* (bug 20404) Custom fields in the user creation form template can now have tooltips
Alexandre Emsenhuber [Thu, 27 Aug 2009 14:15:02 +0000 (14:15 +0000)]
* (bug 20404) Custom fields in the user creation form template can now have tooltips

14 years agoAPI: Per rainman, mark list=search as an expensive query and lower its limits to...
Roan Kattouw [Wed, 26 Aug 2009 21:13:06 +0000 (21:13 +0000)]
API: Per rainman, mark list=search as an expensive query and lower its limits to 50/500 from 500/5000

14 years ago* Cleanup ApiUpload
Bryan Tong Minh [Wed, 26 Aug 2009 19:38:38 +0000 (19:38 +0000)]
* Cleanup ApiUpload
* UploadBase::verifyUpload now always returns a status array
* Disabled async upload by url because wfShellBackgroundExec is broken

14 years agoPartial revert of r53664 (bug 14201 Set $wgDBadminuser/$wgDBadminpassword during...
Chad Horohoe [Wed, 26 Aug 2009 18:56:00 +0000 (18:56 +0000)]
Partial revert of r53664 (bug 14201 Set $wgDBadminuser/$wgDBadminpassword during setup). Gives Brion icky feelings about setting a root password.

14 years ago(bug 20408) Missing global declarations.
Chad Horohoe [Wed, 26 Aug 2009 18:18:58 +0000 (18:18 +0000)]
(bug 20408) Missing global declarations.

14 years agoLocalisation updates for core messages from translatewiki.net (2009-08-26 17:25 UTC)
Raimond Spekking [Wed, 26 Aug 2009 17:43:58 +0000 (17:43 +0000)]
Localisation updates for core messages from translatewiki.net (2009-08-26 17:25 UTC)

14 years agoFollow-up r55584: seems that the "View logs for this page" link is useful even when...
Alexandre Emsenhuber [Wed, 26 Aug 2009 17:37:42 +0000 (17:37 +0000)]
Follow-up r55584: seems that the "View logs for this page" link is useful even when doing log suppression :)

14 years agoUnify properties in ApiQueryAllimages, ApiQueryImageinfo and ApiUpload.
Bryan Tong Minh [Wed, 26 Aug 2009 17:30:36 +0000 (17:30 +0000)]
Unify properties in ApiQueryAllimages, ApiQueryImageinfo and ApiUpload.

14 years agoRemoved the $tmpFile parameter to UploadBase::verifyUpload in favour of $this->mTempFile.
Bryan Tong Minh [Wed, 26 Aug 2009 17:08:49 +0000 (17:08 +0000)]
Removed the $tmpFile parameter to UploadBase::verifyUpload in favour of $this->mTempFile.

14 years ago* Code style & commenting on upload functions.
Bryan Tong Minh [Wed, 26 Aug 2009 17:05:24 +0000 (17:05 +0000)]
* Code style & commenting on upload functions.
* Move isValidURI from UploadFromUrl to HttpFunctions.
* Made some functions in UploadBase static.

14 years agoAdded parser test for r55601, has to clear MagicWord's object caching so that parser...
Alexandre Emsenhuber [Wed, 26 Aug 2009 16:57:53 +0000 (16:57 +0000)]
Added parser test for r55601, has to clear MagicWord's object caching so that parser function aliases are also available when using a different language that English

14 years ago* (bug 8143) Localised parser function names are now correctly case insensitive if...
Alexandre Emsenhuber [Wed, 26 Aug 2009 15:47:03 +0000 (15:47 +0000)]
* (bug 8143) Localised parser function names are now correctly case insensitive if they contain non-ASCII characters
Patch by Matěj Grabovský - http://bug-attachment.wikimedia.org/attachment.cgi?id=6406

14 years agoRestore size=60 that got eaten by r55453
Aryeh Gregor [Wed, 26 Aug 2009 15:12:50 +0000 (15:12 +0000)]
Restore size=60 that got eaten by r55453

We should really be using CSS for this to get nice fluid widths, but
it's a real pain to do with tables' weird magical width algorithms.

14 years agoFix for error accessing uninitialized namespace aliases array... use the accessor...
Brion Vibber [Wed, 26 Aug 2009 15:03:20 +0000 (15:03 +0000)]
Fix for error accessing uninitialized namespace aliases array... use the accessor, which lazy-initializes :)

14 years agoUse type=search for Monobook sidebar
Aryeh Gregor [Wed, 26 Aug 2009 14:59:59 +0000 (14:59 +0000)]
Use type=search for Monobook sidebar

Didn't bother to do this for other skins at the moment.  This should
allow more native-looking styling on some platforms (e.g., Safari on
Mac).

14 years agol10n added to oracle tables.sql
Jure Kajzer [Wed, 26 Aug 2009 14:49:42 +0000 (14:49 +0000)]
l10n added to oracle tables.sql

14 years agoFor search, move "create page" below "no results"
Aryeh Gregor [Wed, 26 Aug 2009 14:34:28 +0000 (14:34 +0000)]
For search, move "create page" below "no results"

This looks slightly less odd, with the user no longer being told to
create the page before they're even told it doesn't exist.  But it still
looks pretty odd.

14 years agoMake resolveConflictOn() accept a prefix different from the page name (needed for...
Chad Horohoe [Wed, 26 Aug 2009 14:06:36 +0000 (14:06 +0000)]
Make resolveConflictOn() accept a prefix different from the page name (needed for archive, bug 10171). Add comment about crappy interwiki prefix checking.

14 years agoReplace our mb_substr() fallback implementation with one which is not quite so horrib...
Brion Vibber [Wed, 26 Aug 2009 05:51:21 +0000 (05:51 +0000)]
Replace our mb_substr() fallback implementation with one which is not quite so horrible...

While not too awful on smallish strings, the way it worked was *murder* on large input:
the *entire string* would be broken up into an array of individual characters, sliced up,
then merged back together.

In my testing I couldn't even get the function to complete in a reasonable time for, say,
127k worth of text... not only did the regex split take forever, but it would eat an insane
amount of memory, likely triggering memory_limit hits in a sane world.

The new implementation counts characters from the beginning or end of a string to determine
the byte-based offsets to use for substr() start and count parameters, and only uses
a couple temporary dupes of the string in memory. For typical short offset/count cases
(take or trim one or a few characters) this performs about 3-5x worse than native mb_substr()
for in my testing.

Large offsets are optimized by first skipping the same number of bytes as characters, since all
characters take at least one byte. On primarily Latin text this made some of my test cases
actually *faster* than native mb_substr()! ;) For non-Latin texts this takes out a fair chunk
of our work, but can still leave us with very slow execution -- eg ~30ms to get through a few
dozens of kilobytes worth of offset on Japanese text. But at least it completes now!

This could probably be optimized further, perhaps skipping progressively smaller chunks in
binary-chop fashion. :)

For fun, my profiling results (profiling & test scripts are in a little git repo which I would
push to gitorious to poke at, but gitorious hates me right now and won't finish my repo setup):

strlen       mb_strlen short ascii - 0.0019ms - 19
strlen      xmb_strlen short ascii - 0.0672ms - 19

strlen       mb_strlen short unicode - 0.0019ms - 19
strlen      xmb_strlen short unicode - 0.0657ms - 19

strlen       mb_strlen long ascii - 0.0826ms - 20000
strlen      xmb_strlen long ascii - 0.1236ms - 20000

strlen       mb_strlen long unicode - 0.0774ms - 20000
strlen      xmb_strlen long unicode - 0.1901ms - 20000

strlen       mb_strlen san francisco - 0.4775ms - 126700
strlen      xmb_strlen san francisco - 0.4474ms - 126700

substr       mb_substr short ascii first - 0.0022ms - 1-byte string ("s") <- native
substr      xmb_substr short ascii first - 0.0168ms - 1-byte string ("s") <- old fallback
substr     xmb_substr3 short ascii first - 0.0069ms - 1-byte string ("s") <- new fallback

substr       mb_substr short ascii last - 0.0023ms - 1-byte string ("s")
substr      xmb_substr short ascii last - 0.0171ms - 1-byte string ("s")
substr     xmb_substr3 short ascii last - 0.0113ms - 1-byte string ("s")

substr       mb_substr short ascii trim last 9 - 0.0023ms - 10-byte string ("short asci")
substr      xmb_substr short ascii trim last 9 - 0.0183ms - 10-byte string ("short asci")
substr     xmb_substr3 short ascii trim last 9 - 0.0119ms - 10-byte string ("short asci")

substr       mb_substr short ascii middle 3 - 0.0022ms - 3-byte string ("sci")
substr      xmb_substr short ascii middle 3 - 0.0171ms - 3-byte string ("sci")
substr     xmb_substr3 short ascii middle 3 - 0.0149ms - 3-byte string ("sci")

substr       mb_substr short unicode first - 0.0022ms - 1-byte string ("s")
substr      xmb_substr short unicode first - 0.0184ms - 1-byte string ("s")
substr     xmb_substr3 short unicode first - 0.0071ms - 1-byte string ("s")

substr       mb_substr short unicode last - 0.0026ms - 2-byte string ("ß")
substr      xmb_substr short unicode last - 0.0187ms - 2-byte string ("ß")
substr     xmb_substr3 short unicode last - 0.0130ms - 2-byte string ("ß")

substr       mb_substr short unicode trim last 9 - 0.0024ms - 14-byte string ("short áéíó")
substr      xmb_substr short unicode trim last 9 - 0.0200ms - 14-byte string ("short áéíó")
substr     xmb_substr3 short unicode trim last 9 - 0.0137ms - 14-byte string ("short áéíó")

substr       mb_substr short unicode middle 3 - 0.0022ms - 6-byte string ("éíó")
substr      xmb_substr short unicode middle 3 - 0.0188ms - 6-byte string ("éíó")
substr     xmb_substr3 short unicode middle 3 - 0.0189ms - 6-byte string ("éíó")

substr       mb_substr san fran first - 0.0022ms - 1-byte string ("{")
substr     xmb_substr3 san fran first - 0.0069ms - 1-byte string ("{")

substr       mb_substr san fran last - 0.8914ms - 1-byte string ("\n")
substr     xmb_substr3 san fran last - 0.0109ms - 1-byte string ("\n")

substr       mb_substr san fran non-first - 0.5995ms - 127318-byte string (c00cabc812ac347bd2e81a3e3f04e23d)
substr     xmb_substr3 san fran non-first - 0.0213ms - 127318-byte string (c00cabc812ac347bd2e81a3e3f04e23d)

substr       mb_substr san fran middle 1k - 0.2218ms - 1025-byte string (c42eb5c511670f72ff4593a39219682c)
substr     xmb_substr3 san fran middle 1k - 0.3883ms - 1025-byte string (c42eb5c511670f72ff4593a39219682c)

substr       mb_substr boston-ja first - 0.0021ms - 1-byte string ("{")
substr     xmb_substr3 boston-ja first - 0.0068ms - 1-byte string ("{")

substr       mb_substr boston-ja last - 0.5497ms - 1-byte string ("\n")
substr     xmb_substr3 boston-ja last - 0.0110ms - 1-byte string ("\n")

substr       mb_substr boston-ja non-first - 0.4128ms - 127637-byte string (933e70d1d10f4d64cdfbd69b58592cd4)
substr     xmb_substr3 boston-ja non-first - 0.0216ms - 127637-byte string (933e70d1d10f4d64cdfbd69b58592cd4)

substr       mb_substr boston-ja middle 1k - 0.2237ms - 2006-byte string (1eaa8554ff4507109b1cba7a597d82bf)
substr     xmb_substr3 boston-ja middle 1k - 30.6811ms - 2006-byte string (1eaa8554ff4507109b1cba7a597d82bf)

14 years agoRevert r53841 (Favicon, apple-touch-icon links matching the defaults should not be...
Chad Horohoe [Tue, 25 Aug 2009 22:27:32 +0000 (22:27 +0000)]
Revert r53841 (Favicon, apple-touch-icon links matching the defaults should not be sent). Doesn't actually work upon further testing

14 years ago(bug 19999) Made metadata and properties of search results optional. Added srprop...
Bryan Tong Minh [Tue, 25 Aug 2009 20:18:12 +0000 (20:18 +0000)]
(bug 19999) Made metadata and properties of search results optional. Added srprop and srinfo.

14 years ago* (bug 20380) Link to history/log action at the top of Special:RevisionDelete are...
Alexandre Emsenhuber [Tue, 25 Aug 2009 19:57:35 +0000 (19:57 +0000)]
* (bug 20380) Link to history/log action at the top of Special:RevisionDelete are new more displayed when when doing log suppression
They're useless since they're linking to Special:Log/xxx?action=history, Special:Log?page=Special:Log, etc.

14 years agoRemove unused message. Checked for core and all extensions in our SVN.
Raimond Spekking [Tue, 25 Aug 2009 19:23:44 +0000 (19:23 +0000)]
Remove unused message. Checked for core and all extensions in our SVN.

14 years agoWhitespace
Aryeh Gregor [Tue, 25 Aug 2009 18:57:47 +0000 (18:57 +0000)]
Whitespace

14 years agoFix for r52174 - don't show footer for non-existing users
Niklas Laxström [Tue, 25 Aug 2009 18:36:44 +0000 (18:36 +0000)]
Fix for r52174 - don't show footer for non-existing users