lhc/web/wiklou.git
12 years agoBig cleanup to DifferenceEngine:
Alexandre Emsenhuber [Wed, 5 Oct 2011 19:55:04 +0000 (19:55 +0000)]
Big cleanup to DifferenceEngine:
* Call Linker methods statically
* Factorised a lot of duplicate code, such as "Mark patrolled" links, revisions headers, etc.
* Removed showFirstRevision() and made that case be handled through the normal showDiffPage(). In such case, the header will look like a normal diff page, except it is centred. For this, addHeader() will now center the "new revision" header if the string passed to the "old revision" header and the diff is empty. getDiffBody() will also return an empty string if $mOldRev is false.
* Showing only one revision when the previous was not found will also ask to unhide the revision is deleted as in normal case
* Backed out code that generates the revision header from loadRevisionData() so that this function does not make a mix of backend and UI stuff. Factorised the code in getRevisionHeader().
* Lazy-load page's language and revisions IDs (in case of "prev", "next", etc. are passed) instead of doing that in constructor.
* Made a good part of links compatible with Special:ComparePages, such as navigation links, "undo", etc. that links to the title corresponding to the revision and not the given title in the constuctor.
* "Current revision as of" can also be displayed on the old revision, useful when comparing two current revisions in Special:ComparePages
* Removed navigation, undo and rollback links when comparing two different pages, this can confuses users thinking they are comparing two revisions of the same page. Also clicking on a "undo" link in such case will give "revision not found".
* Check if the user can read the revisions before sending a external editor file

12 years agoLocalisation updates for core and extension messages from translatewiki.net
Raimond Spekking [Wed, 5 Oct 2011 19:39:20 +0000 (19:39 +0000)]
Localisation updates for core and extension messages from translatewiki.net

12 years agoFix the bug reported on w:en:WP:VP/T where clicking on links in sortable table header...
Roan Kattouw [Wed, 5 Oct 2011 19:27:55 +0000 (19:27 +0000)]
Fix the bug reported on w:en:WP:VP/T where clicking on links in sortable table headers sorts the table rather than following the link

12 years agoinexistent -> nonexistent
Krinkle [Wed, 5 Oct 2011 18:55:13 +0000 (18:55 +0000)]
inexistent -> nonexistent
* Follows-up r98366

12 years agoAdding fixme comment above an old piece of code that I'd rather not change right now
Krinkle [Wed, 5 Oct 2011 18:45:27 +0000 (18:45 +0000)]
Adding fixme comment above an old piece of code that I'd rather not change right now

12 years ago* (bug 31380) Fix style regression on Special:Allmessages
Brion Vibber [Wed, 5 Oct 2011 18:37:42 +0000 (18:37 +0000)]
* (bug 31380) Fix style regression on Special:Allmessages

Table cells for customized messages were missing the classes used to style the default & actual text differently. Got lost in r90334: added dir/lang attributes for the language but accidentally left out the classes.

12 years ago* Use local context instead of global variables
Alexandre Emsenhuber [Wed, 5 Oct 2011 14:46:10 +0000 (14:46 +0000)]
* Use local context instead of global variables
* Call Linker methods statically

12 years agoParse 'yourtext' message for the diff header to match the other usage in <h2> just...
Alexandre Emsenhuber [Wed, 5 Oct 2011 14:42:45 +0000 (14:42 +0000)]
Parse 'yourtext' message for the diff header to match the other usage in <h2> just below

12 years ago3 PHP Fatal error: Call to undefined method LocalFile::getFileKey() in /usr/local...
Sam Reed [Wed, 5 Oct 2011 13:47:02 +0000 (13:47 +0000)]
3 PHP Fatal error:  Call to undefined method LocalFile::getFileKey() in /usr/local/apache/common-local/php-1.18/includes/api/ApiUpload.php on line 150

Tag: REL1_18, 1.18wmf1

12 years agoAdd/update documentation
Sam Reed [Wed, 5 Oct 2011 13:43:32 +0000 (13:43 +0000)]
Add/update documentation

12 years agoFix bug in r83814 reported on IRC: categorymembers did not set an ORDER BY when cmcon...
Roan Kattouw [Wed, 5 Oct 2011 13:15:44 +0000 (13:15 +0000)]
Fix bug in r83814 reported on IRC: categorymembers did not set an ORDER BY when cmcontinue was set, which broke paging when cmdir=desc was used.

12 years ago(bug 31363) Expand description URLs for thumbnails to canonical form
Roan Kattouw [Wed, 5 Oct 2011 10:16:49 +0000 (10:16 +0000)]
(bug 31363) Expand description URLs for thumbnails to canonical form

12 years agoFollowup to r98839 and r98851 according to Nikerabbit's suggestions: Xml -> Html...
Amir E. Aharoni [Wed, 5 Oct 2011 06:45:11 +0000 (06:45 +0000)]
Followup to r98839 and r98851 according to Nikerabbit's suggestions: Xml -> Html and some whitespace.

12 years agoFixed:
Aaron Schulz [Wed, 5 Oct 2011 02:36:40 +0000 (02:36 +0000)]
Fixed:
Undefined index: IPV6 in D:\www\MW_trunk\phase\includes\specials\SpecialBlock.php on line 516

12 years agoPorted in r98971 from deployment
Aaron Schulz [Wed, 5 Oct 2011 01:45:26 +0000 (01:45 +0000)]
Ported in r98971 from deployment

12 years agoFix undefined $title
Sam Reed [Wed, 5 Oct 2011 00:49:53 +0000 (00:49 +0000)]
Fix undefined $title

12 years agoCall to undefined method CologneBlueTemplate::getInternalLinkAttributes() in /usr...
Sam Reed [Wed, 5 Oct 2011 00:45:34 +0000 (00:45 +0000)]
Call to undefined method CologneBlueTemplate::getInternalLinkAttributes() in /usr/local/apache/common-local/php-1.18/includes/SkinLegacy.php on line 487

12 years ago(bug 31179) Fixed problems with undeletion making bad page rows:
Aaron Schulz [Tue, 4 Oct 2011 21:31:31 +0000 (21:31 +0000)]
(bug 31179) Fixed problems with undeletion making bad page rows:
* Moved up isCountable() call, since insertOn() sets the page ID, it safer to do this call first. It now uses master DB data, as it should for reads to write data. Furthermore, calling it after insertOn() was triggered loadPageData() on a slave, breaking the page ID cache just set in insertOn().
* Preemptively call loadPageData( 'fromdbmaster' ) as Article::doEdit() does (r98880) to avoid any lazy loading from the slave which can corrupt the page ID cache.

12 years ago* Use local context instead of global variables
Alexandre Emsenhuber [Tue, 4 Oct 2011 20:30:37 +0000 (20:30 +0000)]
* Use local context instead of global variables
* Use Linker::linkKnown() where possible
* Break long lines

12 years agoFollowup r98578 - expect nulls
Niklas Laxström [Tue, 4 Oct 2011 20:02:20 +0000 (20:02 +0000)]
Followup r98578 - expect nulls

12 years agoLocalisation updates for core and extension messages from translatewiki.net
Raimond Spekking [Tue, 4 Oct 2011 20:02:01 +0000 (20:02 +0000)]
Localisation updates for core and extension messages from translatewiki.net

12 years agoFix language name for 'jam'
Robin Pepermans [Tue, 4 Oct 2011 18:59:23 +0000 (18:59 +0000)]
Fix language name for 'jam'

12 years agoCall loadPageData() with 'fromdbmaster' in doEdit() to avoid old slave data
Aaron Schulz [Tue, 4 Oct 2011 18:40:13 +0000 (18:40 +0000)]
Call loadPageData() with 'fromdbmaster' in doEdit() to avoid old slave data

12 years agoFix for r98756: $wgDefaultExternalStore can also be a string
Alexandre Emsenhuber [Tue, 4 Oct 2011 16:51:37 +0000 (16:51 +0000)]
Fix for r98756: $wgDefaultExternalStore can also be a string

12 years agoSimplify a bit by adding the result inside the wfRunHooks() check
Alexandre Emsenhuber [Tue, 4 Oct 2011 14:32:07 +0000 (14:32 +0000)]
Simplify a bit by adding the result inside the wfRunHooks() check

12 years agosvn:eol-style native
Alexandre Emsenhuber [Tue, 4 Oct 2011 14:11:16 +0000 (14:11 +0000)]
svn:eol-style native

12 years ago* Added a script to prune old file cache entries.
Aaron Schulz [Tue, 4 Oct 2011 08:03:43 +0000 (08:03 +0000)]
* Added a script to prune old file cache entries.
* Use default .cache extension for ResourceFileCache. No need for js/css extension, and makes extension sanity check in prune script simpler.
* Removed redundant setting of mExt in ObjectFileCache

12 years agoFollowup to r98847. Replacing .= with =
Amir E. Aharoni [Tue, 4 Oct 2011 07:33:12 +0000 (07:33 +0000)]
Followup to r98847. Replacing .= with =

12 years agoFollowup to r98839. Removed 'escape' from wfMsgExt (suggested by Nikerabbit); wrote...
Amir E. Aharoni [Tue, 4 Oct 2011 03:08:49 +0000 (03:08 +0000)]
Followup to r98839. Removed 'escape' from wfMsgExt (suggested by Nikerabbit); wrote full class names (suggested by Krinkle).

12 years agoThe general fix is setting the directionality of added or removed bytes in recent...
Amir E. Aharoni [Tue, 4 Oct 2011 00:12:09 +0000 (00:12 +0000)]
The general fix is setting the directionality of added or removed bytes in recent changes. It is always supposed to be LTR.

Details:
* Spelling of variable names and comments: formated -> formatted
* Replaced "<$tag" with Xml::element
* Added a dirmark before the username (otherwise the added or removed appear on the other side)

12 years agoMore whitespace and comments
Sam Reed [Mon, 3 Oct 2011 22:51:38 +0000 (22:51 +0000)]
More whitespace and comments

12 years agoFollowup r98808, pressing save is sehr-useful
Sam Reed [Mon, 3 Oct 2011 22:41:27 +0000 (22:41 +0000)]
Followup r98808, pressing save is sehr-useful

12 years ago* (bug 31282) Fix use of ForeignAPIRepo/InstantCommons TIFF images when $wgTiffThumbn...
Brion Vibber [Mon, 3 Oct 2011 22:04:04 +0000 (22:04 +0000)]
* (bug 31282) Fix use of ForeignAPIRepo/InstantCommons TIFF images when $wgTiffThumbnailType is left unset.

When pulling files over ForeignAPIRepo, the source site is what creates the thumbnails; we don't care whether we can locally produce thumbs of TIFFs.
This feels a bit hacky, and may indicate we need to better refactor media handlers & file repositories. As long as the source site can produce a thumbnail image URL or a chunk of HTML to export, the local site shouldn't have to touch any of that stuff and should just be passing data through.

12 years agoUpdate jquery.ui to 1.8.16
Sam Reed [Mon, 3 Oct 2011 21:01:18 +0000 (21:01 +0000)]
Update jquery.ui to 1.8.16

Added new Datepicker languages where appropriate (ie stuff we support)

12 years agoLocalisation updates for core and extension messages from translatewiki.net
Raimond Spekking [Mon, 3 Oct 2011 18:58:08 +0000 (18:58 +0000)]
Localisation updates for core and extension messages from translatewiki.net

12 years agoUse local context instead of global variables
Alexandre Emsenhuber [Mon, 3 Oct 2011 17:48:54 +0000 (17:48 +0000)]
Use local context instead of global variables

12 years agoFix embarrassing mistake in r98718
Roan Kattouw [Mon, 3 Oct 2011 16:26:10 +0000 (16:26 +0000)]
Fix embarrassing mistake in r98718

12 years agoFix comment in r98374
Roan Kattouw [Mon, 3 Oct 2011 14:59:56 +0000 (14:59 +0000)]
Fix comment in r98374

12 years agoRemoved call to OutputPage::setSyndicated( true ) just before calling OutputPage...
Alexandre Emsenhuber [Mon, 3 Oct 2011 14:21:20 +0000 (14:21 +0000)]
Removed call to OutputPage::setSyndicated( true ) just before calling OutputPage::setFeedAppendQuery(); the former is useless when calling the latter

12 years agoAlso catch Special:Badtitle to display the "Bad title" error message since this is...
Alexandre Emsenhuber [Mon, 3 Oct 2011 14:04:43 +0000 (14:04 +0000)]
Also catch Special:Badtitle to display the "Bad title" error message since this is now how it is passed in the context object. When such error occured, the user was redirected to Special:Badtitle and got the "Special page does not exist" message.

12 years agoMerge r97670, r98206
Sam Reed [Mon, 3 Oct 2011 13:41:50 +0000 (13:41 +0000)]
Merge r97670, r98206

12 years agoMerge r97771, r97775
Sam Reed [Mon, 3 Oct 2011 13:37:47 +0000 (13:37 +0000)]
Merge r97771, r97775

12 years agoMerge r97687
Sam Reed [Mon, 3 Oct 2011 13:19:22 +0000 (13:19 +0000)]
Merge r97687

12 years agoRename $wgVaryOnXFPForAPI (introduced in r93818) to $wgVaryOnXFP and extend it to...
Roan Kattouw [Mon, 3 Oct 2011 13:15:28 +0000 (13:15 +0000)]
Rename $wgVaryOnXFPForAPI (introduced in r93818) to $wgVaryOnXFP and extend it to also apply to HTTP redirects. The previous name was overly specific for what has become a more generic setting, and we can still change it now that it's not in any release yet.

12 years ago(bug 31320) CentralAuth uses http URLs for autologin images when logging in over...
Roan Kattouw [Mon, 3 Oct 2011 10:27:23 +0000 (10:27 +0000)]
(bug 31320) CentralAuth uses http URLs for autologin images when logging in over https.

Renamed WikiReference::getUrl() to getCanonicalUrl() (but kept the old name as a back compat alias), and added getFullUrl() which returns a URL built using $wgServer rather than $wgCanonicalServer, which means it'll be protocol-relative if the wiki is configured for that.

12 years agoFixed outdated $wgFileCacheDirectory comment
Aaron Schulz [Mon, 3 Oct 2011 07:57:54 +0000 (07:57 +0000)]
Fixed outdated $wgFileCacheDirectory comment

12 years agoSimplified cacheDirectory() in FileCacheBase and HTMLFileCache. It turns out $wgFileC...
Aaron Schulz [Mon, 3 Oct 2011 06:54:39 +0000 (06:54 +0000)]
Simplified cacheDirectory() in FileCacheBase and HTMLFileCache. It turns out $wgFileCacheDirectory is always set in setup.php already.

12 years agoFollow-up r98698: cache urls with 'version' param...which is kind if important
Aaron Schulz [Mon, 3 Oct 2011 05:32:48 +0000 (05:32 +0000)]
Follow-up r98698: cache urls with 'version' param...which is kind if important

12 years agoFollowup r97138 - could not reproduce myself
Niklas Laxström [Mon, 3 Oct 2011 03:35:18 +0000 (03:35 +0000)]
Followup r97138 - could not reproduce myself

12 years agoFix r98719: in hindsight, this message should be empty by default. Raymond asked...
Roan Kattouw [Sun, 2 Oct 2011 21:42:24 +0000 (21:42 +0000)]
Fix r98719: in hindsight, this message should be empty by default. Raymond asked me what to do and I told him the wrong thing

12 years agoFollowup r98718: Register new message key with content per chat with Roan and set...
Raimond Spekking [Sun, 2 Oct 2011 21:18:04 +0000 (21:18 +0000)]
Followup r98718: Register new message key with content per chat with Roan and set it to ignore for translatewiki.net

12 years agoFollowup r98707: apply this logic to signupend too, per a bug comment.
Roan Kattouw [Sun, 2 Oct 2011 21:07:54 +0000 (21:07 +0000)]
Followup r98707: apply this logic to signupend too, per a bug comment.

12 years agoTitle::isValidMoveOperation needs a db
Platonides [Sun, 2 Oct 2011 21:07:17 +0000 (21:07 +0000)]
Title::isValidMoveOperation needs a db

12 years agoFollowup r98707, r98713: check for blankness, not nonexistence. Since r98713 the...
Roan Kattouw [Sun, 2 Oct 2011 20:58:15 +0000 (20:58 +0000)]
Followup r98707, r98713: check for blankness, not nonexistence. Since r98713 the -https message always exists, so the check was broken

12 years agoFixed broken ipb_deleted condition. Does not effect the special page since it is...
Aaron Schulz [Sun, 2 Oct 2011 20:50:48 +0000 (20:50 +0000)]
Fixed broken ipb_deleted condition. Does not effect the special page since it is redundant for that use (the condition is added elsewhere).

12 years agoFollowup r98707: Register new message key and set it to ignore for translatewiki.net
Raimond Spekking [Sun, 2 Oct 2011 20:44:25 +0000 (20:44 +0000)]
Followup r98707: Register new message key and set it to ignore for translatewiki.net
This way the key is shown in Special:Allmessages even if empty.

12 years agoFollow-up r84395: Give MediaHandlers the option to remove items from the thumbnail...
Bryan Tong Minh [Sun, 2 Oct 2011 20:08:05 +0000 (20:08 +0000)]
Follow-up r84395: Give MediaHandlers the option to remove items from the thumbnail purge list. Is needed for TMH because thumbnail rendering may be very expensive for media files. Haven't thought yet of a way to integrate this with the UI, but the current framework should be flexible enough to implement that later.

Added array $options to File::purgeCache(), LocalFile::purgeCache(), LocalFile::purgeThumbnails(), ForeignAPIFile::purgeCache() and ForeignAPIFile::purgeThumbnails() which is currently empty, but can be used later to indicate a full or partial purge.
Added MediaHandler::filterThumbnailPurgeList(), which can remove items from the purge list and also gets passed this $options array

12 years ago(bug 31293) If Special:Userlogin is loaded over HTTPS, display MediaWiki:loginend...
Roan Kattouw [Sun, 2 Oct 2011 20:02:35 +0000 (20:02 +0000)]
(bug 31293) If Special:Userlogin is loaded over HTTPS, display MediaWiki:loginend-https instead of MediaWiki:loginend, if it exists

12 years ago* Added isCacheWorthy() optimization (checks if the file exists, stale or not)
Aaron Schulz [Sun, 2 Oct 2011 19:44:31 +0000 (19:44 +0000)]
* Added isCacheWorthy() optimization (checks if the file exists, stale or not)
* Made isCached() use process cache
* Added MISS_TTL_SEC constant and tweaked MISS_FACTOR constant

12 years agoFollowup r96930: also remove the documentation that describes the reverted behavior
Roan Kattouw [Sun, 2 Oct 2011 19:35:07 +0000 (19:35 +0000)]
Followup r96930: also remove the documentation that describes the reverted behavior

12 years agoFileCache:
Aaron Schulz [Sun, 2 Oct 2011 17:53:33 +0000 (17:53 +0000)]
FileCache:
* Added FileCacheBase::*MissesRecent() functions for counting cache misses from different visitors.
* Made ObjectFileCache more generic.
* Cleaned up FileCacheBase::checkCacheDirs().
* Added FileCacheBase::typeSubdirectory() function and overwrote in HTMLFileCache. Fixes r98405 invalidating all existing cache due to directory change.
* Simplified FileCacheBase::checkCacheDirs() a bit

ResourceLoader:
* Use ResourceFileCache to handle load() requests, if $wgUseFileCache. Only caches requests for default language and skins. Single modules requests are always cached, whereas others require a certain threshold of traffic.
* Added ResourceFileCache class (functionality was initially to be in ObjectFileCache).

12 years agoMore RequestContext -> IContextSource.
Daniel Friesen [Sun, 2 Oct 2011 17:42:21 +0000 (17:42 +0000)]
More RequestContext -> IContextSource.

12 years agoAdded missing directory to findHooks.php and a missing hook in hooks.txt
Alexandre Emsenhuber [Sun, 2 Oct 2011 17:36:19 +0000 (17:36 +0000)]
Added missing directory to findHooks.php and a missing hook in hooks.txt

12 years ago* Added end parameter and redid arguments as parameters.
Aaron Schulz [Sun, 2 Oct 2011 17:19:19 +0000 (17:19 +0000)]
* Added end parameter and redid arguments as parameters.
* Set $wgReadOnly to avoid firing enotif stuff and such.
* Pushed commit() statements outside of batch loop...added begin().
* Removed wfWaitForSlaves(), which is just more overhead...nothing should be writing to the DB, the transaction is there just in case.

12 years agoPort r51457 from monobook to modern, simple and Vector.
Derk-Jan Hartman [Sun, 2 Oct 2011 16:50:52 +0000 (16:50 +0000)]
Port r51457 from monobook to modern, simple and Vector.
See also Bug 18207

Takes care of disappearing symbol when clicking extiw links, and triggering the external link and https lock icon on internal links.

12 years agoMerge r98679 from the pageoutput branch into trunk.
Daniel Friesen [Sun, 2 Oct 2011 16:37:32 +0000 (16:37 +0000)]
Merge r98679 from the pageoutput branch into trunk.

12 years ago* Use local context instead of global variables
Alexandre Emsenhuber [Sun, 2 Oct 2011 16:30:59 +0000 (16:30 +0000)]
* Use local context instead of global variables
* Call Linker methods statically

12 years agoFollow up r98665. And remove the old css of course.
Derk-Jan Hartman [Sun, 2 Oct 2011 16:10:41 +0000 (16:10 +0000)]
Follow up r98665. And remove the old css of course.

12 years agoFollow up to r98665.
Derk-Jan Hartman [Sun, 2 Oct 2011 16:06:19 +0000 (16:06 +0000)]
Follow up to r98665.

Forgot to add the new css file.

12 years ago* (bug 30466) Entries in iwlinks table are now cleared when moving a page over redirect
Alexandre Emsenhuber [Sun, 2 Oct 2011 16:01:35 +0000 (16:01 +0000)]
* (bug 30466) Entries in iwlinks table are now cleared when moving a page over redirect

12 years agoAdd tfoot emulation to tablesorter. Fixes part of the complaints in bug 31060
Derk-Jan Hartman [Sun, 2 Oct 2011 11:58:46 +0000 (11:58 +0000)]
Add tfoot emulation to tablesorter. Fixes part of the complaints in bug 31060

12 years agoAdd the class jquery-tablesorter to all tables that are made sortable.
Derk-Jan Hartman [Sun, 2 Oct 2011 11:08:12 +0000 (11:08 +0000)]
Add the class jquery-tablesorter to all tables that are made sortable.
Use this classname to raise the specificity of the sortHeader, so that it is more difficult to accidently override with local css. Followup to r98069

Move the css into a seperate file and move the images for it to the jquery directory.

12 years agoReverted accidental change in r98405
Aaron Schulz [Sun, 2 Oct 2011 07:29:39 +0000 (07:29 +0000)]
Reverted accidental change in r98405

12 years agoRevert r98355 and r98357; drop the field instead.
Max Semenik [Sun, 2 Oct 2011 06:10:55 +0000 (06:10 +0000)]
Revert r98355 and r98357; drop the field instead.

12 years agoDon't show 'autoblock disabled' for IP blocks
Aaron Schulz [Sun, 2 Oct 2011 06:10:45 +0000 (06:10 +0000)]
Don't show 'autoblock disabled' for IP blocks

12 years agoFU r98559: added cannotchangeemail
Aaron Schulz [Sat, 1 Oct 2011 23:39:36 +0000 (23:39 +0000)]
FU r98559: added cannotchangeemail

12 years agomediaWiki.language.convertPlural not required since it is same as the default implime...
Santhosh Thottingal [Sat, 1 Oct 2011 22:34:54 +0000 (22:34 +0000)]
mediaWiki.language.convertPlural not required since it is same as the default implimentation in mediawiki.language.js

12 years agoFix Bug 29299 - Zero should be considered plural for pt-br
Santhosh Thottingal [Sat, 1 Oct 2011 18:42:36 +0000 (18:42 +0000)]
Fix Bug 29299 - Zero should be considered plural for pt-br

12 years agoAdd support for namespaces in Special:RecentChanges subpage filter (bug 31297)
Krinkle [Sat, 1 Oct 2011 18:20:31 +0000 (18:20 +0000)]
Add support for namespaces in Special:RecentChanges subpage filter (bug 31297)

12 years agoFixed case of ID in selector
Aaron Schulz [Sat, 1 Oct 2011 06:16:08 +0000 (06:16 +0000)]
Fixed case of ID in selector

12 years agoFixed bogus addModules() call which broke the JS on the block form (didn't load)
Aaron Schulz [Sat, 1 Oct 2011 05:55:12 +0000 (05:55 +0000)]
Fixed bogus addModules() call which broke the JS on the block form (didn't load)

12 years agoTweak r98602: keep the other IP normalization for non-ranges, such as upper case...
Aaron Schulz [Sat, 1 Oct 2011 05:11:21 +0000 (05:11 +0000)]
Tweak r98602: keep the other IP normalization for non-ranges, such as upper case for v6. This keeps it a bit more consistent.

12 years agoReverted stuff from r98602 committed by mistake
Aaron Schulz [Sat, 1 Oct 2011 05:03:10 +0000 (05:03 +0000)]
Reverted stuff from r98602 committed by mistake

12 years agoMade provideIPCIDRs() not add a '/' if there is no prefix length. Fixes bug 31234.
Aaron Schulz [Sat, 1 Oct 2011 04:54:44 +0000 (04:54 +0000)]
Made provideIPCIDRs() not add a '/' if there is no prefix length. Fixes bug 31234.

12 years agoRefactored out new sendResponseHeaders() and tryRespondLastModified() functions out...
Aaron Schulz [Sat, 1 Oct 2011 04:15:07 +0000 (04:15 +0000)]
Refactored out new sendResponseHeaders() and tryRespondLastModified() functions out of respond() code. These changes were made for $wgUseFileCache support (haven't committed the other stuff here).

12 years ago* (bug 31289) Fix fatal error on special pages using $this->msg() on PHP 5.2
Brion Vibber [Sat, 1 Oct 2011 02:03:05 +0000 (02:03 +0000)]
* (bug 31289) Fix fatal error on special pages using $this->msg() on PHP 5.2

According to online PHP docs, func_get_args() doesn't work in function parameter lists until PHP 5.3.0.
It does, however, work as the *first* parameter, which happens here and there in older code (eg array_slice(func_get_args(),1)).
Assigning to a variable and passing through works fine for this case on PHP 5.2.17.

12 years agoRevert r97788
Santhosh Thottingal [Sat, 1 Oct 2011 01:35:06 +0000 (01:35 +0000)]
Revert r97788

12 years ago* (bug 12130) Initial newlines are now preserved correctly during editing
Brion Vibber [Fri, 30 Sep 2011 22:50:48 +0000 (22:50 +0000)]
* (bug 12130) Initial newlines are now preserved correctly during editing

HTML browsers strip the first newline from the literal contents of a <textarea>, but keep any additional newlines beyond that.

Prepending an extra newline in Html::textarea() when the contained text started with a newline makes our output basically look like this:

<textarea>             <-- (this added newline is ignored)
                       <-- (any original newline here is preserved)
blah blah</textarea>

This seems to consistently resolve the stripping of single initial newlines from every edit operation as seen on bug 12130; as noted on comments there <https://bugzilla.wikimedia.org/show_bug.cgi?id=12130#c17> this had deleterious effects on Wikisource, where transcription/proofreading tends to involve breaking up lots of little pages, which may have a significant newline at the start of a page boundary.

Text that didn't have initial newlines won't see any difference in the HTML output.

Followup to test cases in r98576, which confirm that supported browsers consistently have this behavior.

12 years agoQUnit test case to confirm consistent browser behavior with initial newlines inside...
Brion Vibber [Fri, 30 Sep 2011 22:16:37 +0000 (22:16 +0000)]
QUnit test case to confirm consistent browser behavior with initial newlines inside <textarea> HTML source. (for bug 12130)

12 years agoFU r98559: added 'cannotchangeemail' msg
Aaron Schulz [Fri, 30 Sep 2011 21:40:03 +0000 (21:40 +0000)]
FU r98559: added 'cannotchangeemail' msg

12 years ago(bug 31283) Made ChangeEmail check $wgAuth->allowPropChange( 'emailaddress' ). Fix...
Aaron Schulz [Fri, 30 Sep 2011 20:43:45 +0000 (20:43 +0000)]
(bug 31283) Made ChangeEmail check $wgAuth->allowPropChange( 'emailaddress' ). Fix for r92924. Mark beat me to committing the rest of the fix in r98558, which just hid the link to the special page.

12 years agore r92924 andFix Bug #31283 - "Change E-mail" option in Preference should be hidden
Mark A. Hershberger [Fri, 30 Sep 2011 20:36:52 +0000 (20:36 +0000)]
re r92924 andFix Bug #31283 - "Change E-mail" option in Preference should be hidden
when AuthPlugin#allowEmailChange() returns false

Patch from Rusty Burchfield

12 years agoMade addNewUserLogEntry() return the ID of the new log entry to be more useful
Aaron Schulz [Fri, 30 Sep 2011 17:31:36 +0000 (17:31 +0000)]
Made addNewUserLogEntry() return the ID of the new log entry to be more useful

12 years agoSyntax error fix for r98528
Chad Horohoe [Fri, 30 Sep 2011 15:57:32 +0000 (15:57 +0000)]
Syntax error fix for r98528

12 years agoAdding two maintenance classes to autoloader - Translate extension is using them
Niklas Laxström [Fri, 30 Sep 2011 15:45:48 +0000 (15:45 +0000)]
Adding two maintenance classes to autoloader - Translate extension is using them

12 years agoRevert tests
Roan Kattouw [Fri, 30 Sep 2011 13:57:06 +0000 (13:57 +0000)]
Revert tests

12 years agoDemonstrating that committing to SVN works for me, Sam was complaining about it being...
Roan Kattouw [Fri, 30 Sep 2011 13:52:00 +0000 (13:52 +0000)]
Demonstrating that committing to SVN works for me, Sam was complaining about it being broken.

12 years agoAddress fixme on r96978: expand URLs fed to the client-side loader
Roan Kattouw [Fri, 30 Sep 2011 10:14:39 +0000 (10:14 +0000)]
Address fixme on r96978: expand URLs fed to the client-side loader

12 years agoRevision::newFromTitle() returns null sometimes. Protect against the errors.
Sean Colombo [Thu, 29 Sep 2011 23:11:31 +0000 (23:11 +0000)]
Revision::newFromTitle() returns null sometimes.  Protect against the errors.

12 years agoKill the updater remnants from r98467
Sam Reed [Thu, 29 Sep 2011 22:28:10 +0000 (22:28 +0000)]
Kill the updater remnants from r98467