lhc/web/wiklou.git
12 years agoA d d s p a c e s
Chad Horohoe [Thu, 1 Sep 2011 14:33:57 +0000 (14:33 +0000)]
A d d  s p a c e s

12 years agoShut up build script about not having LocalSettings. You dont actually need it for...
Chad Horohoe [Thu, 1 Sep 2011 14:09:50 +0000 (14:09 +0000)]
Shut up build script about not having LocalSettings. You dont actually need it for this

12 years agow/s
Siebrand Mazeland [Thu, 1 Sep 2011 13:59:38 +0000 (13:59 +0000)]
w/s

12 years ago* updated oracle schema to current
Jure Kajzer [Thu, 1 Sep 2011 13:55:14 +0000 (13:55 +0000)]
* updated oracle schema to current
* updater tested, installer untested(but should work :) )

12 years agoRemove type hint that broke r95975
Roan Kattouw [Thu, 1 Sep 2011 13:07:27 +0000 (13:07 +0000)]
Remove type hint that broke r95975

12 years agoAdd ResourceLoaderContext::newDummyContext() function
Roan Kattouw [Thu, 1 Sep 2011 13:02:20 +0000 (13:02 +0000)]
Add ResourceLoaderContext::newDummyContext() function

12 years agoSplit up TablePager css class, introduce .mw-datatable
Krinkle [Thu, 1 Sep 2011 10:38:19 +0000 (10:38 +0000)]
Split up TablePager css class, introduce .mw-datatable
* All tables generated with the TablePager PHP class use this css class for their styling. This visual look has since inspired several templates and other tables on the wikis and in extensions to present data with row-highlighting functionality. To make it easier to do that, separating the generic styling into a new css class "mw-datatable" and use it in the TablePager PHP class.
* Kept pager-specific "min-width" rule under .TablePager
* Other CSS classes for TablePager are also untouched
* Changed table-heading color slightly to not be exactly the same as the hover-style (design/usability)

12 years agoFollowup r95957, add =null to Skin::outputPage too
Daniel Friesen [Thu, 1 Sep 2011 10:35:12 +0000 (10:35 +0000)]
Followup r95957, add =null to Skin::outputPage too

12 years agoKill off use of $wgRequest, $wgUser, and $wgLang in SkinTemplate, stop using $out...
Daniel Friesen [Thu, 1 Sep 2011 10:24:35 +0000 (10:24 +0000)]
Kill off use of $wgRequest, $wgUser, and $wgLang in SkinTemplate, stop using $out args on our protected methods, deprecate the $out on outputPage and for now make it temporarily override the context of the skin (or should we throw a fatal if someone passes an OutputPage that doesn't match context)

12 years agoIn Title::resetArticleID(), clear all entries in the LinkCache instead of just the...
Roan Kattouw [Thu, 1 Sep 2011 09:23:20 +0000 (09:23 +0000)]
In Title::resetArticleID(), clear all entries in the LinkCache instead of just the ones for bad title stuff. resetArticleID() seemed to assume it was only called for titles that come into existance, but that's not correct: it's also called for titles that go out of existence, and titles whose redirect status changes. Noticed this because $nt->getRedirect()'s return value was wrong in my TitleMoveComplete hook.

12 years agoRevert r95830's change to external and interwiki link colors.
Daniel Friesen [Thu, 1 Sep 2011 09:10:01 +0000 (09:10 +0000)]
Revert r95830's change to external and interwiki link colors.

12 years agoFollowup r95947, undo accidental revert of r95946.
Daniel Friesen [Thu, 1 Sep 2011 08:34:29 +0000 (08:34 +0000)]
Followup r95947, undo accidental revert of r95946.

12 years agoFix indentation in r95396
Roan Kattouw [Thu, 1 Sep 2011 08:21:50 +0000 (08:21 +0000)]
Fix indentation in r95396

12 years agoAdd Title::isSubpageOf to use when you want to make tests like $title->isSubpageOf...
Daniel Friesen [Thu, 1 Sep 2011 07:49:37 +0000 (07:49 +0000)]
Add Title::isSubpageOf to use when you want to make tests like $title->isSubpageOf( $someUserpage );

12 years agof'up r95930: register new message key to maintenance script
Raimond Spekking [Thu, 1 Sep 2011 06:18:15 +0000 (06:18 +0000)]
f'up r95930: register new message key to maintenance script

12 years agoFollow-up r95930, consolidate into one message per CR
John Du Hart [Thu, 1 Sep 2011 04:26:21 +0000 (04:26 +0000)]
Follow-up r95930, consolidate into one message per CR

12 years ago(bug 5865) Warning on editing other user's userpage
John Du Hart [Thu, 1 Sep 2011 03:56:33 +0000 (03:56 +0000)]
(bug 5865) Warning on editing other user's userpage

12 years ago(bug 4381) Magic quotes cleaning is not comprehensive, key strings not unescaped
John Du Hart [Wed, 31 Aug 2011 23:15:16 +0000 (23:15 +0000)]
(bug 4381) Magic quotes cleaning is not comprehensive, key strings not unescaped

12 years agoLocalisation updates for core and extension messages from translatewiki.net
Raimond Spekking [Wed, 31 Aug 2011 20:28:36 +0000 (20:28 +0000)]
Localisation updates for core and extension messages from translatewiki.net

12 years agoRemoved AjaxFunctions from list (file was deleted)
Aaron Schulz [Wed, 31 Aug 2011 18:42:15 +0000 (18:42 +0000)]
Removed AjaxFunctions from list (file was deleted)

12 years agoFollowup r95002: unbreak getTokenUrl() by using a simpler hack that doesn't involve...
Roan Kattouw [Wed, 31 Aug 2011 18:08:13 +0000 (18:08 +0000)]
Followup r95002: unbreak getTokenUrl() by using a simpler hack that doesn't involve $wgArticlePath

12 years agoClean up and conventions in shared.css
Krinkle [Wed, 31 Aug 2011 15:18:58 +0000 (15:18 +0000)]
Clean up and conventions in shared.css
* Put rules and selectors on their own line consistently. Space is not an issue and is stripped automatically. Readability is what we need. Selectors line up nicely underneath achother.
* Expanded shorthand . notation to 0. where applicable
* Remove trailing spaces
* Fix double spaces to single spaces, and expand comment sections if needed (ie. one * per  line)
* Put @noflip's consistently on the line before the rule itself (just like we do for @embed). If it should apply to all rules in a selector, then @noflip must be before the { somewhere. There is no difference between @noflip before the rule on the same line or the line above (eg. /* noflip */ foo: bar; or /* noflip */ \n foo: bar;)

12 years agoFollowup r95396
Sam Reed [Wed, 31 Aug 2011 15:00:23 +0000 (15:00 +0000)]
Followup r95396

Swap $wgGlobalDB for $wgGlobalDatabase

12 years agoTidy up w/c
Sam Reed [Wed, 31 Aug 2011 14:47:08 +0000 (14:47 +0000)]
Tidy up w/c

Remove trailing whitespace, add some documentation

12 years agoFix Uncaught TypeError: Cannot call method 'substr' of undefined
Krinkle [Wed, 31 Aug 2011 14:37:37 +0000 (14:37 +0000)]
Fix Uncaught TypeError: Cannot call method 'substr' of undefined
* When changing the name of a category and saving it, this error is thrown from $.ucFirst. Although the script does check for it to be a string, what happens between that and ucFirst is broken. It should always set 'category' of splitresult[0], not just if there is a [1] (=sortkey). Otherwise, if there is no sortkey, 'category' is undefined.
* Also updated outdated comment saying that variable sortkey contains wikitext between "[[Category:Foo" and "]]" (which implies it includes the pipe, which is no longer true)

Follows-up r93351.

12 years agoClarify parameter description added in r95714
Roan Kattouw [Wed, 31 Aug 2011 14:30:18 +0000 (14:30 +0000)]
Clarify parameter description added in r95714

12 years agoFollowup r95753 per CR: prevent extensions from making isMovable() return true for...
Roan Kattouw [Wed, 31 Aug 2011 12:18:02 +0000 (12:18 +0000)]
Followup r95753 per CR: prevent extensions from making isMovable() return true for interwiki titles and immovable namespaces

12 years agoArgh, fixing my fix in r95834
Niklas Laxström [Wed, 31 Aug 2011 10:37:17 +0000 (10:37 +0000)]
Argh, fixing my fix in r95834

12 years agoFollowup r95837; Return the list-style-image for ul{} back to vector since I ended...
Daniel Friesen [Wed, 31 Aug 2011 07:03:52 +0000 (07:03 +0000)]
Followup r95837; Return the list-style-image for ul{} back to vector since I ended up deciding not to give the common stylesheet one of the two bullet points.

12 years agoRemove the basic styles that vector coppied from monobook from both monobook and...
Daniel Friesen [Wed, 31 Aug 2011 06:59:15 +0000 (06:59 +0000)]
Remove the basic styles that vector coppied from monobook from both monobook and vector and relocate them to a series of css stylesheets which 3rd party skins can include.
Havent touched Modern yet. External link icons are too complex to deal with this round due to vector and monobook using different icons.

12 years agoFollowup r95800 - the page is ListFiles
Niklas Laxström [Wed, 31 Aug 2011 05:43:53 +0000 (05:43 +0000)]
Followup r95800 - the page is ListFiles

12 years agoGive Vector a lighter external/interwiki color since monobook->vector changed the...
Daniel Friesen [Wed, 31 Aug 2011 04:19:14 +0000 (04:19 +0000)]
Give Vector a lighter external/interwiki color since monobook->vector changed the basic internal link color lighter making internal and interwiki links almost indistinguishable.

12 years agoAnother stupid newline, forgot to press save
Chad Horohoe [Tue, 30 Aug 2011 20:55:50 +0000 (20:55 +0000)]
Another stupid newline, forgot to press save

12 years agoFixes for r94158: newlines and minor debugging typo (more silly fixmes)
Chad Horohoe [Tue, 30 Aug 2011 20:55:29 +0000 (20:55 +0000)]
Fixes for r94158: newlines and minor debugging typo (more silly fixmes)

12 years agoPrefix extensions with $IP. Followup r94107 (grumble grumble about people fixmeing...
Chad Horohoe [Tue, 30 Aug 2011 20:53:26 +0000 (20:53 +0000)]
Prefix extensions with $IP. Followup r94107 (grumble grumble about people fixmeing rather than doing the 4 character fix themselves...)

12 years agoRemove wfDie() that Ariel keeps trying to resurrect :)
Chad Horohoe [Tue, 30 Aug 2011 20:45:36 +0000 (20:45 +0000)]
Remove wfDie() that Ariel keeps trying to resurrect :)

12 years agoRemove evil @
Chad Horohoe [Tue, 30 Aug 2011 20:44:33 +0000 (20:44 +0000)]
Remove evil @

12 years agoLocalisation updates for core and extension messages from translatewiki.net
Raimond Spekking [Tue, 30 Aug 2011 19:49:07 +0000 (19:49 +0000)]
Localisation updates for core and extension messages from translatewiki.net

12 years ago* Use local context instead of global variables
Alexandre Emsenhuber [Tue, 30 Aug 2011 18:37:19 +0000 (18:37 +0000)]
* Use local context instead of global variables
* Call Linker methods statically

12 years agoLink content pages and uploaded files to AllPages and FileList respectively
Robin Pepermans [Tue, 30 Aug 2011 18:13:20 +0000 (18:13 +0000)]
Link content pages and uploaded files to AllPages and FileList respectively

12 years agoAmend r95775 per Siebrand's suggestion
Niklas Laxström [Tue, 30 Aug 2011 13:59:54 +0000 (13:59 +0000)]
Amend r95775 per Siebrand's suggestion

12 years agoHandle bad input gracefully in getFallback(s)For
Niklas Laxström [Tue, 30 Aug 2011 13:25:16 +0000 (13:25 +0000)]
Handle bad input gracefully in getFallback(s)For

12 years agoNew hook to replace live hack on translatewiki.net. Allows reordering namespaces
Niklas Laxström [Tue, 30 Aug 2011 13:24:27 +0000 (13:24 +0000)]
New hook to replace live hack on translatewiki.net. Allows reordering namespaces

12 years agoRemoved unused global declaration of $wgMessageCache (!)
Alexandre Emsenhuber [Tue, 30 Aug 2011 12:24:12 +0000 (12:24 +0000)]
Removed unused global declaration of $wgMessageCache (!)

12 years agoFix a message key typo in r41961 (!!), which didn't matter before because the relevan...
Roan Kattouw [Tue, 30 Aug 2011 11:39:43 +0000 (11:39 +0000)]
Fix a message key typo in r41961 (!!), which didn't matter before because the relevant code (and the message) wasn't reachable.

12 years agoAdd TitleIsMovable hook so extensions can create new namespaces in which pages can...
Roan Kattouw [Tue, 30 Aug 2011 11:21:24 +0000 (11:21 +0000)]
Add TitleIsMovable hook so extensions can create new namespaces in which pages can't be moved. RL2 needs this for the Gadgets_definition namespace

12 years agoMake file names match module names.
Krinkle [Mon, 29 Aug 2011 23:36:48 +0000 (23:36 +0000)]
Make file names match module names.
* See [[Coding conventions#File naming]]
* This pretty much undos r94325.

12 years agocheck the checkpoint related options only if we specified checkpoints, duh
Ariel Glenn [Mon, 29 Aug 2011 22:48:18 +0000 (22:48 +0000)]
check the checkpoint related options only if we specified checkpoints, duh

12 years agoAdd support to only return keys in ApiAllMessages
Krinkle [Mon, 29 Aug 2011 22:21:32 +0000 (22:21 +0000)]
Add support to only return keys in ApiAllMessages
* Applying patch from bug 30591

12 years agoKill off the last $wgUser and improper use of linker by skin in OutputPage.
Daniel Friesen [Mon, 29 Aug 2011 21:48:51 +0000 (21:48 +0000)]
Kill off the last $wgUser and improper use of linker by skin in OutputPage.

12 years agoLocalisation updates for core and extension messages from translatewiki.net
Raimond Spekking [Mon, 29 Aug 2011 20:32:44 +0000 (20:32 +0000)]
Localisation updates for core and extension messages from translatewiki.net

12 years agoFollowup r95547; Where'd that $ come from?
Daniel Friesen [Mon, 29 Aug 2011 18:53:59 +0000 (18:53 +0000)]
Followup r95547; Where'd that $ come from?

12 years agoResourceLoaderUserOptionsModule.php: Add comment about options['underline']
Krinkle [Mon, 29 Aug 2011 16:12:17 +0000 (16:12 +0000)]
ResourceLoaderUserOptionsModule.php: Add comment about options['underline']

12 years agoTypofix
Chad Horohoe [Mon, 29 Aug 2011 15:45:54 +0000 (15:45 +0000)]
Typofix

12 years ago* (bug 16428) Include permalink in printable version
Raimond Spekking [Mon, 29 Aug 2011 10:47:44 +0000 (10:47 +0000)]
* (bug 16428) Include permalink in printable version

12 years agoUse local context instead of global variables
Alexandre Emsenhuber [Mon, 29 Aug 2011 09:44:02 +0000 (09:44 +0000)]
Use local context instead of global variables

12 years agoIn WikiMap, pull wgCanonicalServer from $wgConf instead of wgServer for building...
Roan Kattouw [Mon, 29 Aug 2011 08:55:35 +0000 (08:55 +0000)]
In WikiMap, pull wgCanonicalServer from $wgConf instead of wgServer for building URLs to foreign wikis. This means wgCanonicalServer is now expected to always be available in wgConf; document this in RELEASE-NOTES (-1.18 because this is for backporting).

12 years agoFurther updates for r90643/r95647 in core and extensions. Fixed all callers of Databa...
Tim Starling [Mon, 29 Aug 2011 05:04:55 +0000 (05:04 +0000)]
Further updates for r90643/r95647 in core and extensions. Fixed all callers of Database::getLag(), made them call a new function LoadBalancer::safeGetLag() instead, which doesn't cause fatal errors for non-replicated installations. The core updates are tested but the extension updates aren't.

12 years ago* Fix for r90643: in the case where there is only one server, implying no replication...
Tim Starling [Mon, 29 Aug 2011 04:42:26 +0000 (04:42 +0000)]
* Fix for r90643: in the case where there is only one server, implying no replication, make LoadBalancer::getLagTimes(), LoadMonitor_MySQL::getLagTimes() and LoadBalancer::getMaxLag() quickly report zero lag without attempting to do a SHOW SLAVE STATUS query.
* Updated the documentation to make it clear that REPLICATION CLIENT is required in a replicated setup.
* Reverted r90773.

12 years agoIn Language::isValidBuiltInCode(), reject the empty string per Nikerabbit's request...
Tim Starling [Mon, 29 Aug 2011 04:01:40 +0000 (04:01 +0000)]
In Language::isValidBuiltInCode(), reject the empty string per Nikerabbit's request on CR r82927. I'm not sure what the reason for the request was, but I suppose an empty language code could result in the base Language class being used, which could be problematic for some caller. It doesn't do any harm to reject it here.

12 years agoAdd html5 microdata's itemscope to the list of boolean attributes.
Daniel Friesen [Sun, 28 Aug 2011 23:03:19 +0000 (23:03 +0000)]
Add html5 microdata's itemscope to the list of boolean attributes.

12 years agoAs suggested to me by email: very active members of a wiki community can end up recei...
Happy-melon [Sun, 28 Aug 2011 22:51:31 +0000 (22:51 +0000)]
As suggested to me by email: very active members of a wiki community can end up receiving hundreds of emails via Special:EmailUser, the majority of which will end up with the boilerplate "{{SITENAME}} email" subject, making them hard to distinguish.  Pass the name of the user sending the email to the message, so that it can be at least a little bit more unique.

12 years agomediawiki.test: Fix mw.config interaction with wgScriptPath
Krinkle [Sun, 28 Aug 2011 22:04:49 +0000 (22:04 +0000)]
mediawiki.test: Fix mw.config interaction with wgScriptPath
* Previously the the load test in mediawiki.test.js failed when ran within a wiki because the regex to extract the path from window.location doesn't know take in account stuff like wiki-pagenames (which can contain slashes in the title) or action paths and what not.

Changes:
* Use wgScriptPath from mw.config when available in the mediawiki.test.js (instead of the regexed window.location)
* To make sure the test still works in the static /qunit/index.html (where wgScriptPath is obviously not defined by php), re-introduced the removed regex extration hack. This also allows other modules to use wgScriptPath and removes the hack from the test suite to where it is needed and keeps the test module clean. When the on-wiki testrunner is ready and added to core, /qunit/index.html can be nuked all together including this hack. Now the hack is at least part of what-is-to-be-removed.
* Added save/restore for manipulated mw.config vars in mediawiki.util.test.js (to avoid it from messing up the real wgScriptPath for other tests)
* Fixed load path to 'data/' in testrunner.js as well

12 years agomove some member vars to parent class since they are needed there now, set lastTime...
Ariel Glenn [Sun, 28 Aug 2011 19:06:52 +0000 (19:06 +0000)]
move some member vars to parent class since they are needed there now, set lastTime and other vars so checkpoints without prefetch work, update progress reporting in parent class to give rates during interval and from start of run

12 years agoFix bug in r94995: getCanonicalUrl() doesn't append the fragment. This is correct...
Roan Kattouw [Sun, 28 Aug 2011 15:15:42 +0000 (15:15 +0000)]
Fix bug in r94995: getCanonicalUrl() doesn't append the fragment. This is correct behavior for getInternalUrl() (which the code was based on) but not for getFullUrl() (which is what I'm swapping getCanonicalUrl() in for in certain places). Was exposed by a unit test in CodeReview breaking on me when I tried to use canonical URLs in e-mail notifications.

12 years agothis commit reverts my r95596 because that patch for a new right 'resetpassword'...
Thomas Gries [Sun, 28 Aug 2011 06:53:18 +0000 (06:53 +0000)]
this commit reverts my r95596 because that patch for a new right 'resetpassword' raised more question than it solved problems

12 years agoFix autoloader entry from r90929
Max Semenik [Sun, 28 Aug 2011 05:59:36 +0000 (05:59 +0000)]
Fix autoloader entry from r90929

12 years agoProperly mark the language and direction of the readonly textarea
Robin Pepermans [Sat, 27 Aug 2011 21:46:39 +0000 (21:46 +0000)]
Properly mark the language and direction of the readonly textarea

12 years agoManually set the title as not being a redirect. Otherwise,
Platonides [Sat, 27 Aug 2011 21:10:41 +0000 (21:10 +0000)]
Manually set the title as not being a redirect. Otherwise,
it needed a database from Parser::getFunctionLang() ->
Title::getPageLanguage() -> Title::isRedirect()

12 years agoPer Nikerabbit, fix for r92231: this was the wrong object
Alexandre Emsenhuber [Sat, 27 Aug 2011 20:59:28 +0000 (20:59 +0000)]
Per Nikerabbit, fix for r92231: this was the wrong object

12 years agoLocalisation updates for core and extension messages from translatewiki.net
Raimond Spekking [Sat, 27 Aug 2011 19:09:42 +0000 (19:09 +0000)]
Localisation updates for core and extension messages from translatewiki.net

12 years agodefine and use closeAndRename() after last write of xml dump file; convert from popen...
Ariel Glenn [Sat, 27 Aug 2011 18:31:03 +0000 (18:31 +0000)]
define and use closeAndRename() after last write of xml dump file; convert from popen (child inherits all open descriptors and there is no workaround) to proc_open (CLOEXEC set on all descriptors), needed so close and rename doesn't hang forever if a child (prefetcher) is forked

12 years agoUnused variables.
Platonides [Sat, 27 Aug 2011 18:28:04 +0000 (18:28 +0000)]
Unused variables.
$wgContLang in CategoryPage was probably removed with the better directionality improvements.
$wgServer, $wgRequest in getFullUrl() unused since r94375
Other variables added in r95396 iwtransclusion merge.

12 years agoreplace WfDie()
Ariel Glenn [Sat, 27 Aug 2011 15:50:17 +0000 (15:50 +0000)]
replace WfDie()

12 years agoRemove a message for a feature introduced with r47569 and reverted with r48780.
Raimond Spekking [Sat, 27 Aug 2011 11:01:51 +0000 (11:01 +0000)]
Remove a message for a feature introduced with r47569 and reverted with r48780.

12 years agoPatch to make SpecialPasswordReset only available to groups
Thomas Gries [Sat, 27 Aug 2011 10:11:51 +0000 (10:11 +0000)]
Patch to make SpecialPasswordReset only available to groups
with a new minimum right 'resetpassword'. Default group: '*'. Description: wikitech-l http://article.gmane.org/gmane.science.linguistics.wikipedia.technical/55055 'Reclaiming a lost account on a private wiki: impossible'

12 years agofu r95396 Fix function name
Raimond Spekking [Sat, 27 Aug 2011 08:26:08 +0000 (08:26 +0000)]
fu r95396 Fix function name

12 years agoI was trying to be witty, and I made a typo :( (FollowUp r95589)
Chad Horohoe [Sat, 27 Aug 2011 01:28:08 +0000 (01:28 +0000)]
I was trying to be witty, and I made a typo :( (FollowUp r95589)

12 years agoAdd warning to class header.
Chad Horohoe [Sat, 27 Aug 2011 01:24:31 +0000 (01:24 +0000)]
Add warning to class header.

12 years agoUploadFromStash::stashSession returned an object instead of a file key, which broke...
Ian Baker [Fri, 26 Aug 2011 23:17:43 +0000 (23:17 +0000)]
UploadFromStash::stashSession returned an object instead of a file key, which broke stashing in SpecialUpload in some cases.

Fixes bug 30505

12 years agoAPI get functions should be public
John Du Hart [Fri, 26 Aug 2011 22:56:31 +0000 (22:56 +0000)]
API get functions should be public

12 years agomediawiki.util.test: Change portlet name to not conflict with core
Krinkle [Fri, 26 Aug 2011 19:46:31 +0000 (19:46 +0000)]
mediawiki.util.test: Change portlet name to not conflict with core
* When running the tests inside a wiki page, the added portletlinks are invisible to the selector since only 1 element can have the same id.s

12 years agoFix r95446
Sam Reed [Fri, 26 Aug 2011 17:42:25 +0000 (17:42 +0000)]
Fix r95446

12 years agoUpdating jquery.qunit from upstream
Krinkle [Fri, 26 Aug 2011 17:11:31 +0000 (17:11 +0000)]
Updating jquery.qunit from upstream
* Source: https://github.com/jquery/qunit/tree/7f292170fa1109f1355f3e96f8973c32fc553946
* qunit.css unchanged
* In the mean time the pull request I sent has been merged in as well ( https://github.com/jquery/qunit/commit/d2978f4afc75da784c6145fc74c051858ef3c39b ), so we can extend the checkbox-toggles with (for example) the completenesstest.

12 years ago(bug 29246) Edit API occasionally throws "unknown error 231". Per comment #1 on the...
Roan Kattouw [Fri, 26 Aug 2011 16:26:17 +0000 (16:26 +0000)]
(bug 29246) Edit API occasionally throws "unknown error 231". Per comment #1 on the bug and a comment in ApiEditPage, I refactored internalAttemptSave() to return a status object. However, there are so many idiosyncracies wrt how EditPage handles various errors that I decided to put the AS_* error code in $status->value (thanks Chad for that tip) and use that to decide what to do (not part of Chad's tip). The resulting code is still a mess but at least Status objects from doEdit() are propagated now, and it'll be a little bit easier to migrate internalAttemptSave() to a proper Status-based architecture in the future. Or maybe we should just throw away EditPage and start with a blank screen, that sounds appealing to me :)

12 years agoFix another remnant of r95496
Sam Reed [Fri, 26 Aug 2011 11:15:07 +0000 (11:15 +0000)]
Fix another remnant of r95496

12 years agoFollowup r93417; Don't use $wgServer in a way that makes invalid Message-IDs. Instead...
Daniel Friesen [Fri, 26 Aug 2011 00:01:55 +0000 (00:01 +0000)]
Followup r93417; Don't use $wgServer in a way that makes invalid Message-IDs. Instead use IDHost if set, otherwise extract the host from $wgServer. Also instead of a static UserMailer prefix use the wiki's id.

12 years agoFux PHP Notice: Undefined property: ContribsPager::$showSizeDiff in /www/w/includes...
Sam Reed [Thu, 25 Aug 2011 21:22:14 +0000 (21:22 +0000)]
Fux PHP Notice: Undefined property: ContribsPager::$showSizeDiff in /www/w/includes/specials/SpecialContributions.php on line 681 frin r95496

12 years agoUndo r85392 ('revert' is a strong word since a lot has changed in the intervening...
Happy-melon [Thu, 25 Aug 2011 21:03:52 +0000 (21:03 +0000)]
Undo r85392 ('revert' is a strong word since a lot has changed in the intervening ten thousand revisions, but the effect is the same).

12 years agoLocalisation updates for core and extension messages from translatewiki.net
Raimond Spekking [Thu, 25 Aug 2011 20:41:28 +0000 (20:41 +0000)]
Localisation updates for core and extension messages from translatewiki.net

12 years agofu r95496: remove the messages really
Raimond Spekking [Thu, 25 Aug 2011 19:44:32 +0000 (19:44 +0000)]
fu r95496: remove the messages really

12 years agoFix fail double pasting from r95497
Sam Reed [Thu, 25 Aug 2011 17:48:55 +0000 (17:48 +0000)]
Fix fail double pasting from r95497

12 years agoFollowup r95449, fix the code to do what it was actually intended to do
Sam Reed [Thu, 25 Aug 2011 17:47:33 +0000 (17:47 +0000)]
Followup r95449, fix the code to do what it was actually intended to do

12 years agoRevert r8811
Sam Reed [Thu, 25 Aug 2011 17:35:07 +0000 (17:35 +0000)]
Revert r8811

Reverting followups r88117, 88252

12 years agoFollowup r90361, r90362
Sam Reed [Thu, 25 Aug 2011 16:40:49 +0000 (16:40 +0000)]
Followup r90361, r90362

Document $limit parameter

Pass $limit parameter through if $limit && php > 5.4.0

Else false back to the default version, which sets the same parameters

12 years agoWhitespace and formatting updates.
Siebrand Mazeland [Thu, 25 Aug 2011 14:45:38 +0000 (14:45 +0000)]
Whitespace and formatting updates.

12 years agoLocalization update for he.
Rotem Liss [Thu, 25 Aug 2011 11:59:34 +0000 (11:59 +0000)]
Localization update for he.

12 years agoFix stupid copypaste mistake in r95470
Roan Kattouw [Thu, 25 Aug 2011 10:56:46 +0000 (10:56 +0000)]
Fix stupid copypaste mistake in r95470

12 years agoActually do r95462 as intended
Sam Reed [Thu, 25 Aug 2011 10:47:13 +0000 (10:47 +0000)]
Actually do r95462 as intended

r95396

12 years ago(bug 30504) Core namespaces for Pali (pi).
Siebrand Mazeland [Thu, 25 Aug 2011 10:29:29 +0000 (10:29 +0000)]
(bug 30504) Core namespaces for Pali (pi).