From: Roan Kattouw <roan.kattouw@gmail.com>
Date: Sat, 16 Feb 2019 01:00:49 +0000 (-0800)
Subject: ChangeTags: Deprecate ChangeTags::purgeTagUsageCache()
X-Git-Tag: 1.34.0-rc.0~2810
X-Git-Url: http://git.heureux-cyclage.org/?a=commitdiff_plain;h=e0213bda23bcefc1bc2da0277a038a43a4b2a99a;p=lhc%2Fweb%2Fwiklou.git

ChangeTags: Deprecate ChangeTags::purgeTagUsageCache()

The cache key that it purges is no longer used anywhere.

Change-Id: I2c255936451cde09579594cc4524c8fe38cf3e7c
---

diff --git a/RELEASE-NOTES-1.33 b/RELEASE-NOTES-1.33
index 0cee392223..ac06d63ef8 100644
--- a/RELEASE-NOTES-1.33
+++ b/RELEASE-NOTES-1.33
@@ -293,6 +293,8 @@ because of Phabricator reports.
 * The mw.language.specialCharacters property from the
   'mediawiki.language.specialCharacters' module has been deprecated.
   Use require( 'mediawiki.language.specialCharacters' ) instead.
+* ChangeTags::purgeTagUsageCache() has been deprecated, and is expected to be
+  removed in a future release.
 
 === Other changes in 1.33 ===
 * (T201747) Html::openElement() warns if given an element name with a space
diff --git a/includes/changetags/ChangeTags.php b/includes/changetags/ChangeTags.php
index a1cf468e6b..66a816595f 100644
--- a/includes/changetags/ChangeTags.php
+++ b/includes/changetags/ChangeTags.php
@@ -420,8 +420,6 @@ class ChangeTags {
 			}
 		}
 
-		self::purgeTagUsageCache();
-
 		Hooks::run( 'ChangeTagsAfterUpdateTags', [ $tagsToAdd, $tagsToRemove, $prevTags,
 			$rc_id, $rev_id, $log_id, $params, $rc, $user ] );
 
@@ -1456,18 +1454,15 @@ class ChangeTags {
 		$cache->touchCheckKey( $cache->makeKey( 'valid-tags-hook' ) );
 
 		MediaWikiServices::getInstance()->getChangeTagDefStore()->reloadMap();
-
-		self::purgeTagUsageCache();
 	}
 
 	/**
 	 * Invalidates the tag statistics cache only.
 	 * @since 1.25
+	 * @deprecated since 1.33 the cache this purges no longer exists
 	 */
 	public static function purgeTagUsageCache() {
-		$cache = MediaWikiServices::getInstance()->getMainWANObjectCache();
-
-		$cache->touchCheckKey( $cache->makeKey( 'change-tag-statistics' ) );
+		wfDeprecated( __METHOD__, '1.33' );
 	}
 
 	/**