From: James D. Forrester <jforrester@wikimedia.org>
Date: Sat, 9 Feb 2019 01:41:28 +0000 (-0800)
Subject: Drop SessionManager::autoCreateUser(), deprecated in 1.27 and unused
X-Git-Tag: 1.34.0-rc.0~2871^2~2
X-Git-Url: http://git.heureux-cyclage.org/?a=commitdiff_plain;h=5370286bd368b8aadf97c133cc03520746900388;p=lhc%2Fweb%2Fwiklou.git

Drop SessionManager::autoCreateUser(), deprecated in 1.27 and unused

Depends-On: I261ea755c1d273ccc7fcc7c3b041623ccf4e331b
Change-Id: Ice2d755bee694b97e5ddbfc72caddf2b87ba0fc9
---

diff --git a/RELEASE-NOTES-1.33 b/RELEASE-NOTES-1.33
index 35c70c8169..b2de154347 100644
--- a/RELEASE-NOTES-1.33
+++ b/RELEASE-NOTES-1.33
@@ -231,6 +231,8 @@ because of Phabricator reports.
 * Backwards compatibility for setting wgSessionsInObjectCache to false or using
   wgSessionHandler, both of which were deprecated in 1.27 with the introduction
   of SessionManager, has been removed.
+* SessionManager::autoCreateUser, deprecated in 1.27, has been removed. Use
+  MediaWiki\Auth\AuthManager::autoCreateUser instead.
 
 === Deprecations in 1.33 ===
 * The configuration option $wgUseESI has been deprecated, and is expected
diff --git a/includes/session/SessionManager.php b/includes/session/SessionManager.php
index ceb9ceb5c7..385cc35d76 100644
--- a/includes/session/SessionManager.php
+++ b/includes/session/SessionManager.php
@@ -377,23 +377,6 @@ final class SessionManager implements SessionManagerInterface {
 	 * @{
 	 */
 
-	/**
-	 * Auto-create the given user, if necessary
-	 * @private Don't call this yourself. Let Setup.php do it for you at the right time.
-	 * @deprecated since 1.27, use MediaWiki\Auth\AuthManager::autoCreateUser instead
-	 * @param User $user User to auto-create
-	 * @return bool Success
-	 * @codeCoverageIgnore
-	 */
-	public static function autoCreateUser( User $user ) {
-		wfDeprecated( __METHOD__, '1.27' );
-		return \MediaWiki\Auth\AuthManager::singleton()->autoCreateUser(
-			$user,
-			\MediaWiki\Auth\AuthManager::AUTOCREATE_SOURCE_SESSION,
-			false
-		)->isGood();
-	}
-
 	/**
 	 * Prevent future sessions for the user
 	 *