From: This, that and the other <at.light@live.com.au>
Date: Sat, 30 Aug 2014 05:18:46 +0000 (+1000)
Subject: Don't auto-select first alphabetical item in import subproject list
X-Git-Tag: 1.31.0-rc.0~12702
X-Git-Url: http://git.heureux-cyclage.org/?a=commitdiff_plain;h=39b578f1e095325d0b6867fa427244c8da96a848;p=lhc%2Fweb%2Fwiklou.git

Don't auto-select first alphabetical item in import subproject list

Currently when you load Special:Import, the first subproject in
alphabetical order gets selected. Instead, the first subproject in the
list should be selected by default (i.e. no <option> element should be
given the "selected" attribute).

Change-Id: I442a9afadc75f42f63d8c9c32ee2920374ceb26d
---

diff --git a/resources/src/mediawiki.special/mediawiki.special.import.js b/resources/src/mediawiki.special/mediawiki.special.import.js
index a9a985ebd4..5622b32a38 100644
--- a/resources/src/mediawiki.special/mediawiki.special.import.js
+++ b/resources/src/mediawiki.special/mediawiki.special.import.js
@@ -2,7 +2,7 @@
  * JavaScript for Special:Import
  */
 ( function ( $ ) {
-	function updateImportSubprojectList() {
+	function updateImportSubprojectList( firstTime ) {
 		var $projectField = $( '#mw-import-table-interwiki #interwiki' ),
 			$subprojectField = $projectField.parent().find( '#subproject' ),
 			$selected = $projectField.find( ':selected' ),
@@ -14,7 +14,7 @@
 				option = document.createElement( 'option' );
 				option.appendChild( document.createTextNode( el ) );
 				option.setAttribute( 'value', el );
-				if ( oldValue === el ) {
+				if ( oldValue === el && firstTime !== true ) {
 					option.setAttribute( 'selected', 'selected' );
 				}
 				return option;
@@ -29,7 +29,7 @@
 		var $projectField = $( '#mw-import-table-interwiki #interwiki' );
 		if ( $projectField.length ) {
 			$projectField.change( updateImportSubprojectList );
-			updateImportSubprojectList();
+			updateImportSubprojectList( true );
 		}
 	} );
 }( jQuery ) );