parser: use "-" for revision ID for non-preview edit filter parse during save
authorAaron Schulz <aschulz@wikimedia.org>
Sat, 13 Apr 2019 23:43:06 +0000 (16:43 -0700)
committerAaron Schulz <aschulz@wikimedia.org>
Sat, 13 Apr 2019 23:43:06 +0000 (16:43 -0700)
This avoids a double parse when the edit stash is not used,
which can be confirmed via the SaveParse log for a page
using {{REVISIONID}} when edit stashing is disabled. This
now matches the reuse for the edit stash hit case.

Change-Id: I405c39d4d7ac04e39fbdfe400f73238b734c7833

includes/parser/Parser.php

index 91de550..c28d842 100644 (file)
@@ -2607,7 +2607,7 @@ class Parser {
                        // @TODO: disallow this word on all namespaces
                        $this->nsInfo->isContent( $this->mTitle->getNamespace() )
                ) {
-                       if ( $this->mRevisionId ) {
+                       if ( $this->mRevisionId || $this->mOptions->getSpeculativeRevId() ) {
                                return '-';
                        } else {
                                $this->mOutput->setFlag( 'vary-revision-exists' );