Skin::newFromKey() was removed

Deprecated since 1.24. No uses in core or Gerrit extensions remaining.

Change-Id: If5d18ec56a066ea3ab28503b1bf5a84a8588ba5a

diff --git a/RELEASE-NOTES-1.27 b/RELEASE-NOTES-1.27
index d91af42..c6da46f 100644 (file)
--- a/RELEASE-NOTES-1.27
+++ b/RELEASE-NOTES-1.27
@@ -393,6 +393,7 @@ changes to languages because of Phabricator reports.
 * Title::newFromRedirect() was removed (deprecated since 1.21).
 * Skin::commonPrintStylesheet() was removed (deprecated since 1.22).
 * Skin::getCommonStylePath() was removed (deprecated since 1.24).
+* Skin::newFromKey() was removed (deprecated since 1.24).
 
 == Compatibility ==
 

diff --git a/includes/skins/Skin.php b/includes/skins/Skin.php
index 17f5fa4..a225711 100644 (file)
--- a/includes/skins/Skin.php
+++ b/includes/skins/Skin.php
@@ -140,23 +140,6 @@ abstract class Skin extends ContextSource {
                }
        }
 
-       /**
-        * Factory method for loading a skin of a given type
-        * @param string $key 'monobook', 'vector', etc.
-        * @return Skin
-        * @deprecated since 1.24; Use SkinFactory instead
-        */
-       static function &newFromKey( $key ) {
-               wfDeprecated( __METHOD__, '1.24' );
-
-               $key = Skin::normalizeKey( $key );
-               $factory = SkinFactory::getDefaultInstance();
-
-               // normalizeKey() guarantees that a skin with this key will exist.
-               $skin = $factory->makeSkin( $key );
-               return $skin;
-       }
-
        /**
         * @return string Skin name
         */