Remove warning for unnused 4th argument on wikidiff2
authorWMDE-Fisch <christoph.jauera@wikimedia.de>
Fri, 5 Apr 2019 16:23:49 +0000 (18:23 +0200)
committerWMDE-Fisch <christoph.jauera@wikimedia.de>
Fri, 5 Apr 2019 16:27:15 +0000 (18:27 +0200)
Since we changed the signature back to 3 arguments in wikidiff2 verion
1.8.0, the warning is invalid.

Bug: T220217
Bug: T203069
Bug: T194272
Change-Id: Ia326c67de28a4e9b024466c62097b4e1e1096007

includes/diff/TextSlotDiffRenderer.php

index e2cdd82..001944c 100644 (file)
@@ -214,12 +214,6 @@ class TextSlotDiffRenderer extends SlotDiffRenderer {
                                        $newText,
                                        2
                                );
-
-                               // Log a warning in case the configuration value is set to not silently ignore it
-                               if ( $this->wikiDiff2MovedParagraphDetectionCutoff > 0 ) {
-                                       wfLogWarning( '$wgWikiDiff2MovedParagraphDetectionCutoff is set but has no
-                                               effect since the used version of WikiDiff2 does not support it.' );
-                               }
                        }
 
                        return $text;