Fixed backwards $group check in LoadBalancer
authorAaron Schulz <aschulz@wikimedia.org>
Wed, 18 Feb 2015 01:28:20 +0000 (17:28 -0800)
committerAaron Schulz <aschulz@wikimedia.org>
Wed, 18 Feb 2015 01:32:10 +0000 (01:32 +0000)
* Fixes 9190427

bug: T89507
Change-Id: I192ac3b00160c85e22e18d69cea5d9c46d2a301a

includes/db/LoadBalancer.php

index 4c9fd32..f357880 100644 (file)
@@ -328,7 +328,7 @@ class LoadBalancer {
                                        $this->mServers[$i]['slave pos'] = $conn->getSlavePos();
                                }
                        }
-                       if ( $this->mReadIndex <= 0 && $this->mLoads[$i] > 0 && $group !== false ) {
+                       if ( $this->mReadIndex <= 0 && $this->mLoads[$i] > 0 && $group === false ) {
                                $this->mReadIndex = $i;
                        }
                }
@@ -477,7 +477,7 @@ class LoadBalancer {
                                $groupIndex = $this->getReaderIndex( $group, $wiki );
                                if ( $groupIndex !== false ) {
                                        $serverName = $this->getServerName( $groupIndex );
-                                       wfDebug( __METHOD__ . ": using server $serverName for group $group\n" );
+                                       wfDebug( __METHOD__ . ": using server $serverName for group '$group'\n" );
                                        $i = $groupIndex;
                                        break;
                                }