Merge "Unroll array_map in ResourceLoaderFileModule::readStyleFiles"
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Wed, 19 Feb 2014 19:20:50 +0000 (19:20 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Wed, 19 Feb 2014 19:20:50 +0000 (19:20 +0000)
includes/resourceloader/ResourceLoaderFileModule.php

index eaff86f..23d5825 100644 (file)
@@ -674,6 +674,7 @@ class ResourceLoaderFileModule extends ResourceLoaderModule {
         *
         * @param bool $flip
         *
+        * @throws MWException
         * @return array: List of concatenated and remapped CSS data from $styles,
         *     keyed by media type
         */
@@ -683,14 +684,11 @@ class ResourceLoaderFileModule extends ResourceLoaderModule {
                }
                foreach ( $styles as $media => $files ) {
                        $uniqueFiles = array_unique( $files );
-                       $styles[$media] = implode(
-                               "\n",
-                               array_map(
-                                       array( $this, 'readStyleFile' ),
-                                       $uniqueFiles,
-                                       array_fill( 0, count( $uniqueFiles ), $flip )
-                               )
-                       );
+                       $styleFiles = array();
+                       foreach ( $uniqueFiles as $file ) {
+                               $styleFiles[] = $this->readStyleFile( $file, $flip );
+                       }
+                       $styles[$media] = implode( "\n", $styleFiles );
                }
                return $styles;
        }