Throw exception on invalid RecentChange types
authorSiebrand Mazeland <s.mazeland@xs4all.nl>
Mon, 30 Dec 2013 17:37:51 +0000 (18:37 +0100)
committerSiebrand <siebrand@wikimedia.org>
Thu, 2 Jan 2014 22:36:47 +0000 (22:36 +0000)
Change-Id: I39279a13a2eb5891991e1c3b4bee0fafe844f1f2

includes/api/ApiQueryRecentChanges.php
includes/api/ApiQueryWatchlist.php

index 02a05e8..b298003 100644 (file)
@@ -559,6 +559,7 @@ class ApiQueryRecentChanges extends ApiQueryGeneratorBase {
 
                        return $retval;
                }
+
                switch ( $type ) {
                        case 'edit':
                                return RC_EDIT;
@@ -568,6 +569,8 @@ class ApiQueryRecentChanges extends ApiQueryGeneratorBase {
                                return RC_LOG;
                        case 'external':
                                return RC_EXTERNAL;
+                       default:
+                               ApiBase::dieDebug( __METHOD__, "Unknown type '$type'" );
                }
        }
 
index f8e521f..3465e48 100644 (file)
@@ -374,6 +374,7 @@ class ApiQueryWatchlist extends ApiQueryGeneratorBase {
 
                        return $retval;
                }
+
                switch ( $type ) {
                        case 'edit':
                                return RC_EDIT;
@@ -383,6 +384,8 @@ class ApiQueryWatchlist extends ApiQueryGeneratorBase {
                                return RC_LOG;
                        case 'external':
                                return RC_EXTERNAL;
+                       default:
+                               ApiBase::dieDebug( __METHOD__, "Unknown type '$type'" );
                }
        }