Follow-up: If985b16c – Vector external link change release notes

Also strengthen the CSS selector and remove a FIXME that it fixed.

Bug: 54604
Change-Id: I84765c536ade4087d8d3d9753966a443e49b2c38

diff --git a/RELEASE-NOTES-1.23 b/RELEASE-NOTES-1.23
index 44469cb..244cce7 100644 (file)
--- a/RELEASE-NOTES-1.23
+++ b/RELEASE-NOTES-1.23
@@ -138,6 +138,9 @@ production.
   installer has been updated to use it.
 * Changes to content typography (fonts, line-height, etc.). See
   https://www.mediawiki.org/wiki/Typography_refresh for further information.
+* The Vector skin's visual treatment of external links has been simplified to a
+  single icon (from nine). This should not affect local rules unless they were
+  re-using these icons, which have now been deleted.
 * ResourceLoader: mw.loader.using() now implements a Promise interface.
 * Add new hook ChangesListInitRows accessed via ChangesList::initChangesListRows.
   If called by the ChangesList consumer this gives extensions a chance to batch

diff --git a/skins/vector/components/externalLinks.less b/skins/vector/components/externalLinks.less
index 60792d5..91388c6 100644 (file)
--- a/skins/vector/components/externalLinks.less
+++ b/skins/vector/components/externalLinks.less
@@ -1,9 +1,10 @@
-// FIXME: This size of this CSS is ridiculous. Please refactor (see bug 54604)
 @import "mediawiki.mixins.less";
 // External links
-.external {
-       background-position: center right;
-       background-repeat: no-repeat;
-       .background-image-svg('images/external-link-ltr-icon.svg', 'images/external-link-ltr-icon.png' );
-       padding-right: 13px;
+#content {
+       .external {
+               background-position: center right;
+               background-repeat: no-repeat;
+               .background-image-svg('images/external-link-ltr-icon.svg', 'images/external-link-ltr-icon.png');
+               padding-right: 13px;
+       }
 }