Set title for Linker::revComment on Special:NewPages
authorumherirrender <umherirrender_de.wp@web.de>
Sat, 26 May 2012 19:10:52 +0000 (21:10 +0200)
committerumherirrender <umherirrender_de.wp@web.de>
Sat, 26 May 2012 19:10:52 +0000 (21:10 +0200)
When Linker::revComment gets the title from the revision object, he can
produce section links for autocomments
This will also avoid a query per non-empty comment, because the revision
object loads the title on demand, if not set

Change-Id: I891afe9aaa6eeeb8382a6131376c26690082a8c7

includes/specials/SpecialNewpages.php

index 44097c8..4c32c30 100644 (file)
@@ -294,6 +294,8 @@ class SpecialNewpages extends IncludableSpecialPage {
         * @return String
         */
        public function formatRow( $result ) {
+               $title = Title::newFromRow( $result );
+
                # Revision deletion works on revisions, so we should cast one
                $row = array(
                                          'comment' => $result->rc_comment,
@@ -302,13 +304,13 @@ class SpecialNewpages extends IncludableSpecialPage {
                                          'user' => $result->rc_user,
                                        );
                $rev = new Revision( $row );
+               $rev->setTitle( $title );
 
                $classes = array();
 
                $lang = $this->getLanguage();
                $dm = $lang->getDirMark();
 
-               $title = Title::newFromRow( $result );
                $spanTime = Html::element( 'span', array( 'class' => 'mw-newpages-time' ),
                        $lang->userTimeAndDate( $result->rc_timestamp, $this->getUser() )
                );