Perform an early exit

diff --git a/includes/Linker.php b/includes/Linker.php
index 3eaede6..e4b9991 100644 (file)
--- a/includes/Linker.php
+++ b/includes/Linker.php
@@ -760,34 +760,33 @@ class Linker {
         */
        public static function makeBrokenImageLinkObj( $title, $text = '', $query = '', $trail = '', $prefix = '', $time = false ) {
                global $wgEnableUploads, $wgUploadMissingFileUrl;
-               if ( $title instanceof Title ) {
-                       wfProfileIn( __METHOD__ );
-                       $currentExists = $time ? ( wfFindFile( $title ) != false ) : false;
-
-                       list( $inside, $trail ) = self::splitTrail( $trail );
-                       if ( $text == '' )
-                               $text = htmlspecialchars( $title->getPrefixedText() );
-
-                       if ( ( $wgUploadMissingFileUrl || $wgEnableUploads ) && !$currentExists ) {
-                               $redir = RepoGroup::singleton()->getLocalRepo()->checkRedirect( $title );
+               if ( ! $title instanceof Title ) {
+                       return "<!-- ERROR -->{$prefix}{$text}{$trail}";
+               }
+               wfProfileIn( __METHOD__ );
+               $currentExists = $time ? ( wfFindFile( $title ) != false ) : false;
 
-                               if ( $redir ) {
-                                       wfProfileOut( __METHOD__ );
-                                       return self::linkKnown( $title, "$prefix$text$inside", array(), $query ) . $trail;
-                               }
+               list( $inside, $trail ) = self::splitTrail( $trail );
+               if ( $text == '' )
+                       $text = htmlspecialchars( $title->getPrefixedText() );
 
-                               $href = self::getUploadUrl( $title, $query );
+               if ( ( $wgUploadMissingFileUrl || $wgEnableUploads ) && !$currentExists ) {
+                       $redir = RepoGroup::singleton()->getLocalRepo()->checkRedirect( $title );
 
-                               wfProfileOut( __METHOD__ );
-                               return '<a href="' . htmlspecialchars( $href ) . '" class="new" title="' .
-                                       htmlspecialchars( $title->getPrefixedText(), ENT_QUOTES ) . '">' .
-                                       "$prefix$text$inside</a>$trail";
-                       } else {
+                       if ( $redir ) {
                                wfProfileOut( __METHOD__ );
                                return self::linkKnown( $title, "$prefix$text$inside", array(), $query ) . $trail;
                        }
+
+                       $href = self::getUploadUrl( $title, $query );
+
+                       wfProfileOut( __METHOD__ );
+                       return '<a href="' . htmlspecialchars( $href ) . '" class="new" title="' .
+                               htmlspecialchars( $title->getPrefixedText(), ENT_QUOTES ) . '">' .
+                               "$prefix$text$inside</a>$trail";
                } else {
-                       return "<!-- ERROR -->{$prefix}{$text}{$trail}";
+                       wfProfileOut( __METHOD__ );
+                       return self::linkKnown( $title, "$prefix$text$inside", array(), $query ) . $trail;
                }
        }