Workaround for HHVM bug in readline()

https://github.com/facebook/hhvm/issues/4776

Change-Id: I9d3e6817cee2fa2c11e02989a4b11915f0c708f5

diff --git a/maintenance/Maintenance.php b/maintenance/Maintenance.php
index 9b98b20..af14bb3 100644 (file)
--- a/maintenance/Maintenance.php
+++ b/maintenance/Maintenance.php
@@ -1207,7 +1207,13 @@ abstract class Maintenance {
                }
 
                if ( $isatty && function_exists( 'readline' ) ) {
-                       return readline( $prompt );
+                       $resp = readline( $prompt );
+                       if ( $resp === null ) {
+                               // Workaround for https://github.com/facebook/hhvm/issues/4776
+                               return false;
+                       } else {
+                               return $resp;
+                       }
                } else {
                        if ( $isatty ) {
                                $st = self::readlineEmulation( $prompt );