Merge "Improve StaticArrayWriterTest and add missing @covers tag"
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Sun, 19 Aug 2018 17:07:13 +0000 (17:07 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Sun, 19 Aug 2018 17:07:13 +0000 (17:07 +0000)
tests/phpunit/includes/libs/StaticArrayWriterTest.php

index bfb3b58..276fee3 100644 (file)
 
 use Wikimedia\StaticArrayWriter;
 
+/**
+ * @covers \Wikimedia\StaticArrayWriter
+ */
 class StaticArrayWriterTest extends PHPUnit\Framework\TestCase {
        public function testCreate() {
                $data = [
                        'foo' => 'bar',
                        'baz' => 'rawr',
+                       "they're" => '"quoted properly"',
                ];
                $writer = new StaticArrayWriter();
                $actual = $writer->create( $data, "Header\nWith\nNewlines" );
@@ -36,6 +40,7 @@ class StaticArrayWriterTest extends PHPUnit\Framework\TestCase {
 return [
        'foo' => 'bar',
        'baz' => 'rawr',
+       'they\'re' => '"quoted properly"',
 ];
 
 PHP;