Merge "Don't show warning header for non-standard workflows on login-continue"
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Mon, 31 Oct 2016 07:20:43 +0000 (07:20 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Mon, 31 Oct 2016 07:20:43 +0000 (07:20 +0000)
includes/specialpage/LoginSignupSpecialPage.php

index 275e121..aa5bb4e 100644 (file)
@@ -508,7 +508,11 @@ abstract class LoginSignupSpecialPage extends AuthManagerSpecialPage {
                }
 
                // warning header for non-standard workflows (e.g. security reauthentication)
-               if ( !$this->isSignup() && $this->getUser()->isLoggedIn() ) {
+               if (
+                       !$this->isSignup() &&
+                       $this->getUser()->isLoggedIn() &&
+                       $this->authAction !== AuthManager::ACTION_LOGIN_CONTINUE
+               ) {
                        $reauthMessage = $this->securityLevel ? 'userlogin-reauth' : 'userlogin-loggedin';
                        $submitStatus->warning( $reauthMessage, $this->getUser()->getName() );
                }