Merge "for two-stage dumps make the location of MWScript.php alterable"
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Thu, 16 May 2019 16:26:04 +0000 (16:26 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Thu, 16 May 2019 16:26:04 +0000 (16:26 +0000)
includes/libs/rdbms/database/IDatabase.php
includes/specials/pagers/ContribsPager.php

index 05f787c..7452278 100644 (file)
@@ -713,7 +713,8 @@ interface IDatabase {
         *     is applied to a result set after OFFSET.
         *
         *   - FOR UPDATE: Boolean: lock the returned rows so that they can't be
-        *     changed until the next COMMIT.
+        *     changed until the next COMMIT. Cannot be used with aggregate functions
+        *     (COUNT, MAX, etc., but also DISTINCT).
         *
         *   - DISTINCT: Boolean: return only unique result rows.
         *
index e0db715..d82ba53 100644 (file)
@@ -386,7 +386,7 @@ class ContribsPager extends RangeChronologicalPager {
                        }
 
                        $associatedNS = $this->mDb->addQuotes(
-                               MediaWikiServices::getInstance()->getAssociated( $this->namespace )
+                               MediaWikiServices::getInstance()->getNamespaceInfo()->getAssociated( $this->namespace )
                        );
 
                        return [