EditPage: Remove separator between cancel and help
authorAlbert221 <w.albert221@gmail.com>
Mon, 8 Jan 2018 22:18:05 +0000 (23:18 +0100)
committerAlbert221 <w.albert221@gmail.com>
Wed, 10 Jan 2018 06:04:37 +0000 (07:04 +0100)
It is no longer needed because those buttons
are already splitted visually by blank space.

Bug: T183672
Change-Id: I1f8a8413a5f4da441e3f4b4ef0b1e03d174987ca

includes/EditPage.php
resources/src/mediawiki.action/mediawiki.action.edit.styles.less

index 3c109f6..a8be3aa 100644 (file)
@@ -3670,11 +3670,6 @@ class EditPage {
                $out->addHTML( implode( $this->getEditButtons( $tabindex ), "\n" ) . "\n" );
 
                $cancel = $this->getCancelLink();
-               if ( $cancel !== '' ) {
-                       $cancel .= Html::element( 'span',
-                               [ 'class' => 'mw-editButtons-pipe-separator' ],
-                               $this->context->msg( 'pipe-separator' )->text() );
-               }
 
                $message = $this->context->msg( 'edithelppage' )->inContentLanguage()->text();
                $edithelpurl = Skin::makeInternalOrExternalUrl( $message );
index e4443f6..3202e59 100644 (file)
                display: inline-block;
                vertical-align: middle;
        }
-
-       // FIXME: Remove CSS magic together with DOM element in T183672
-       .mw-editButtons-pipe-separator {
-               display: inline-block;
-               padding-top: 0.625em;
-               padding-bottom: 0.546875em;
-               line-height: 1.172em;
-               vertical-align: middle;
-       }
 }