Merge "Improve LanguageConverter performance on pages with many HTML tags"
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Tue, 2 Jul 2019 19:20:32 +0000 (19:20 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Tue, 2 Jul 2019 19:20:32 +0000 (19:20 +0000)
languages/LanguageConverter.php

index c5ff9d6..7fd3631 100644 (file)
@@ -426,8 +426,9 @@ class LanguageConverter {
 
                // We add a marker (\004) at the end of text, to ensure we always match the
                // entire text (Otherwise, pcre.backtrack_limit might cause silent failure)
+               $textWithMarker = $text . "\004";
                while ( $startPos < strlen( $text ) ) {
-                       if ( preg_match( $reg, $text . "\004", $markupMatches, PREG_OFFSET_CAPTURE, $startPos ) ) {
+                       if ( preg_match( $reg, $textWithMarker, $markupMatches, PREG_OFFSET_CAPTURE, $startPos ) ) {
                                $elementPos = $markupMatches[0][1];
                                $element = $markupMatches[0][0];
                                if ( $element === "\004" ) {