Revert "Limit ip-all/subnet-all ping limts per wiki"
authorCSteipp <csteipp@wikimedia.org>
Tue, 9 Feb 2016 19:50:19 +0000 (19:50 +0000)
committerCSteipp <csteipp@wikimedia.org>
Tue, 9 Feb 2016 19:50:19 +0000 (19:50 +0000)
This reverts commit 461406e31864e75fcd1c2f5ac967cb7ba5e5a182.

My mistake, we've always used global keys for ip/subnet.

Change-Id: I8bc1bfdf61ae5c0988a913871a7292faed372141

includes/user/User.php

index 6638fb7..da63075 100644 (file)
@@ -1789,14 +1789,14 @@ class User implements IDBAccessObject {
                        // ip-based limits
                        if ( isset( $limits['ip'] ) ) {
                                $ip = $this->getRequest()->getIP();
-                               $keys[wfMemcKey( 'limiter', $action, 'ip', $ip )] = $limits['ip'];
+                               $keys["mediawiki:limiter:$action:ip:$ip"] = $limits['ip'];
                        }
                        // subnet-based limits
                        if ( isset( $limits['subnet'] ) ) {
                                $ip = $this->getRequest()->getIP();
                                $subnet = IP::getSubnet( $ip );
                                if ( $subnet !== false ) {
-                                       $keys[wfMemcKey( 'limiter', $action, 'subnet', $subnet )] = $limits['subnet'];
+                                       $keys["mediawiki:limiter:$action:subnet:$subnet"] = $limits['subnet'];
                                }
                        }
                }