Originally I wanted to fix the broken type hint for the `Database`
class. But I ended limiting the scope as much as possible and only
type hint at the interfaces that contain the methods the code actually
needs.
Change-Id: I450a55e80612f6e676f7c803dc904b4b653426d8
* @copyright © 2013 Wikimedia Foundation Inc.
*/
* @copyright © 2013 Wikimedia Foundation Inc.
*/
+use Wikimedia\Rdbms\Database;
+use Wikimedia\Rdbms\IDatabase;
+use Wikimedia\Rdbms\IMaintainableDatabase;
use Wikimedia\Rdbms\LBFactory;
use Wikimedia\Rdbms\LBFactorySimple;
use Wikimedia\Rdbms\LBFactoryMulti;
use Wikimedia\Rdbms\LBFactory;
use Wikimedia\Rdbms\LBFactorySimple;
use Wikimedia\Rdbms\LBFactoryMulti;
- /** @var Database $db */
+ /** @var IMaintainableDatabase $db */
$db = $lb->getConnection( DB_MASTER, [], '' );
$this->assertEquals(
$db = $lb->getConnection( DB_MASTER, [], '' );
$this->assertEquals(
]
);
$lb = $factory->getMainLB();
]
);
$lb = $factory->getMainLB();
- /** @var Database $db */
+ /** @var IMaintainableDatabase $db */
$db = $lb->getConnection( DB_MASTER, [], '' );
$this->assertEquals( '', $db->getDomainID(), "Null domain used" );
$db = $lb->getConnection( DB_MASTER, [], '' );
$this->assertEquals( '', $db->getDomainID(), "Null domain used" );
]
);
$lb = $factory->getMainLB();
]
);
$lb = $factory->getMainLB();
- /** @var Database $db */
+ /** @var IDatabase $db */
$db = $lb->getConnection( DB_MASTER, [], '' );
if ( $db->getType() === 'sqlite' ) {
$db = $lb->getConnection( DB_MASTER, [], '' );
if ( $db->getType() === 'sqlite' ) {