*LogPage::timestamp was introduced with r4919 back in 2004, and is unused
since then.
*ApiMain::mCommit was introduced in r33133, then removed in r33381 but that
line was forgotten.
*SpecialRecentChangesLinked::mResultEmpty was introduced in r36682, then
removed at some point with this leftover.
*SpecialStatistics::hook, introduced in r54511 and unused since then.
*MergeMessageFileList::hasError introduced in Id4b16083435ef7f4fce31861c72889e664d07236
and removed in I3d9cf1d614dacaa91fb2092019ccf1d14d61ccab with a leftover
Change-Id: Ie15c148a3217ee8da62874840f3ef7739893f69e
$this->mEnableWrite = $enableWrite;
$this->mCdnMaxAge = -1; // flag for executeActionWithErrorHandling()
$this->mEnableWrite = $enableWrite;
$this->mCdnMaxAge = -1; // flag for executeActionWithErrorHandling()
- $this->mCommit = false;
$dbw = wfGetDB( DB_MASTER );
$dbw = wfGetDB( DB_MASTER );
- // @todo FIXME private/protected/public property?
- $this->timestamp = $now = wfTimestampNow();
+ $now = wfTimestampNow();
$data = [
'log_type' => $this->type,
'log_action' => $this->action,
$data = [
'log_type' => $this->type,
'log_action' => $this->action,
$sql = $dbr->limitResult( $sql, $limit, false );
}
$sql = $dbr->limitResult( $sql, $limit, false );
}
- $res = $dbr->query( $sql, __METHOD__ );
-
- if ( $res->numRows() == 0 ) {
- $this->mResultEmpty = true;
- }
-
- return $res;
+ return $dbr->query( $sql, __METHOD__ );
}
function setTopText( FormOptions $opts ) {
}
function setTopText( FormOptions $opts ) {
$this->total = SiteStats::pages();
$this->users = SiteStats::users();
$this->activeUsers = SiteStats::activeUsers();
$this->total = SiteStats::pages();
$this->users = SiteStats::users();
$this->activeUsers = SiteStats::activeUsers();
$text = Xml::openElement( 'table', [ 'class' => 'wikitable mw-statistics-table' ] );
$text = Xml::openElement( 'table', [ 'class' => 'wikitable mw-statistics-table' ] );
$files = [];
$fileLines = file( $fileName );
if ( $fileLines === false ) {
$files = [];
$fileLines = file( $fileName );
if ( $fileLines === false ) {
- $this->hasError = true;
$this->error( "Unable to open list file $fileName." );
return $files;
$this->error( "Unable to open list file $fileName." );
return $files;
if ( file_exists( $extension ) ) {
$files[] = $extension;
} else {
if ( file_exists( $extension ) ) {
$files[] = $extension;
} else {
- $this->hasError = true;
$this->error( "Extension {$extension} doesn't exist" );
}
}
$this->error( "Extension {$extension} doesn't exist" );
}
}