skins: Move default style modules to getDefaultModules
authorTimo Tijhof <krinklemail@gmail.com>
Tue, 24 Apr 2018 23:22:00 +0000 (00:22 +0100)
committerKrinkle <krinklemail@gmail.com>
Fri, 4 May 2018 23:52:02 +0000 (23:52 +0000)
commit9849db9c79fcc7e6cdca8ccc311aea4265ff337e
tree5e53164bfe5da21fbb25c51c89a7793bb17ca522
parent911e74ea89864f3b0f5455f46d983d280df95e93
skins: Move default style modules to getDefaultModules

This advances T140664 as well, because it encourages module
loading logic from the skin to be in this single method.

Update the tests for setupSkinUserCss(), to now target
getDefaultModules() instead, given setupSkinUserCss() no longer
provides these behaviours. Had to move where the mock object
was created so that it can be injected in the skin (previously
it could be passed as parameter). Besides, its generally best-
practice to create mocks and stubs within the test anyhow, not in
the data provider.

Bug: T140664
Depends-On: Ib2b19ba165a9d646a770702cdf1724509156b93e
Change-Id: I3404c1c2a7e8eae0b803b31f333cb9b837f43d4a
RELEASE-NOTES-1.32
includes/installer/WebInstallerOutput.php
includes/skins/Skin.php
includes/skins/SkinTemplate.php
tests/phpunit/includes/skins/SkinTemplateTest.php