Remove OutputPage::uncacheableBecauseRequestvars()
authorTim Starling <tstarling@wikimedia.org>
Tue, 22 May 2012 23:37:53 +0000 (09:37 +1000)
committerTim Starling <tstarling@wikimedia.org>
Tue, 22 May 2012 23:37:53 +0000 (09:37 +1000)
commit92c7c6f4264d01f84c059f73d597d2f2137a4cfd
treed315ed7f6de7a278bbdeeae6748e8b6b6f3d5f0c
parentf6f3fa86f298a24477a7ac0f04ffe8fbe3e3689d
Remove OutputPage::uncacheableBecauseRequestvars()

Fix for r10265: OutputPage::uncacheableBecauseRequestvars() as written
in that revision is backwards, apparently declaring all requests to be
uncacheable except those with useskin or uselang. Luckily getText() has
always converted its default parameter to a string, so the triple-equals
comparisons always fail, and uncacheableBecauseRequestvars() always
returns false.

In any case, it was never necessary to suppress the client-side cache
for useskin/uselang views, so the accidental behaviour was appropriate.

Change-Id: I520940867509b986a47d63ead9b549e8aa82fa1f
includes/OutputPage.php