SECURITY: Fix permissions check for patrol action
authorKosta Harlan <kharlan@wikimedia.org>
Wed, 3 Oct 2018 16:47:14 +0000 (12:47 -0400)
committerRoan Kattouw <roan.kattouw@gmail.com>
Wed, 3 Oct 2018 19:07:46 +0000 (12:07 -0700)
commit890ffc619dd8fea0526cf76e794835f322d39d0c
treee0e0f787ef667d6ff4a3cfa13d1cb7a3cf711cf5
parente39124462934a1fd0ce432f802e8f44e6126a05c
SECURITY: Fix permissions check for patrol action

Return existing errors instead of empty array in checkUserConfigPermissions().
Returning an empty array wiped out previously-found errors.

Also add test coverage for patrol action.

Bug: T206130
Change-Id: I2df0551c5837adc578b27082ab6ba2ac95d937f8
includes/Title.php
tests/phpunit/includes/TitlePermissionTest.php