ConnectionManager: Require ILoadBalancer instead of LoadBalancer
authorThiemo Kreuz <thiemo.kreuz@wikimedia.de>
Mon, 14 May 2018 11:27:23 +0000 (13:27 +0200)
committerThiemo Kreuz <thiemo.kreuz@wikimedia.de>
Mon, 14 May 2018 11:27:23 +0000 (13:27 +0200)
commit7a9d1afde59ec5fb8aa7e48e3022ae7adc1e5385
tree00fdfe8c8b61a69e02690331d67c38f1e2847236
parent8e6496aaa3713424fe16b71e433c6b253afbf451
ConnectionManager: Require ILoadBalancer instead of LoadBalancer

Since I4fdf7f7 more code stops returning the implementation, but only
returns the interface. This is a good, very welcome change. However,
ConnectionManager still requires the LoadBalancer implementation, for
no obvious reason. All code in this class works fine with the interface.

This is currently reported by Phan as a violation (and it actually is
one), e.g.:
https://integration.wikimedia.org/ci/job/mwext-php70-phan-docker/6433/console

Change-Id: I63cbb98fd277b0c64ab8b303888b9354c4be29e2
includes/libs/rdbms/connectionmanager/ConnectionManager.php