Divert a river through the Augean Stables that is SpecialBlockip.php.
authorHappy-melon <happy-melon@users.mediawiki.org>
Sat, 12 Mar 2011 21:54:35 +0000 (21:54 +0000)
committerHappy-melon <happy-melon@users.mediawiki.org>
Sat, 12 Mar 2011 21:54:35 +0000 (21:54 +0000)
commit78059976086f0ce02cdc328868b5b6ba0e88e576
tree0b5bcd8b7a3f4287c41d5d8693d07e05cdfcf26a
parent8ca4667339a44734d8e393cf14177e31ad992e93
Divert a river through the Augean Stables that is SpecialBlockip.php.
* Move to SpecialBlock.php, and rename class appropriately
* Complete refactor
* Use HTMLForm in block form.  This changes most of the ids and field names on the form, but allows proper validation, nicer formatting, clears up several fixmes, and is generally Better(TM).
* Spin various parts out into static functions, several of which properly belong in the backend (but Block.php is a worse mess still)
* Invert some of the block options so that every checkbox makes the block more severe (so "check to disable email" is fine, but "check to allow usertalk edit" (default true) is inverted to "check to disable usertalk edit" (default false).
* revert r40359 (move doMassUserBlock() to core).  No one seems to be using this function, which has nothing to do with the frontend UI in SpecialBlock (it might perhaps belong in Block.php); it is pretty bespoke for CheckUser, doesn't seem to have very much utility elsewhere.
12 files changed:
RELEASE-NOTES
includes/AutoLoader.php
includes/Block.php
includes/SpecialPage.php
includes/api/ApiBlock.php
includes/api/ApiUnblock.php
includes/specials/SpecialBlock.php [new file with mode: 0644]
includes/specials/SpecialBlockip.php [deleted file]
includes/specials/SpecialIpblocklist.php
languages/messages/MessagesEn.php
maintenance/language/messages.inc
resources/mediawiki.special/mediawiki.special.block.js