Fixed race condition in MessageCache::replace
authorAaron Schulz <aschulz@wikimedia.org>
Wed, 20 May 2015 02:34:20 +0000 (19:34 -0700)
committerAaron Schulz <aschulz@wikimedia.org>
Thu, 4 Jun 2015 20:53:37 +0000 (13:53 -0700)
commit4028bcb506c022f620b7702e1033b64c68d95bbc
treefc696e4820aff509e2d81d22cacd5efa87c87020
parent6ffdc1cdcacaccf95572758444381565cb982698
Fixed race condition in MessageCache::replace

* The cache has to reload and *after* locking to avoid
  losing any concurrent changes.
* Also fixed incorrect assumption in MessageCacheTest.
  Message overrides for the content language do not use
  the language suffix.

Change-Id: I98ff158a1575330bc59efe6badb27f8de8717951
includes/cache/MessageCache.php
tests/phpunit/includes/cache/MessageCacheTest.php