rdbms: normalize Database/LBFactory logging and add snapshot flushing warnings
authorAaron Schulz <aschulz@wikimedia.org>
Sat, 29 Jun 2019 03:21:28 +0000 (20:21 -0700)
committerAaron Schulz <aschulz@wikimedia.org>
Sat, 6 Jul 2019 20:10:24 +0000 (13:10 -0700)
commit04d591935cf117a890ae890912ec59b560da4f54
treef060c40d29da1789294d6c6f1ce101a04c448b1a
parentd71db83e748fc4e68ba2105ff5501b986589cebe
rdbms: normalize Database/LBFactory logging and add snapshot flushing warnings

Make flushSnapshot() logging more detailed and check for explicit transaction
rounds. Also removing periods and trailing newlines from log/exception messages.

Change-Id: I0f6520f563680ab3a65b6338ced59ba25a2ec7b5
includes/libs/rdbms/database/DBConnRef.php
includes/libs/rdbms/database/Database.php
includes/libs/rdbms/database/IDatabase.php
includes/libs/rdbms/lbfactory/ILBFactory.php
includes/libs/rdbms/lbfactory/LBFactory.php
includes/libs/rdbms/loadbalancer/ILoadBalancer.php
includes/libs/rdbms/loadbalancer/LoadBalancer.php
tests/phpunit/includes/libs/rdbms/database/DatabaseSQLTest.php