X-Git-Url: http://git.heureux-cyclage.org/?a=blobdiff_plain;f=install-utils.inc;h=62d35c62432429c331788a30d5e272cf284ab7b0;hb=3c7916c8e08d97455a98bebff456227d683e881d;hp=2bd313484683e5f3e17af5e6414c4f8b68005c17;hpb=0332f4c59809e5a89f626e8969cd76261819f432;p=lhc%2Fweb%2Fwiklou.git

diff --git a/install-utils.inc b/install-utils.inc
index 2bd3134846..62d35c6243 100644
--- a/install-utils.inc
+++ b/install-utils.inc
@@ -1,20 +1,21 @@
 <?php
 
 function install_version_checks() {
-	if( !function_exists( "version_compare" ) ) {
+	# We dare not turn output buffer _off_ since this will break completely
+	# if PHP is globally configured to run through a gzip filter.
+	@ob_implicit_flush( true );
+	
+	if( !function_exists( 'version_compare' ) ) {
 		# version_compare was introduced in 4.1.0
 		die( "Your PHP version is much too old; 4.0.x will _not_ work. 4.3.2 or higher is recommended. ABORTING.\n" );
 	}
-	if( version_compare( phpversion(), "4.3.2" ) < 0 ) {
+	if( version_compare( phpversion(), '4.3.2' ) < 0 ) {
 		echo "WARNING: PHP 4.3.2 or higher is recommended. Older versions from 4.1.x up may work but are not actively supported.\n\n";
 	}
-	if( !ini_get( "register_globals" ) ) {
-		echo "WARNING: register_globals is not on; MediaWiki currently relies on this option.\n\n";
-	}
 	
 	if (!extension_loaded('mysql')) {
 		if (!dl('mysql.so')) {
-			print "Could not load MySQL driver! Please compile ".
+			print 'Could not load MySQL driver! Please compile '.
 				  "php --with-mysql or install the mysql.so module.\n";
 		exit;
 		}
@@ -27,16 +28,20 @@ function install_version_checks() {
 }
 
 function copyfile( $sdir, $name, $ddir, $perms = 0664 ) {
+	copyfileto( $sdir, $name, $ddir, $name, $perms );
+}
+
+function copyfileto( $sdir, $sname, $ddir, $dname, $perms = 0664 ) {
 	global $wgInstallOwner, $wgInstallGroup;
 
-	$d = "{$ddir}/{$name}";
-	if ( copy( "{$sdir}/{$name}", $d ) ) {
+	$d = "{$ddir}/{$dname}";
+	if ( copy( "{$sdir}/{$sname}", $d ) ) {
 		if ( isset( $wgInstallOwner ) ) { chown( $d, $wgInstallOwner ); }
 		if ( isset( $wgInstallGroup ) ) { chgrp( $d, $wgInstallGroup ); }
 		chmod( $d, $perms );
-		# print "Copied \"{$name}\" to \"{$ddir}\".\n";
+		# print "Copied \"{$sname}\" to \"{$d}\".\n";
 	} else {
-		print "Failed to copy file \"{$name}\" to \"{$ddir}\".\n";
+		print "Failed to copy file \"{$sname}\" to \"{$ddir}/{$dname}\".\n";
 		exit();
 	}
 }
@@ -45,30 +50,40 @@ function copydirectory( $source, $dest ) {
 	$handle = opendir( $source );
 	while ( false !== ( $f = readdir( $handle ) ) ) {
 		$fullname = "$source/$f";
-		if ( $f{0} !="." && is_file( $fullname ) ) {
+		if ( $f{0} != '.' && is_file( $fullname ) ) {
 			copyfile( $source, $f, $dest );
 		}
 	}
 }
 
-function readconsole() {
-	$fp = fopen( "php://stdin", "r" );
-	$resp = trim( fgets( $fp, 1024 ) );
-	fclose( $fp );
-	return $resp;
+function readconsole( $prompt = '' ) {
+	if ( function_exists( 'readline' ) ) {
+		return readline( $prompt );
+	} else {
+		print $prompt;
+		$fp = fopen( 'php://stdin', 'r' );
+		$st = fgets($fp, 1024);
+		if ($st === false) return false;
+		$resp = trim( $st );
+		fclose( $fp );
+		return $resp;
+	}
 }
 
-
 function replacevars( $ins ) {
 	$varnames = array(
-		"wgDBserver", "wgDBname", "wgDBintlname", "wgDBuser",
-		"wgDBpassword", "wgDBsqluser", "wgDBsqlpassword",
-		"wgDBadminuser", "wgDBadminpassword"
+		'wgDBserver', 'wgDBname', 'wgDBintlname', 'wgDBuser',
+		'wgDBpassword', 'wgDBsqluser', 'wgDBsqlpassword',
+		'wgDBadminuser', 'wgDBadminpassword', 'wgDBprefix'
 	);
 
 	foreach ( $varnames as $var ) {
-		global $$var;
-		$ins = str_replace( '{$' . $var . '}', $$var, $ins );
+		if( isset( $GLOBALS[$var] ) ) {
+			$val = addslashes( $GLOBALS[$var] );
+			$ins = str_replace( '{$' . $var . '}', $val, $ins );
+			$ins = str_replace( '/*$' . $var . '*/`', '`' . $val, $ins );
+			$ins = str_replace( '/*$' . $var . '*/', $val, $ins );
+		}
 	}
 	return $ins;
 }
@@ -77,7 +92,7 @@ function replacevars( $ins ) {
 # Read and execute SQL commands from a file
 #
 function dbsource( $fname, $database = false ) {
-	$fp = fopen( $fname, "r" );
+	$fp = fopen( $fname, 'r' );
 	if ( false === $fp ) {
 		print "Could not open \"{$fname}\".\n";
 		exit();
@@ -91,14 +106,14 @@ function dbsource( $fname, $database = false ) {
 		$sl = strlen( $line ) - 1;
 
 		if ( $sl < 0 ) { continue; }
-		if ( "-" == $line{0} && "-" == $line{1} ) { continue; }
+		if ( '-' == $line{0} && '-' == $line{1} ) { continue; }
 
-		if ( ";" == $line{$sl} ) {
+		if ( ';' == $line{$sl} ) {
 			$done = true;
 			$line = substr( $line, 0, $sl );
 		}
 
-		if ( "" != $cmd ) { $cmd .= " "; }
+		if ( '' != $cmd ) { $cmd .= ' '; }
 		$cmd .= $line;
 
 		if ( $done ) {
@@ -109,11 +124,12 @@ function dbsource( $fname, $database = false ) {
 				$res = mysql_query( $cmd );
 
 			if ( false === $res ) {
-				print "Query \"{$cmd}\" failed.\n";
+				$err = mysql_error();
+				print "Query \"{$cmd}\" failed with error code \"$err\".\n";
 				exit();
 			}
 
-			$cmd = "";
+			$cmd = '';
 			$done = false;
 		}
 	}
@@ -122,11 +138,12 @@ function dbsource( $fname, $database = false ) {
 
 # Obsolete, use Database::fieldExists()
 function field_exists( $table, $field ) {
-	$fname = "Update script: field_exists";
-	$res = wfQuery( "DESCRIBE $table", $fname );
+	$fname = 'Update script: field_exists';
+	$db =& wfGetDB( DB_SLAVE );
+	$res = $db->query( "DESCRIBE $table", $fname );
 	$found = false;
 	
-	while ( $row = wfFetchObject( $res ) ) {
+	while ( $row = $db->fetchObject( $res ) ) {
 		if ( $row->Field == $field ) {
 			$found = true;
 			break;