X-Git-Url: http://git.heureux-cyclage.org/?a=blobdiff_plain;f=includes%2Finstaller%2FWebInstallerOptions.php;h=7bec49a369ede5b10bdfc346640d1c1eec3c1a81;hb=28f9e6277efda6635c1a73122f047557d6a64edb;hp=7c1619ab5a4c640b29b30f26fa951e9819462312;hpb=0e8afecabc6957970325c213aec75267ae45487f;p=lhc%2Fweb%2Fwiklou.git

diff --git a/includes/installer/WebInstallerOptions.php b/includes/installer/WebInstallerOptions.php
index 7c1619ab5a..7bec49a369 100644
--- a/includes/installer/WebInstallerOptions.php
+++ b/includes/installer/WebInstallerOptions.php
@@ -105,6 +105,7 @@ class WebInstallerOptions extends WebInstallerPage {
 		);
 
 		$skins = $this->parent->findExtensions( 'skins' )->value;
+		'@phan-var array[] $skins';
 		$skinHtml = $this->getFieldsetStart( 'config-skins' );
 
 		$skinNames = array_map( 'strtolower', array_keys( $skins ) );
@@ -118,7 +119,6 @@ class WebInstallerOptions extends WebInstallerPage {
 				'value' => $chosenSkinName,
 			] );
 
-			// @phan-suppress-next-line PhanTypeNoAccessiblePropertiesForeach
 			foreach ( $skins as $skin => $info ) {
 				if ( isset( $info['screenshots'] ) ) {
 					$screenshotText = $this->makeScreenshotsLink( $skin, $info['screenshots'] );
@@ -146,6 +146,7 @@ class WebInstallerOptions extends WebInstallerPage {
 		$this->addHTML( $skinHtml );
 
 		$extensions = $this->parent->findExtensions()->value;
+		'@phan-var array[] $extensions';
 		$dependencyMap = [];
 
 		if ( $extensions ) {
@@ -154,7 +155,6 @@ class WebInstallerOptions extends WebInstallerPage {
 			$extByType = [];
 			$types = SpecialVersion::getExtensionTypes();
 			// Sort by type first
-			// @phan-suppress-next-line PhanTypeNoAccessiblePropertiesForeach
 			foreach ( $extensions as $ext => $info ) {
 				if ( !isset( $info['type'] ) || !isset( $types[$info['type']] ) ) {
 					// We let extensions normally define custom types, but
@@ -326,13 +326,16 @@ class WebInstallerOptions extends WebInstallerPage {
 		return null;
 	}
 
+	/**
+	 * @param string $name
+	 * @param array $screenshots
+	 */
 	private function makeScreenshotsLink( $name, $screenshots ) {
 		global $wgLang;
 		if ( count( $screenshots ) > 1 ) {
 			$links = [];
 			$counter = 1;
 
-			// @phan-suppress-next-line PhanTypeNoAccessiblePropertiesForeach
 			foreach ( $screenshots as $shot ) {
 				$links[] = Html::element(
 					'a',