X-Git-Url: http://git.heureux-cyclage.org/?a=blobdiff_plain;f=includes%2Fchanges%2FRecentChange.php;h=819f1701dc22df136ffba11f87f05b7037ab9d16;hb=a5fa7ece8a5f77668e74c15828e20635a3d0f402;hp=60fe85009c57ad46a7ae731f910aae0bb610bcc7;hpb=1b4f3579017a46344a9f1857db241bc3909bb7f5;p=lhc%2Fweb%2Fwiklou.git

diff --git a/includes/changes/RecentChange.php b/includes/changes/RecentChange.php
index 60fe85009c..819f1701dc 100644
--- a/includes/changes/RecentChange.php
+++ b/includes/changes/RecentChange.php
@@ -490,7 +490,7 @@ class RecentChange {
 
 	/**
 	 * Notify all the feeds about the change.
-	 * @param array $feeds Optional feeds to send to, defaults to $wgRCFeeds
+	 * @param array|null $feeds Optional feeds to send to, defaults to $wgRCFeeds
 	 */
 	public function notifyRCFeeds( array $feeds = null ) {
 		global $wgRCFeeds;
@@ -520,11 +520,7 @@ class RecentChange {
 				continue;
 			}
 
-			if ( isset( $this->mExtra['actionCommentIRC'] ) ) {
-				$actionComment = $this->mExtra['actionCommentIRC'];
-			} else {
-				$actionComment = null;
-			}
+			$actionComment = $this->mExtra['actionCommentIRC'] ?? null;
 
 			$feed = RCFeed::factory( $params );
 			$feed->notify( $this, $actionComment );
@@ -560,7 +556,7 @@ class RecentChange {
 	 *
 	 * @param RecentChange|int $change RecentChange or corresponding rc_id
 	 * @param bool $auto For automatic patrol
-	 * @param string|string[] $tags Change tags to add to the patrol log entry
+	 * @param string|string[]|null $tags Change tags to add to the patrol log entry
 	 *   ($user should be able to add the specified tags before this is called)
 	 * @return array See doMarkPatrolled(), or null if $change is not an existing rc_id
 	 */
@@ -585,7 +581,7 @@ class RecentChange {
 	 * 'markedaspatrollederror-noautopatrol' as errors
 	 * @param User $user User object doing the action
 	 * @param bool $auto For automatic patrol
-	 * @param string|string[] $tags Change tags to add to the patrol log entry
+	 * @param string|string[]|null $tags Change tags to add to the patrol log entry
 	 *   ($user should be able to add the specified tags before this is called)
 	 * @return array Array of permissions errors, see Title::getUserPermissionsErrors()
 	 */
@@ -662,9 +658,9 @@ class RecentChange {
 	 * Makes an entry in the database corresponding to an edit
 	 *
 	 * @param string $timestamp
-	 * @param Title &$title
+	 * @param Title $title
 	 * @param bool $minor
-	 * @param User &$user
+	 * @param User $user
 	 * @param string $comment
 	 * @param int $oldId
 	 * @param string $lastTimestamp
@@ -678,7 +674,7 @@ class RecentChange {
 	 * @return RecentChange
 	 */
 	public static function notifyEdit(
-		$timestamp, &$title, $minor, &$user, $comment, $oldId, $lastTimestamp,
+		$timestamp, $title, $minor, $user, $comment, $oldId, $lastTimestamp,
 		$bot, $ip = '', $oldSize = 0, $newSize = 0, $newId = 0, $patrol = 0,
 		$tags = []
 	) {
@@ -739,9 +735,9 @@ class RecentChange {
 	 * Note: the title object must be loaded with the new id using resetArticleID()
 	 *
 	 * @param string $timestamp
-	 * @param Title &$title
+	 * @param Title $title
 	 * @param bool $minor
-	 * @param User &$user
+	 * @param User $user
 	 * @param string $comment
 	 * @param bool $bot
 	 * @param string $ip
@@ -752,7 +748,7 @@ class RecentChange {
 	 * @return RecentChange
 	 */
 	public static function notifyNew(
-		$timestamp, &$title, $minor, &$user, $comment, $bot,
+		$timestamp, $title, $minor, $user, $comment, $bot,
 		$ip = '', $size = 0, $newId = 0, $patrol = 0, $tags = []
 	) {
 		$rc = new RecentChange;
@@ -809,8 +805,8 @@ class RecentChange {
 
 	/**
 	 * @param string $timestamp
-	 * @param Title &$title
-	 * @param User &$user
+	 * @param Title $title
+	 * @param User $user
 	 * @param string $actionComment
 	 * @param string $ip
 	 * @param string $type
@@ -822,7 +818,7 @@ class RecentChange {
 	 * @param string $actionCommentIRC
 	 * @return bool
 	 */
-	public static function notifyLog( $timestamp, &$title, &$user, $actionComment, $ip, $type,
+	public static function notifyLog( $timestamp, $title, $user, $actionComment, $ip, $type,
 		$action, $target, $logComment, $params, $newId = 0, $actionCommentIRC = ''
 	) {
 		global $wgLogRestrictions;
@@ -840,8 +836,8 @@ class RecentChange {
 
 	/**
 	 * @param string $timestamp
-	 * @param Title &$title
-	 * @param User &$user
+	 * @param Title $title
+	 * @param User $user
 	 * @param string $actionComment
 	 * @param string $ip
 	 * @param string $type
@@ -855,7 +851,7 @@ class RecentChange {
 	 * @param bool $isPatrollable Whether this log entry is patrollable
 	 * @return RecentChange
 	 */
-	public static function newLogEntry( $timestamp, &$title, &$user, $actionComment, $ip,
+	public static function newLogEntry( $timestamp, $title, $user, $actionComment, $ip,
 		$type, $action, $target, $logComment, $params, $newId = 0, $actionCommentIRC = '',
 		$revId = 0, $isPatrollable = false ) {
 		global $wgRequest;
@@ -936,7 +932,7 @@ class RecentChange {
 	 *
 	 * @param string $timestamp Timestamp of the recent change to occur
 	 * @param Title $categoryTitle Title of the category a page is being added to or removed from
-	 * @param User $user User object of the user that made the change
+	 * @param User|null $user User object of the user that made the change
 	 * @param string $comment Change summary
 	 * @param Title $pageTitle Title of the page that is being added or removed
 	 * @param int $oldRevId Parent revision ID of this change
@@ -945,7 +941,7 @@ class RecentChange {
 	 * @param bool $bot true, if the change was made by a bot
 	 * @param string $ip IP address of the user, if the change was made anonymously
 	 * @param int $deleted Indicates whether the change has been deleted
-	 * @param bool $added true, if the category was added, false for removed
+	 * @param bool|null $added true, if the category was added, false for removed
 	 *
 	 * @return RecentChange
 	 */